Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95701/?format=api
{ "id": 95701, "url": "http://patches.dpdk.org/api/patches/95701/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210712093914.441114-1-simei.su@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210712093914.441114-1-simei.su@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210712093914.441114-1-simei.su@intel.com", "date": "2021-07-12T09:39:14", "name": "net/ice: fix SPI for ESP and NATT not work issue", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "05ca6907a66c6b50a86f53101d2a6ab736b18fe5", "submitter": { "id": 1298, "url": "http://patches.dpdk.org/api/people/1298/?format=api", "name": "Simei Su", "email": "simei.su@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210712093914.441114-1-simei.su@intel.com/mbox/", "series": [ { "id": 17769, "url": "http://patches.dpdk.org/api/series/17769/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17769", "date": "2021-07-12T09:39:14", "name": "net/ice: fix SPI for ESP and NATT not work issue", "version": 1, "mbox": "http://patches.dpdk.org/series/17769/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/95701/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/95701/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 89059A0C48;\n\tMon, 12 Jul 2021 11:48:02 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4CFF94069D;\n\tMon, 12 Jul 2021 11:48:02 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 5A99E40685\n for <dev@dpdk.org>; Mon, 12 Jul 2021 11:48:00 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Jul 2021 02:47:59 -0700", "from unknown (HELO npg-dpdk-cvl-simeisu-118d193.sh.intel.com)\n ([10.67.119.195])\n by FMSMGA003.fm.intel.com with ESMTP; 12 Jul 2021 02:47:57 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10042\"; a=\"209993637\"", "E=Sophos;i=\"5.84,232,1620716400\"; d=\"scan'208\";a=\"209993637\"", "E=Sophos;i=\"5.84,232,1620716400\"; d=\"scan'208\";a=\"491959336\"" ], "X-ExtLoop1": "1", "From": "Simei Su <simei.su@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tyahui.cao@intel.com,\n\tSimei Su <simei.su@intel.com>", "Date": "Mon, 12 Jul 2021 17:39:14 +0800", "Message-Id": "<20210712093914.441114-1-simei.su@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[dpdk-dev] [PATCH] net/ice: fix SPI for ESP and NATT not work issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes this issue by adding the correspongding input set for\nESP and NATT when parsing input set. Also, it adds input set bit for\nNAT_T_ESP to distinguish ESP over IP and ESP over UDP.\n\nFixes: 70feafc1a3f2 (\"net/ice: support ESP/NATT flow director to match outer IP\")\n\nSigned-off-by: Simei Su <simei.su@intel.com>\n---\n drivers/net/ice/ice_fdir_filter.c | 14 ++++++++++----\n drivers/net/ice/ice_generic_flow.h | 3 +++\n 2 files changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c\nindex 4f1aa39..82adb1f 100644\n--- a/drivers/net/ice/ice_fdir_filter.c\n+++ b/drivers/net/ice/ice_fdir_filter.c\n@@ -100,11 +100,11 @@\n \n #define ICE_FDIR_INSET_IPV4_NATT_ESP (\\\n \tICE_INSET_IPV4_SRC | ICE_INSET_IPV4_DST | \\\n-\tICE_INSET_ESP_SPI)\n+\tICE_INSET_NAT_T_ESP_SPI)\n \n #define ICE_FDIR_INSET_IPV6_NATT_ESP (\\\n \tICE_INSET_IPV6_SRC | ICE_INSET_IPV6_DST | \\\n-\tICE_INSET_ESP_SPI)\n+\tICE_INSET_NAT_T_ESP_SPI)\n \n static struct ice_pattern_match_item ice_fdir_pattern_list[] = {\n \t{pattern_ethertype,\t\t\t\tICE_FDIR_INSET_ETH,\t\tICE_INSET_NONE,\t\t\tICE_INSET_NONE},\n@@ -951,6 +951,8 @@ ice_fdir_input_set_parse(uint64_t inset, enum ice_flow_field *field)\n \t\t{ICE_INSET_GTPU_TEID, ICE_FLOW_FIELD_IDX_GTPU_IP_TEID},\n \t\t{ICE_INSET_GTPU_QFI, ICE_FLOW_FIELD_IDX_GTPU_EH_QFI},\n \t\t{ICE_INSET_VXLAN_VNI, ICE_FLOW_FIELD_IDX_VXLAN_VNI},\n+\t\t{ICE_INSET_ESP_SPI, ICE_FLOW_FIELD_IDX_ESP_SPI},\n+\t\t{ICE_INSET_NAT_T_ESP_SPI, ICE_FLOW_FIELD_IDX_NAT_T_ESP_SPI},\n \t};\n \n \tfor (i = 0, j = 0; i < RTE_DIM(ice_inset_map); i++) {\n@@ -2128,8 +2130,12 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,\n \t\t\tif (!(esp_spec && esp_mask))\n \t\t\t\tbreak;\n \n-\t\t\tif (esp_mask->hdr.spi == UINT32_MAX)\n-\t\t\t\t*input_set |= ICE_INSET_ESP_SPI;\n+\t\t\tif (esp_mask->hdr.spi == UINT32_MAX) {\n+\t\t\t\tif (l4 == RTE_FLOW_ITEM_TYPE_UDP)\n+\t\t\t\t\t*input_set |= ICE_INSET_NAT_T_ESP_SPI;\n+\t\t\t\telse\n+\t\t\t\t\t*input_set |= ICE_INSET_ESP_SPI;\n+\t\t\t}\n \n \t\t\tif (l3 == RTE_FLOW_ITEM_TYPE_IPV4)\n \t\t\t\tfilter->input.ip.v4.sec_parm_idx =\ndiff --git a/drivers/net/ice/ice_generic_flow.h b/drivers/net/ice/ice_generic_flow.h\nindex 0bd38d8..8845a3e 100644\n--- a/drivers/net/ice/ice_generic_flow.h\n+++ b/drivers/net/ice/ice_generic_flow.h\n@@ -26,6 +26,7 @@\n #define ICE_PROT_AH\t\t\tBIT_ULL(15)\n #define ICE_PROT_L2TPV3OIP\t\tBIT_ULL(16)\n #define ICE_PROT_PFCP\t\t\tBIT_ULL(17)\n+#define ICE_PROT_NAT_T_ESP\t\tBIT_ULL(18)\n \n /* field */\n \n@@ -117,6 +118,8 @@\n \t(ICE_PROT_PFCP | ICE_PFCP_S_FIELD)\n #define ICE_INSET_PFCP_SEID \\\n \t(ICE_PROT_PFCP | ICE_PFCP_S_FIELD | ICE_PFCP_SEID)\n+#define ICE_INSET_NAT_T_ESP_SPI \\\n+\t(ICE_PROT_NAT_T_ESP | ICE_ESP_SPI)\n \n /* empty pattern */\n extern enum rte_flow_item_type pattern_empty[];\n", "prefixes": [] }