Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95668/?format=api
{ "id": 95668, "url": "http://patches.dpdk.org/api/patches/95668/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210712014654.32428-12-suanmingm@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210712014654.32428-12-suanmingm@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210712014654.32428-12-suanmingm@nvidia.com", "date": "2021-07-12T01:46:39", "name": "[v5,11/26] net/mlx5: relax the list utility atomic operations", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "dbf1037688c37fdc5b69994a2787c399307446ca", "submitter": { "id": 1887, "url": "http://patches.dpdk.org/api/people/1887/?format=api", "name": "Suanming Mou", "email": "suanmingm@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210712014654.32428-12-suanmingm@nvidia.com/mbox/", "series": [ { "id": 17759, "url": "http://patches.dpdk.org/api/series/17759/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17759", "date": "2021-07-12T01:46:29", "name": "net/mlx5: insertion rate optimization", "version": 5, "mbox": "http://patches.dpdk.org/series/17759/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/95668/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/95668/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E4052A0C4B;\n\tMon, 12 Jul 2021 03:48:51 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ED200411BD;\n\tMon, 12 Jul 2021 03:47:49 +0200 (CEST)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2046.outbound.protection.outlook.com [40.107.220.46])\n by mails.dpdk.org (Postfix) with ESMTP id 9CB2F4119E\n for <dev@dpdk.org>; Mon, 12 Jul 2021 03:47:45 +0200 (CEST)", "from BN6PR13CA0021.namprd13.prod.outlook.com (2603:10b6:404:10a::31)\n by DM6PR12MB4973.namprd12.prod.outlook.com (2603:10b6:5:1b7::14) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.21; Mon, 12 Jul\n 2021 01:47:44 +0000", "from BN8NAM11FT013.eop-nam11.prod.protection.outlook.com\n (2603:10b6:404:10a:cafe::f1) by BN6PR13CA0021.outlook.office365.com\n (2603:10b6:404:10a::31) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.11 via Frontend\n Transport; Mon, 12 Jul 2021 01:47:44 +0000", "from mail.nvidia.com (216.228.112.34) by\n BN8NAM11FT013.mail.protection.outlook.com (10.13.176.182) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4308.20 via Frontend Transport; Mon, 12 Jul 2021 01:47:43 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Jul\n 2021 01:47:29 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=eYGfy3xmFjSaj2dsG+AdQMOIt8SeCxxCnAICxgxabCyphESyflAaJHu9fS+7zQ5DvQ71L7uULZCazoCcfP1zrZgkMgV+BxeYaLXVl4UOHXybH7QR8EaOFh5sq4In1ybIHLYto49BiV8TSt72r8ohunyDAEVGHNYv9i7ciQZTt31mVWSZjJlk7/zUWrb8OEqsaDv30P/aQb66dF5ty++qGi7Lf0+x/O+eKMaQTwr8rX0HxS+tHC79VkoEXMQsFHNN1QOqp2ruIg3ssnEx88vu3OMEdEkkzr9coezUvw0wyVHzFzlLguN22ryUzPpMx9VPrmeB5iXPKO9GKtQNw5l+dQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=3WHS4+y1MC7Wqkt3Mfoua9AgUjhNaCjxde6iAfwyUdE=;\n b=S4HolVUBiGUU3Nhf1tyrBvqxEbSKt08oev5XZPwhhypWbzDUcNaTSudPiiDrSZIfFl3aK0dIPE3wbR7kppAcSXztaxenmcZb9tmq6KsXnOaKZ8lJfrfyGvpjhxVrvSfvtY9n5XZetjdDm+XHm0YL332ntGrFSoku+4RQ8oD88C9l4MqmHQ9VVkeSZW2DyeIU5tR2icDVsJnv1CV4I09aRSW492/8WtRMHjpkITnWXs27A9JgZ0m6tVHbx4CUuUNeeLEzlanJEyA8OArRqtYM7M5FFxruYa4zcRGJsg+LBNrFsXYBWSVdCC8CZYkPCz+4gkqtMSAM0j2069uy3Ma64w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=3WHS4+y1MC7Wqkt3Mfoua9AgUjhNaCjxde6iAfwyUdE=;\n b=VYJIk0OFsb2wV4DIxhfgu2teMHWJ7BoQDSE2WncQdJ18jUVLFwhrrvKvX63jjEkfgczy8tQXSyfkM4hsnTEyc12eNEFTTsJzTXIJTSTPF46q+nmte5JcTDomosNUpvmVxCbhoeFiY2KoYebpEIynm9zcL7HaXSc1UcVUMTjCHCGsqrjR7OdCiOHgzRnKVkXYYeMPEKOaL5dvDl0jb/JI7p2KOplmM1GXOqzA5Ow4EkrSgbvboA7IXWOkwr6CGZggHNa5AO9y/E0cna1Me9KC8NcZ5s4ILTXYa+x49m7gudJ49pxEQiKKp4623sLO3Pc19VGtdiEx0a3WWmLwzEofpg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Suanming Mou <suanmingm@nvidia.com>", "To": "<viacheslavo@nvidia.com>, <matan@nvidia.com>", "CC": "<rasland@nvidia.com>, <orika@nvidia.com>, <dev@dpdk.org>", "Date": "Mon, 12 Jul 2021 04:46:39 +0300", "Message-ID": "<20210712014654.32428-12-suanmingm@nvidia.com>", "X-Mailer": "git-send-email 2.18.1", "In-Reply-To": "<20210712014654.32428-1-suanmingm@nvidia.com>", "References": "<20210527093403.1153127-1-suanmingm@nvidia.com>\n <20210712014654.32428-1-suanmingm@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL101.nvidia.com (172.20.187.10) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "a584ee00-9251-485c-51b9-08d944d70aec", "X-MS-TrafficTypeDiagnostic": "DM6PR12MB4973:", "X-Microsoft-Antispam-PRVS": "\n <DM6PR12MB497396ECF3C885D19DB3A728C1159@DM6PR12MB4973.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:249;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 6xvOrNKC4zAcWUpkurZOirYoRgh4I0f+SVcUxJ1+A6NhoJL7kRKEK0JXAlTs6s6cwVNjm2nBLCwnFd8NVRsXXNjYl3MLXy/V/UcVhf6rOK7jw/eevRvX73fUAdhmbh9ZENigbXxY2DBx6ZjXvNQB/FqQunXjvHfe+Q7FFM0sljbzZLJfOOiPrgjbgbKiliv7V+TBMYhQK9Wu9sN45Ihlkt/KeZFBdhAgaK/rzb0dUzRvuhOyNlIfeCJPmi9wt0Ks/6XdX644j9GcPDoZ8Sh6wBWSpYUZGfHAlV03dqQhDBBiLbyZn/aBSDFTHZmy7YpmhYIHpH1atnNngfdNMcUa75iO0Xyr42PKH7+/tmpBs/ZWsFcYDcTkPJSkxN7euLk7D2cRkOPoojTr6NVmYpYdLubSVuQ1m+BmzLO8typfibWBs+KgBSwEtkPaY9nqWguuy6syFIfsph5GGnz8Xt/CsCOY4UelqKAUuwGNEtkVeWD+iueiUhiTIS06dyQrnd+Hh7Cuhy4sxj9vKqm1cvLrF9mZT/vJnREAx1Wp3RvI7iOGhA9VB2VLsy+rPEyz0L3WZ1O6jVncmBktXDhO5L5jmHuaCjdfS+VP+Ea9pERFWUiJuIgkXcCFby4nbalaEnepCDU9gVyJ8RMM6TDMZ+9IqDB/Kb61ts+JjTSLBG0OqvzxMAmguGkJDxsSYKGriqIpymc3/5HkIOY6t7Hv+ncdsPhZWhOazbmGPaLjE2goL4o=", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(39860400002)(136003)(396003)(376002)(346002)(36840700001)(46966006)(336012)(478600001)(7696005)(5660300002)(2906002)(16526019)(26005)(186003)(55016002)(1076003)(6286002)(47076005)(36756003)(8936002)(82310400003)(34020700004)(8676002)(110136005)(6666004)(36906005)(82740400003)(4326008)(7636003)(54906003)(70586007)(70206006)(356005)(6636002)(316002)(426003)(2616005)(36860700001)(86362001)(83380400001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Jul 2021 01:47:43.9789 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n a584ee00-9251-485c-51b9-08d944d70aec", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT013.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB4973", "Subject": "[dpdk-dev] [PATCH v5 11/26] net/mlx5: relax the list utility atomic\n operations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Matan Azrad <matan@nvidia.com>\n\nThe atomic operation in the list utility no need a barriers because the\ncritical part are managed by RW lock.\n\nRelax them.\n\nSigned-off-by: Matan Azrad <matan@nvidia.com>\nAcked-by: Suanming Mou <suanmingm@nvidia.com>\n---\n drivers/net/mlx5/mlx5_utils.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c\nindex 13c7dbe1c2..daecf37575 100644\n--- a/drivers/net/mlx5/mlx5_utils.c\n+++ b/drivers/net/mlx5/mlx5_utils.c\n@@ -50,13 +50,13 @@ __list_lookup(struct mlx5_list *list, int lcore_index, void *ctx, bool reuse)\n \t\tif (list->cb_match(list, entry, ctx) == 0) {\n \t\t\tif (reuse) {\n \t\t\t\tret = __atomic_add_fetch(&entry->ref_cnt, 1,\n-\t\t\t\t\t\t\t __ATOMIC_ACQUIRE) - 1;\n+\t\t\t\t\t\t\t __ATOMIC_RELAXED) - 1;\n \t\t\t\tDRV_LOG(DEBUG, \"mlx5 list %s entry %p ref: %u.\",\n \t\t\t\t\tlist->name, (void *)entry,\n \t\t\t\t\tentry->ref_cnt);\n \t\t\t} else if (lcore_index < RTE_MAX_LCORE) {\n \t\t\t\tret = __atomic_load_n(&entry->ref_cnt,\n-\t\t\t\t\t\t __ATOMIC_ACQUIRE);\n+\t\t\t\t\t\t __ATOMIC_RELAXED);\n \t\t\t}\n \t\t\tif (likely(ret != 0 || lcore_index == RTE_MAX_LCORE))\n \t\t\t\treturn entry;\n@@ -181,7 +181,7 @@ mlx5_list_register(struct mlx5_list *list, void *ctx)\n \tlist->gen_cnt++;\n \trte_rwlock_write_unlock(&list->lock);\n \tLIST_INSERT_HEAD(&list->cache[lcore_index].h, local_entry, next);\n-\t__atomic_add_fetch(&list->count, 1, __ATOMIC_ACQUIRE);\n+\t__atomic_add_fetch(&list->count, 1, __ATOMIC_RELAXED);\n \tDRV_LOG(DEBUG, \"mlx5 list %s entry %p new: %u.\", list->name,\n \t\t(void *)entry, entry->ref_cnt);\n \treturn local_entry;\n@@ -194,7 +194,7 @@ mlx5_list_unregister(struct mlx5_list *list,\n \tstruct mlx5_list_entry *gentry = entry->gentry;\n \tint lcore_idx;\n \n-\tif (__atomic_sub_fetch(&entry->ref_cnt, 1, __ATOMIC_ACQUIRE) != 0)\n+\tif (__atomic_sub_fetch(&entry->ref_cnt, 1, __ATOMIC_RELAXED) != 0)\n \t\treturn 1;\n \tlcore_idx = rte_lcore_index(rte_lcore_id());\n \tMLX5_ASSERT(lcore_idx < RTE_MAX_LCORE);\n@@ -207,14 +207,14 @@ mlx5_list_unregister(struct mlx5_list *list,\n \t} else {\n \t\treturn 0;\n \t}\n-\tif (__atomic_sub_fetch(&gentry->ref_cnt, 1, __ATOMIC_ACQUIRE) != 0)\n+\tif (__atomic_sub_fetch(&gentry->ref_cnt, 1, __ATOMIC_RELAXED) != 0)\n \t\treturn 1;\n \trte_rwlock_write_lock(&list->lock);\n \tif (likely(gentry->ref_cnt == 0)) {\n \t\tLIST_REMOVE(gentry, next);\n \t\trte_rwlock_write_unlock(&list->lock);\n \t\tlist->cb_remove(list, gentry);\n-\t\t__atomic_sub_fetch(&list->count, 1, __ATOMIC_ACQUIRE);\n+\t\t__atomic_sub_fetch(&list->count, 1, __ATOMIC_RELAXED);\n \t\tDRV_LOG(DEBUG, \"mlx5 list %s entry %p removed.\",\n \t\t\tlist->name, (void *)gentry);\n \t\treturn 0;\n", "prefixes": [ "v5", "11/26" ] }