Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95458/?format=api
http://patches.dpdk.org/api/patches/95458/?format=api", "web_url": "http://patches.dpdk.org/project/dts/patch/20210707152333.19914-1-qinx.sun@intel.com/", "project": { "id": 3, "url": "http://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20210707152333.19914-1-qinx.sun@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20210707152333.19914-1-qinx.sun@intel.com", "date": "2021-07-07T15:23:33", "name": "[V1] tests/cvl_advanced_rss: remove test steps behind the destroy rule", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "74dff333750139fb521ca1e1f3ef39c76e1cca45", "submitter": { "id": 1956, "url": "http://patches.dpdk.org/api/people/1956/?format=api", "name": "Sun, QinX", "email": "qinx.sun@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dts/patch/20210707152333.19914-1-qinx.sun@intel.com/mbox/", "series": [ { "id": 17685, "url": "http://patches.dpdk.org/api/series/17685/?format=api", "web_url": "http://patches.dpdk.org/project/dts/list/?series=17685", "date": "2021-07-07T15:23:33", "name": "[V1] tests/cvl_advanced_rss: remove test steps behind the destroy rule", "version": 1, "mbox": "http://patches.dpdk.org/series/17685/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/95458/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/95458/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 194A4A0C48;\n\tWed, 7 Jul 2021 08:49:28 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E03CA4130B;\n\tWed, 7 Jul 2021 08:49:27 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id A54FD406FF\n for <dts@dpdk.org>; Wed, 7 Jul 2021 08:49:26 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Jul 2021 23:49:25 -0700", "from unknown (HELO cvl_tetser_105.icx.intel.com) ([10.240.183.105])\n by fmsmga003-auth.fm.intel.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 23:49:24 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10037\"; a=\"196415983\"", "E=Sophos;i=\"5.83,331,1616482800\"; d=\"scan'208\";a=\"196415983\"", "E=Sophos;i=\"5.83,331,1616482800\"; d=\"scan'208\";a=\"486701841\"" ], "From": "Qin Sun <qinx.sun@intel.com>", "To": "dts@dpdk.org", "Cc": "Qin Sun <qinx.sun@intel.com>", "Date": "Wed, 7 Jul 2021 15:23:33 +0000", "Message-Id": "<20210707152333.19914-1-qinx.sun@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dts] [PATCH V1] tests/cvl_advanced_rss: remove test steps behind\n the destroy rule", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "content": "As dpdk cannot guarantee the operation after destroying the rule,\nso remove the test steps behind the destroy rule step\n\nSigned-off-by: Qin Sun <qinx.sun@intel.com>\n---\n tests/TestSuite_cvl_advanced_rss.py | 23 -----------------------\n tests/TestSuite_cvl_advanced_rss_pppoe.py | 3 ---\n 2 files changed, 26 deletions(-)", "diff": "diff --git a/tests/TestSuite_cvl_advanced_rss.py b/tests/TestSuite_cvl_advanced_rss.py\nindex 1534eb8d..da756ac1 100644\n--- a/tests/TestSuite_cvl_advanced_rss.py\n+++ b/tests/TestSuite_cvl_advanced_rss.py\n@@ -6365,13 +6365,6 @@ class AdvancedRSSTest(TestCase):\n self.rssprocess.handle_tests(tests, 0)\n self.rssprocess.destroy_rule(port_id=0, rule_id=rule_id_1)\n self.rssprocess.check_rule(port_id=0)\n- tests = [\n- {\n- 'send_packet': 'Ether(dst=\"00:11:22:33:44:55\")/IP(src=\"192.168.0.3\",dst=\"192.168.0.5\")/Raw(\"x\"*480)',\n- 'action': {'check_no_hash': 'ipv4-pay'},\n- },\n- ]\n- self.rssprocess.handle_tests(tests, 0)\n self.rssprocess.destroy_rule(port_id=0, rule_id=rule_id_0)\n \n # Subcase 3: two rules, scope smaller created first, and the larger one created later\n@@ -6411,15 +6404,7 @@ class AdvancedRSSTest(TestCase):\n ]\n self.rssprocess.handle_tests(tests, 0)\n self.rssprocess.destroy_rule(port_id=0, rule_id=rule_id_1)\n- self.rssprocess.handle_tests(tests_3, 0)\n self.rssprocess.destroy_rule(port_id=0, rule_id=rule_id_0)\n- tests = [\n- {\n- 'send_packet': 'Ether(dst=\"00:11:22:33:44:55\")/IP(src=\"192.168.0.3\",dst=\"192.168.0.5\")/UDP(sport=23, dport=45)/Raw(\"x\"*480)',\n- 'action': {'check_no_hash': 'ipv4-udp-pay'},\n- },\n- ]\n- self.rssprocess.handle_tests(tests, 0)\n \n # Subcase 4: two rules, scope larger created first, and the smaller one created later\n self.logger.info('===================Test sub case: multirules subcase 4 ================')\n@@ -6458,15 +6443,7 @@ class AdvancedRSSTest(TestCase):\n ]\n self.rssprocess.handle_tests(tests, 0)\n self.rssprocess.destroy_rule(port_id=0, rule_id=rule_id_1)\n- self.rssprocess.handle_tests(tests_4, 0)\n self.rssprocess.destroy_rule(port_id=0, rule_id=rule_id_0)\n- tests = [\n- {\n- 'send_packet': 'Ether(dst=\"00:11:22:33:44:55\")/IP(src=\"192.168.0.3\",dst=\"192.168.0.5\")/UDP(sport=23, dport=45)/Raw(\"x\"*480)',\n- 'action': {'check_no_hash': 'ipv4-udp-pay'},\n- },\n- ]\n- self.rssprocess.handle_tests(tests, 0)\n self.verify(not self.rssprocess.error_msgs, 'some subcases failed')\n \n def tear_down(self):\ndiff --git a/tests/TestSuite_cvl_advanced_rss_pppoe.py b/tests/TestSuite_cvl_advanced_rss_pppoe.py\nindex 0529165a..2d3e226e 100644\n--- a/tests/TestSuite_cvl_advanced_rss_pppoe.py\n+++ b/tests/TestSuite_cvl_advanced_rss_pppoe.py\n@@ -4710,12 +4710,9 @@ class Advanced_rss_pppoe(TestCase):\n # destory rule 1\n self.rsspro.destroy_rule(rule_id=1)\n self.rsspro.check_rule(rule_list=['1'], stats=False)\n- pkt_list[1], pkt_list[2] = pkt_list[2], pkt_list[1]\n- self._send_pkt_action(pkt_list, action_list=action_list1)\n # destory rule 0\n self.rsspro.destroy_rule(rule_id=0)\n self.rsspro.check_rule(rule_list=['0'], stats=False)\n- self._send_pkt_action([pkt_list[0]], action_list=action_list2)\n \n def test_two_rules_smaller_first_larger_later(self, ):\n \"\"\"\n", "prefixes": [ "V1" ] }{ "id": 95458, "url": "