Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95243/?format=api
{ "id": 95243, "url": "http://patches.dpdk.org/api/patches/95243/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1625306220-1268-1-git-send-email-liweifeng96@126.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1625306220-1268-1-git-send-email-liweifeng96@126.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1625306220-1268-1-git-send-email-liweifeng96@126.com", "date": "2021-07-03T09:57:00", "name": "net/bnxt: fix nested lock at bond mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9d287cdb715ef135ef51d27f5170330e1f9143df", "submitter": { "id": 1800, "url": "http://patches.dpdk.org/api/people/1800/?format=api", "name": "Weifeng Li", "email": "liweifeng96@126.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1625306220-1268-1-git-send-email-liweifeng96@126.com/mbox/", "series": [ { "id": 17610, "url": "http://patches.dpdk.org/api/series/17610/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17610", "date": "2021-07-03T09:57:00", "name": "net/bnxt: fix nested lock at bond mode", "version": 1, "mbox": "http://patches.dpdk.org/series/17610/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/95243/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/95243/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AA0E4A0A0C;\n\tSat, 3 Jul 2021 11:57:05 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2A4914014E;\n\tSat, 3 Jul 2021 11:57:05 +0200 (CEST)", "from localhost.localdomain (unknown [36.28.25.58])\n by mails.dpdk.org (Postfix) with ESMTP id DAE5F4003E;\n Sat, 3 Jul 2021 11:57:03 +0200 (CEST)", "by localhost.localdomain (Postfix, from userid 0)\n id 27DCC534CA6; Sat, 3 Jul 2021 05:57:02 -0400 (EDT)" ], "From": "Weifeng Li <liweifeng96@126.com>", "To": "ajit.khaparde@broadcom.com,\n\tsomnath.kotur@broadcom.com", "Cc": "dev@dpdk.org,\n\tliweifeng96@126.com,\n\tstable@dpdk.org", "Date": "Sat, 3 Jul 2021 05:57:00 -0400", "Message-Id": "<1625306220-1268-1-git-send-email-liweifeng96@126.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH] net/bnxt: fix nested lock at bond mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Bnxt regist lsc callback (bond_ethdev_lsc_event_callback) when\nworking at bond mode. This callback will dead lock when lsc\ninterrupt triggerred.\n\nlsc interrupt ->\nbnxt_handle_async_event ->\nbnxt_link_update_op ->\nbond_ethdev_lsc_event_callback (lsc_lock) ->\nbnxt_link_update_op ->\nbond_ethdev_lsc_event_callback (lsc_lock dead lock)\n\nFixes: c2faa1d1969e (\"net/bnxt: add support for LSC interrupt event\")\nCc: stable@dpdk.org\n\nSigned-off-by: Weifeng Li <liweifeng96@126.com>\n---\n drivers/net/bnxt/bnxt_cpr.c | 2 ++\n drivers/net/bnxt/bnxt_ethdev.c | 5 -----\n 2 files changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex 2c7fd78..f4c9c72 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -111,6 +111,8 @@ void bnxt_handle_async_event(struct bnxt *bp,\n \tcase HWRM_ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE:\n \t\t/* FALLTHROUGH */\n \t\tbnxt_link_update_op(bp->eth_dev, 0);\n+\t\trte_eth_dev_callback_process(bp->eth_dev,\n+\t\t\tRTE_ETH_EVENT_INTR_LSC, NULL);\n \t\tbreak;\n \tcase HWRM_ASYNC_EVENT_CMPL_EVENT_ID_PF_DRVR_UNLOAD:\n \t\tPMD_DRV_LOG(INFO, \"Async event: PF driver unloaded\\n\");\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 495c6cd..619b7b8 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1844,11 +1844,6 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete)\n \tif (new.link_status != eth_dev->data->dev_link.link_status ||\n \t new.link_speed != eth_dev->data->dev_link.link_speed) {\n \t\trte_eth_linkstatus_set(eth_dev, &new);\n-\n-\t\trte_eth_dev_callback_process(eth_dev,\n-\t\t\t\t\t RTE_ETH_EVENT_INTR_LSC,\n-\t\t\t\t\t NULL);\n-\n \t\tbnxt_print_link_info(eth_dev);\n \t}\n \n", "prefixes": [] }