Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95212/?format=api
{ "id": 95212, "url": "http://patches.dpdk.org/api/patches/95212/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1625222196-215-1-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1625222196-215-1-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1625222196-215-1-git-send-email-anoobj@marvell.com", "date": "2021-07-02T10:36:35", "name": "[1/2] crypto/octeontx2: reset feature flags during config", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f1ec275136583e0a948b73b48b3f6e486b9abdd7", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1625222196-215-1-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 17595, "url": "http://patches.dpdk.org/api/series/17595/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17595", "date": "2021-07-02T10:36:35", "name": "[1/2] crypto/octeontx2: reset feature flags during config", "version": 1, "mbox": "http://patches.dpdk.org/series/17595/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/95212/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/95212/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EA603A0A0C;\n\tFri, 2 Jul 2021 12:37:01 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6899C41353;\n\tFri, 2 Jul 2021 12:37:01 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 1C51340686\n for <dev@dpdk.org>; Fri, 2 Jul 2021 12:36:59 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 162AVgPU021408 for <dev@dpdk.org>; Fri, 2 Jul 2021 03:36:58 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 39hq9e235w-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 02 Jul 2021 03:36:56 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Fri, 2 Jul 2021 03:36:53 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Fri, 2 Jul 2021 03:36:53 -0700", "from HY-LT1002.marvell.com (unknown [10.193.70.1])\n by maili.marvell.com (Postfix) with ESMTP id 22D215B6937;\n Fri, 2 Jul 2021 03:36:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=7Wyzhhf3bmZMk6KRzarXU4qQAE+e0XicXyrATNbJXhM=;\n b=Nn/i7IK0QXssKXyZgVptSxewVeiY3Pu437TPv99TjHA78QXTiq21NNkIAkhoctrZHQNf\n a5tYkcdaCjFoh992ERuAU1gt+PQnABL9WhRZXVuBbRR9DhehiivQCbHosYCt9L7VmOrZ\n CCZR3f4wuQpa+VcOYstMlXRemSkB/NyfWUt5H+VLLRo9SLa/92DQUPENBDZvDtXSc6Jp\n yJNK0fKh4kgUsxXF+Q6pLPE83lYIWLcDSa3TpfBF/vOGixF91mDSnYP7S41lQdHYuy1P\n kY19mApe3Sh5wMHNGqZ5PVrBXzJk1Or+VhwXTCqTGbsHu6InnZSplbvVSWchoQFNdW6J pQ==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Jerin Jacob <jerinj@marvell.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Ankur Dwivedi <adwivedi@marvell.com>,\n Tejasree Kondoj <ktejasree@marvell.com>, <dev@dpdk.org>", "Date": "Fri, 2 Jul 2021 16:06:35 +0530", "Message-ID": "<1625222196-215-1-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "ysydxBC--9YL1nxkHeuWiVH_N2Rzr-Pb", "X-Proofpoint-GUID": "ysydxBC--9YL1nxkHeuWiVH_N2Rzr-Pb", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790\n definitions=2021-07-02_01:2021-07-02,\n 2021-07-02 signatures=0", "Subject": "[dpdk-dev] [PATCH 1/2] crypto/octeontx2: reset feature flags during\n config", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Feature flags in dev would be updated during config. On reconfigure, the\nfield need to be set again to original value.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\n drivers/crypto/octeontx2/otx2_cryptodev.c | 30 ++++++++++++++++-----------\n drivers/crypto/octeontx2/otx2_cryptodev.h | 1 +\n drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 4 ++--\n 3 files changed, 21 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c b/drivers/crypto/octeontx2/otx2_cryptodev.c\nindex d4e5ca0..75fb4f9 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev.c\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev.c\n@@ -37,6 +37,23 @@ static struct rte_pci_id pci_id_cpt_table[] = {\n \t},\n };\n \n+uint64_t\n+otx2_cpt_default_ff_get(void)\n+{\n+\treturn RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO |\n+\t RTE_CRYPTODEV_FF_HW_ACCELERATED |\n+\t RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |\n+\t RTE_CRYPTODEV_FF_IN_PLACE_SGL |\n+\t RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT |\n+\t RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |\n+\t RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT |\n+\t RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO |\n+\t RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT |\n+\t RTE_CRYPTODEV_FF_SYM_SESSIONLESS |\n+\t RTE_CRYPTODEV_FF_SECURITY |\n+\t RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED;\n+}\n+\n static int\n otx2_cpt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\t struct rte_pci_device *pci_dev)\n@@ -113,18 +130,7 @@ otx2_cpt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tif (ret)\n \t\tgoto otx2_dev_fini;\n \n-\tdev->feature_flags = RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO |\n-\t\t\t RTE_CRYPTODEV_FF_HW_ACCELERATED |\n-\t\t\t RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |\n-\t\t\t RTE_CRYPTODEV_FF_IN_PLACE_SGL |\n-\t\t\t RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT |\n-\t\t\t RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |\n-\t\t\t RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT |\n-\t\t\t RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO |\n-\t\t\t RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT |\n-\t\t\t RTE_CRYPTODEV_FF_SYM_SESSIONLESS |\n-\t\t\t RTE_CRYPTODEV_FF_SECURITY |\n-\t\t\t RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED;\n+\tdev->feature_flags = otx2_cpt_default_ff_get();\n \n \tif (rte_eal_process_type() == RTE_PROC_SECONDARY)\n \t\totx2_cpt_set_enqdeq_fns(dev);\ndiff --git a/drivers/crypto/octeontx2/otx2_cryptodev.h b/drivers/crypto/octeontx2/otx2_cryptodev.h\nindex 7e8c5de..15ecfe4 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev.h\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev.h\n@@ -57,6 +57,7 @@ extern int otx2_cpt_logtype;\n */\n extern uint8_t otx2_cryptodev_driver_id;\n \n+uint64_t otx2_cpt_default_ff_get(void);\n void otx2_cpt_set_enqdeq_fns(struct rte_cryptodev *dev);\n \n #endif /* _OTX2_CRYPTODEV_H_ */\ndiff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\nindex 12a2747..bb73a16 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\n@@ -1115,7 +1115,7 @@ otx2_cpt_dev_config(struct rte_cryptodev *dev,\n \t\treturn -EINVAL;\n \t}\n \n-\tdev->feature_flags &= ~conf->ff_disable;\n+\tdev->feature_flags = otx2_cpt_default_ff_get() & ~conf->ff_disable;\n \n \tif (dev->feature_flags & RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO) {\n \t\t/* Initialize shared FPM table */\n@@ -1227,7 +1227,7 @@ otx2_cpt_dev_info_get(struct rte_cryptodev *dev,\n \n \tif (info != NULL) {\n \t\tinfo->max_nb_queue_pairs = vf->max_queues;\n-\t\tinfo->feature_flags = dev->feature_flags;\n+\t\tinfo->feature_flags = otx2_cpt_default_ff_get();\n \t\tinfo->capabilities = otx2_cpt_capabilities_get();\n \t\tinfo->sym.max_nb_sessions = 0;\n \t\tinfo->driver_id = otx2_cryptodev_driver_id;\n", "prefixes": [ "1/2" ] }