Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95208/?format=api
{ "id": 95208, "url": "http://patches.dpdk.org/api/patches/95208/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210702091446.24635-2-shunh@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210702091446.24635-2-shunh@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210702091446.24635-2-shunh@nvidia.com", "date": "2021-07-02T09:14:43", "name": "[v1,1/4] net/mlx5: use meter profile lookup table", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cd9a4af56f56239992fe3c1b0cc48a26cc0f992a", "submitter": { "id": 2212, "url": "http://patches.dpdk.org/api/people/2212/?format=api", "name": "Shun Hao", "email": "shunh@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210702091446.24635-2-shunh@nvidia.com/mbox/", "series": [ { "id": 17594, "url": "http://patches.dpdk.org/api/series/17594/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17594", "date": "2021-07-02T09:14:42", "name": "ASO meter sharing support", "version": 1, "mbox": "http://patches.dpdk.org/series/17594/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/95208/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/95208/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 472BCA0A0C;\n\tFri, 2 Jul 2021 11:15:14 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2EB0241368;\n\tFri, 2 Jul 2021 11:15:14 +0200 (CEST)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2050.outbound.protection.outlook.com [40.107.237.50])\n by mails.dpdk.org (Postfix) with ESMTP id 565634014E\n for <dev@dpdk.org>; Fri, 2 Jul 2021 11:15:13 +0200 (CEST)", "from DM5PR21CA0004.namprd21.prod.outlook.com (2603:10b6:3:ac::14) by\n MN2PR12MB2958.namprd12.prod.outlook.com (2603:10b6:208:aa::29) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.4264.19; Fri, 2 Jul 2021 09:15:11 +0000", "from DM6NAM11FT034.eop-nam11.prod.protection.outlook.com\n (2603:10b6:3:ac:cafe::5f) by DM5PR21CA0004.outlook.office365.com\n (2603:10b6:3:ac::14) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.9 via Frontend\n Transport; Fri, 2 Jul 2021 09:15:11 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT034.mail.protection.outlook.com (10.13.173.47) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4287.22 via Frontend Transport; Fri, 2 Jul 2021 09:15:11 +0000", "from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 2 Jul\n 2021 09:15:08 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Ugq7mOk4OrmvuanSdVbOZdcm3uaC0vJz82G/vhwlb2U/vFkud7czAZDtfb/O04ZOHd5Yax5VGKrM2ciJzd+E0AxkTQbuXr9p4UNTwXk3FMFNtFXpLjuKGVQ0m7jrD9frBP4mpl1CFkXzfHn2goNOYLjrnQwUVIt2AJfEdUyqRi8xpdyq5yfqdEKfSc+bU/igyWzrAQ5luWVR05y3T3uWV7m/oiyhN1qjhNeTEu0ToNxAGM64adrXZ0dzYSG692jRi7Q8PHkDm9NEdm4sKDcgRYPQ1ILl0+inUnQp7PmICTzUeVU2uj4BBDEgTH2C6JEx1tzYPk5tg6ROBq6QInDjcQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=0nwto0kKj3JA6q6Xmuu8eSVLgXKIh26HXta5iyfsZyA=;\n b=ESICtzJcHqR+DSNYPv6goJeOU4N5hEBTsPGZe3Z5tnbECzYCImGNytJzPJcZb6dueN35qjTqHxPE+voMzbOa/Jc0GZ49ySS7UG5NPTaDsfLz8hYEzfgioO/+JNQGMTHc/tR3SY9KXDhiu+u2Zn4t6A7wznkG7nf96RtH4lsD/2XJ4JCIPKHORhPybzSB4UrDqybBcdwKtNvuKb9yI5IWP0sJZ9Ox3QZEneQpOiSJ78Y5EzeVHRjaU/qZhA+ZF7XKiWUhGgdZYGi+NdVjRVGYwK7BGZiQMPGgr2+jsGcumw9xs5krQ2yvXLlj4wO7vyPJyAw3/UudOuEQH7BMYjWpMQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=0nwto0kKj3JA6q6Xmuu8eSVLgXKIh26HXta5iyfsZyA=;\n b=T+Ub+hegNhf9pLh52aDU515fDYZR9TX8Hl1pxgssf0dzKh0r9U4MtzA0KpL+3EGCIDcoifgr3wZSPNYoIcEg8MfAH5bcH7/G21wQWp1bvDa/2bbA6yXFNFHLjR7B45YNntUHNgafOxadmDJOtcp5CUILPfJ7dXkynVO53wO4UaPQ0VgNvNUwSuRppSTudghEYpcRbgi8UZIxzGZ6EIMJ6I77F/DJEo+7Ul+7Z+t1bMC25VEGa7YZJlBo0QPkT8eYRxvaTakZTrru8tAOFj6SNoR7bYzAq0J3seGENJGK7ig6RMSsxJNs9fhq4gkzInReqXw+FM3R9vOmNdCu0JE0gA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed)\n header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Shun Hao <shunh@nvidia.com>", "To": "<orika@nvidia.com>, <viacheslavo@nvidia.com>, <matan@nvidia.com>,\n <shahafs@nvidia.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <rasland@nvidia.com>,\n <roniba@nvidia.com>", "Date": "Fri, 2 Jul 2021 12:14:43 +0300", "Message-ID": "<20210702091446.24635-2-shunh@nvidia.com>", "X-Mailer": "git-send-email 2.20.0", "In-Reply-To": "<20210702091446.24635-1-shunh@nvidia.com>", "References": "<20210702091446.24635-1-shunh@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL111.nvidia.com (172.20.187.18) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "493b4073-b897-4a1c-260f-08d93d39e51f", "X-MS-TrafficTypeDiagnostic": "MN2PR12MB2958:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <MN2PR12MB29589FC103DFB747632CAAB8C01F9@MN2PR12MB2958.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:33;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 2ZPq+TO3pVKdODTwAQ6Ez/quAPWq6GD1zXRwcj3Eet/rA+faBrYxYyxCUNn8cO7n0TXZSBOTkVHuc+AXssOwBJonHGTmO1ZsuAQZBz8KKdHJT2/AFPFuQCbNo7Eh6oSWy7fvdQJYfBEVBoUN8kj9N7RCPqrvnbis4+ultjdRG9ZfUDk14FCTOVhoZffzz0NTUb8rYSabtkegKs5K0bSt1L0zjBoWFNeUMkhH4KDmribnxADmA47pXMKiaAqIreEoAVEczHIS3bXYdWs9J6lum4kLQs0XpGcibxjLFhA9Ita3nwQrur2oBDSe3vKZXPOUXjlTrSd0c/vLzoDl2Xm3zcX/+WGWXpphyeOw6JN9aoRbzQdgOhWBUV6q5DndBUYNRPY2ADHdro7flf1ktWxfUkq5C37M82SSUGdPKKwjoKlnA7DxCyFhRMUdfPhbRgfO6zeBB9jhTmfjkvoDJwV7JaupETY/nmXeTXFTkVRAvDjD8kxPPgwAk0RYn0MJrKoBTOEqe6kGp9C4b1zYpwIxPPw3EQPrf2mqkikX46l9KXMiC8r8fKvkSsJCGSD5rQPAuBOI0JSHyYfuFhTnw3jgK6uNOvLh5v1L92OXHUnwVBQ6X68aWNDnFrz52SU4F7hvlBLIDBvZSbWGmc03CuroFtRCNAuNg/g7WbtOwNCaskUS5GMp855qdIG5uHsUS9SuHnCb0Wul7nV4NjQTzZj8TA==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(396003)(136003)(346002)(376002)(39860400002)(46966006)(36840700001)(36906005)(316002)(6636002)(336012)(8936002)(54906003)(110136005)(426003)(70206006)(82740400003)(36756003)(107886003)(478600001)(6286002)(2906002)(26005)(4326008)(70586007)(86362001)(83380400001)(6666004)(47076005)(356005)(16526019)(7636003)(1076003)(55016002)(186003)(82310400003)(5660300002)(8676002)(7696005)(36860700001)(2616005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "02 Jul 2021 09:15:11.4101 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 493b4073-b897-4a1c-260f-08d93d39e51f", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT034.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR12MB2958", "Subject": "[dpdk-dev] [PATCH v1 1/4] net/mlx5: use meter profile lookup table", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently a list is used to save all meter profile ids, which is\nnot efficient when looking up profile from huge mount of profiles.\n\nThis changes to use a l3 table instead to save meter profile ids,\nso as to improve the lookup performance.\n\nSigned-off-by: Shun Hao <shunh@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/linux/mlx5_os.c | 6 +++-\n drivers/net/mlx5/mlx5.h | 2 +-\n drivers/net/mlx5/mlx5_flow_meter.c | 53 ++++++++++++++++++++----------\n drivers/net/mlx5/windows/mlx5_os.c | 6 +++-\n 4 files changed, 47 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex 92b3009786..b3f9e392ab 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -1570,7 +1570,9 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \tpriv->ctrl_flows = 0;\n \trte_spinlock_init(&priv->flow_list_lock);\n \tTAILQ_INIT(&priv->flow_meters);\n-\tTAILQ_INIT(&priv->flow_meter_profiles);\n+\tpriv->mtr_profile_tbl = mlx5_l3t_create(MLX5_L3T_TYPE_PTR);\n+\tif (!priv->mtr_profile_tbl)\n+\t\tgoto error;\n \t/* Hint libmlx5 to use PMD allocator for data plane resources */\n \tmlx5_glue->dv_set_context_attr(sh->ctx,\n \t\t\tMLX5DV_CTX_ATTR_BUF_ALLOCATORS,\n@@ -1713,6 +1715,8 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \t\t\tmlx5_vlan_vmwa_exit(priv->vmwa_context);\n \t\tif (eth_dev && priv->drop_queue.hrxq)\n \t\t\tmlx5_drop_action_destroy(eth_dev);\n+\t\tif (priv->mtr_profile_tbl)\n+\t\t\tmlx5_l3t_destroy(priv->mtr_profile_tbl);\n \t\tif (own_domain_id)\n \t\t\tclaim_zero(rte_eth_switch_domain_free(priv->domain_id));\n \t\tmlx5_cache_list_destroy(&priv->hrxqs);\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 1b2dc8f815..0226327bc3 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -1373,8 +1373,8 @@ struct mlx5_priv {\n \t/* Hash table of Rx metadata register copy table. */\n \tuint8_t mtr_sfx_reg; /* Meter prefix-suffix flow match REG_C. */\n \tuint8_t mtr_color_reg; /* Meter color match REG_C. */\n-\tstruct mlx5_mtr_profiles flow_meter_profiles; /* MTR profile list. */\n \tstruct mlx5_legacy_flow_meters flow_meters; /* MTR list. */\n+\tstruct mlx5_l3t_tbl *mtr_profile_tbl; /* Meter index lookup table. */\n \tstruct mlx5_l3t_tbl *mtr_idx_tbl; /* Meter index lookup table. */\n \tuint8_t skip_default_rss_reta; /* Skip configuration of default reta. */\n \tuint8_t fdb_def_rule; /* Whether fdb jump to table 1 is configured. */\ndiff --git a/drivers/net/mlx5/mlx5_flow_meter.c b/drivers/net/mlx5/mlx5_flow_meter.c\nindex d7ce5cd2f6..87c5782956 100644\n--- a/drivers/net/mlx5/mlx5_flow_meter.c\n+++ b/drivers/net/mlx5/mlx5_flow_meter.c\n@@ -91,13 +91,20 @@ mlx5_flow_meter_action_create(struct mlx5_priv *priv,\n static struct mlx5_flow_meter_profile *\n mlx5_flow_meter_profile_find(struct mlx5_priv *priv, uint32_t meter_profile_id)\n {\n-\tstruct mlx5_mtr_profiles *fmps = &priv->flow_meter_profiles;\n \tstruct mlx5_flow_meter_profile *fmp;\n+\tunion mlx5_l3t_data data;\n+\tint32_t ret;\n \n-\tTAILQ_FOREACH(fmp, fmps, next)\n-\t\tif (meter_profile_id == fmp->id)\n-\t\t\treturn fmp;\n-\treturn NULL;\n+\tif (mlx5_l3t_get_entry(priv->mtr_profile_tbl,\n+\t\t\t meter_profile_id, &data) || !data.ptr)\n+\t\treturn NULL;\n+\tfmp = data.ptr;\n+\t/* Remove reference taken by the mlx5_l3t_get_entry. */\n+\tret = mlx5_l3t_clear_entry(priv->mtr_profile_tbl,\n+\t\t\t\t meter_profile_id);\n+\tif (!ret || ret == -1)\n+\t\treturn NULL;\n+\treturn fmp;\n }\n \n /**\n@@ -399,8 +406,8 @@ mlx5_flow_meter_profile_add(struct rte_eth_dev *dev,\n \t\t struct rte_mtr_error *error)\n {\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n-\tstruct mlx5_mtr_profiles *fmps = &priv->flow_meter_profiles;\n \tstruct mlx5_flow_meter_profile *fmp;\n+\tunion mlx5_l3t_data data;\n \tint ret;\n \n \tif (!priv->mtr_en)\n@@ -427,8 +434,13 @@ mlx5_flow_meter_profile_add(struct rte_eth_dev *dev,\n \tret = mlx5_flow_meter_param_fill(fmp, priv, error);\n \tif (ret)\n \t\tgoto error;\n-\t/* Add to list. */\n-\tTAILQ_INSERT_TAIL(fmps, fmp, next);\n+\tdata.ptr = fmp;\n+\tret = mlx5_l3t_set_entry(priv->mtr_profile_tbl,\n+\t\t\t\t meter_profile_id, &data);\n+\tif (ret)\n+\t\treturn -rte_mtr_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_MTR_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL, \"Meter profile insert fail.\");\n \treturn 0;\n error:\n \tmlx5_free(fmp);\n@@ -472,8 +484,10 @@ mlx5_flow_meter_profile_delete(struct rte_eth_dev *dev,\n \t\treturn -rte_mtr_error_set(error, EBUSY,\n \t\t\t\t\t RTE_MTR_ERROR_TYPE_METER_PROFILE_ID,\n \t\t\t\t\t NULL, \"Meter profile is in use.\");\n-\t/* Remove from list. */\n-\tTAILQ_REMOVE(&priv->flow_meter_profiles, fmp, next);\n+\tif (mlx5_l3t_clear_entry(priv->mtr_profile_tbl, meter_profile_id))\n+\t\treturn -rte_mtr_error_set(error, EBUSY,\n+\t\t\t\t\t RTE_MTR_ERROR_TYPE_METER_PROFILE_ID,\n+\t\t\t\t\t NULL, \"Meter profile remove fail.\");\n \tmlx5_free(fmp);\n \treturn 0;\n }\n@@ -1859,7 +1873,6 @@ mlx5_flow_meter_flush(struct rte_eth_dev *dev, struct rte_mtr_error *error)\n {\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tstruct mlx5_legacy_flow_meters *fms = &priv->flow_meters;\n-\tstruct mlx5_mtr_profiles *fmps = &priv->flow_meter_profiles;\n \tstruct mlx5_flow_meter_profile *fmp;\n \tstruct mlx5_legacy_flow_meter *legacy_fm;\n \tstruct mlx5_flow_meter_info *fm;\n@@ -1921,12 +1934,18 @@ mlx5_flow_meter_flush(struct rte_eth_dev *dev, struct rte_mtr_error *error)\n \t\tmlx5_l3t_destroy(priv->sh->mtrmng->policy_idx_tbl);\n \t\tpriv->sh->mtrmng->policy_idx_tbl = NULL;\n \t}\n-\tTAILQ_FOREACH_SAFE(fmp, fmps, next, tmp) {\n-\t\t/* Check unused. */\n-\t\tMLX5_ASSERT(!fmp->ref_cnt);\n-\t\t/* Remove from list. */\n-\t\tTAILQ_REMOVE(&priv->flow_meter_profiles, fmp, next);\n-\t\tmlx5_free(fmp);\n+\tif (priv->mtr_profile_tbl) {\n+\t\tMLX5_L3T_FOREACH(priv->mtr_profile_tbl, i, entry) {\n+\t\t\tfmp = entry;\n+\t\t\tif (mlx5_flow_meter_profile_delete(dev, fmp->id,\n+\t\t\t\t\t\t\t error))\n+\t\t\t\treturn -rte_mtr_error_set(error, EINVAL,\n+\t\t\t\t\tRTE_MTR_ERROR_TYPE_METER_POLICY_ID,\n+\t\t\t\t\t\tNULL, \"Fail to destroy \"\n+\t\t\t\t\t\t\"meter profile.\");\n+\t\t}\n+\t\tmlx5_l3t_destroy(priv->mtr_profile_tbl);\n+\t\tpriv->mtr_profile_tbl = NULL;\n \t}\n \t/* Delete default policy table. */\n \tmlx5_flow_destroy_def_policy(dev);\ndiff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c\nindex 3fe3f55f49..e30b682822 100644\n--- a/drivers/net/mlx5/windows/mlx5_os.c\n+++ b/drivers/net/mlx5/windows/mlx5_os.c\n@@ -566,7 +566,9 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \tpriv->flows = 0;\n \tpriv->ctrl_flows = 0;\n \tTAILQ_INIT(&priv->flow_meters);\n-\tTAILQ_INIT(&priv->flow_meter_profiles);\n+\tpriv->mtr_profile_tbl = mlx5_l3t_create(MLX5_L3T_TYPE_PTR);\n+\tif (!priv->mtr_profile_tbl)\n+\t\tgoto error;\n \t/* Bring Ethernet device up. */\n \tDRV_LOG(DEBUG, \"port %u forcing Ethernet interface up.\",\n \t\teth_dev->data->port_id);\n@@ -644,6 +646,8 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \treturn eth_dev;\n error:\n \tif (priv) {\n+\t\tif (priv->mtr_profile_tbl)\n+\t\t\tmlx5_l3t_destroy(priv->mtr_profile_tbl);\n \t\tif (own_domain_id)\n \t\t\tclaim_zero(rte_eth_switch_domain_free(priv->domain_id));\n \t\tmlx5_free(priv);\n", "prefixes": [ "v1", "1/4" ] }