Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95173/?format=api
{ "id": 95173, "url": "http://patches.dpdk.org/api/patches/95173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210702061816.10454-21-suanmingm@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210702061816.10454-21-suanmingm@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210702061816.10454-21-suanmingm@nvidia.com", "date": "2021-07-02T06:18:14", "name": "[v3,20/22] net/mlx5: support index pool none local core operations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "70674b5e800437a008932f960e79c91931f7d4dc", "submitter": { "id": 1887, "url": "http://patches.dpdk.org/api/people/1887/?format=api", "name": "Suanming Mou", "email": "suanmingm@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210702061816.10454-21-suanmingm@nvidia.com/mbox/", "series": [ { "id": 17585, "url": "http://patches.dpdk.org/api/series/17585/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17585", "date": "2021-07-02T06:17:54", "name": "net/mlx5: insertion rate optimization", "version": 3, "mbox": "http://patches.dpdk.org/series/17585/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/95173/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/95173/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3B1A7A0A0C;\n\tFri, 2 Jul 2021 08:21:08 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C925C413B5;\n\tFri, 2 Jul 2021 08:19:09 +0200 (CEST)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2050.outbound.protection.outlook.com [40.107.237.50])\n by mails.dpdk.org (Postfix) with ESMTP id 66D664131F\n for <dev@dpdk.org>; Fri, 2 Jul 2021 08:19:07 +0200 (CEST)", "from BN0PR04CA0153.namprd04.prod.outlook.com (2603:10b6:408:eb::8)\n by DM6PR12MB3561.namprd12.prod.outlook.com (2603:10b6:5:3e::26) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.22; Fri, 2 Jul\n 2021 06:19:06 +0000", "from BN8NAM11FT059.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:eb:cafe::16) by BN0PR04CA0153.outlook.office365.com\n (2603:10b6:408:eb::8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend\n Transport; Fri, 2 Jul 2021 06:19:06 +0000", "from mail.nvidia.com (216.228.112.34) by\n BN8NAM11FT059.mail.protection.outlook.com (10.13.177.120) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4287.22 via Frontend Transport; Fri, 2 Jul 2021 06:19:06 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 2 Jul\n 2021 06:19:04 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=dyRXoXGqpXEAwfWTaeHaHrtSt6rD4wT+uSB3mOV+CyGCqRfmonluvGV7whx4b75qNwhHZzZQeufDlO5J+3w+ZuNIgOvibho48Xm7V93dNsmzcQki8rpo1Zp0UwBJtHObS8c/JdHfRbxlI/gWPlpZ7FdlE8fDejYXJKEDLwKhCD+wGd2TouxA2AG1xubTuoe/onswolqeElgECl50aOYHqqCrx/qlX2xzM9Y6OKBoFjo6xHraLaax45I8c3CsZJ8W9RHOnkmGd0sR9sIj1fLf/lrCorrUeXiduGbMnKw3MPazxB1odofSaRWFDAKc6O2p6f+/bCLr0G90VAkmy7iIXQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=XGXzZ+JG/VwiWi8hxkFosCFLnf9Eo1qxNqpqbKvOc+g=;\n b=gWlVPOPWI0DJESSyV6IURlYjzzJSnnTcJhaqw8avb/HLsWWPEpAnZZSJI1jaZyUuxYVAYcsWuD3cUJYS8cMrffpc6RmyJXAl2nQGxtwPhCQdq2OVbIDgfr2OtYGkyNZlJv1D/3WRHmm67oXrvaDeMBYMQLNNu8Pk3dDn0gfrQ5LtliE/pWQTU4aNHddN8HLmjGllLg0t6N3xODOc4Kw4OdUTDJp0yFiLYVQzhqPm7D3OvjZGMzxGdT5355o45FtQJ8ux1z5UR18jSabquR3eVpYSx7YjkozUbjP5CF93QNA3UWx82iwTokESONfKeAkZTxzDEoJxf9XM/xFY4Vgnbg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=XGXzZ+JG/VwiWi8hxkFosCFLnf9Eo1qxNqpqbKvOc+g=;\n b=QwrsWN4McSfhM1Aanefs1Ae7waLDGEUt4napKNvTqfmPq9oBYiYyEpht3lcNfAMvvH80j84WBkqaaEV2f8hv1ONThpfLg7wbqGABTOGg4tBMOV2M0z1kE2vuKyWLHAzJsSBSVF+ZY1+TqubEMzhtDy9Ew01k2MzvN3MqCJz9oZcCY33iIky/ReJp0hDJcsfJ9MLveiS0KtuHyyIRpvaInDtzo0BkpkbcHGVSnLaLn/qMhlSn17VyXb43gbeQsw/v20JoQQa5k74y45MMGhOlMGqIi7aKyUhugSCSai2rdhvPho21V9gPLEf3a7Xz+VRHfDKdwcd76/LfzVD6LBo0Xg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Suanming Mou <suanmingm@nvidia.com>", "To": "<viacheslavo@nvidia.com>, <matan@nvidia.com>", "CC": "<rasland@nvidia.com>, <orika@nvidia.com>, <dev@dpdk.org>", "Date": "Fri, 2 Jul 2021 09:18:14 +0300", "Message-ID": "<20210702061816.10454-21-suanmingm@nvidia.com>", "X-Mailer": "git-send-email 2.18.1", "In-Reply-To": "<20210702061816.10454-1-suanmingm@nvidia.com>", "References": "<20210527093403.1153127-1-suanmingm@nvidia.com>\n <20210702061816.10454-1-suanmingm@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL107.nvidia.com (172.20.187.13) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "2bbe6427-cfdb-4444-0489-08d93d214bb7", "X-MS-TrafficTypeDiagnostic": "DM6PR12MB3561:", "X-Microsoft-Antispam-PRVS": "\n <DM6PR12MB35611E2D865AFEE792315B87C11F9@DM6PR12MB3561.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:72;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n Q+k9wK1MN8SEhAzyYPzVMy8kjp/L0OwQP7GL7mb94pHK2rkpWi7new1omFEwlFNmselhGHycKV2WUQKyeON8n4a3AzbRc6C0xU40kMuNOpwU+Y3gIjmcjVSyKofHck8gUDpyeuuEb7DgwFTVSa6Ghu2+Xiy8GlKJeHL9gC+IYjY9QKIRrXfZsRY3Im3V7vV+G6d74kLfLPfMF/OJRZSgUnt61UFOSPUOc4Dx7EOEbuSBTxZsVpFItyyQv1piunxW3op68/KQhvPzi3LXREZ4gewKiAnZrLZbLcrBAAq0G7NAYPxm9xlZdiSECeb90oGTBJ0E7EYKwA37vaji91po5u4BSmb5Tb+CUfSxeR3lslqoLoSe/q2XZ7+mDeMT+bCHGYbkezx+8+mv4mvWOyDj5ZiFXbUxKra/u4vCeKLMUBki1W+f3RqWU4urlhMjN3nVWGuh77mOf/iiVx2cWNioKtNBcfzPBCg9SBse465PTiqLXZT0JKoKjifMQMeRjdjwh+/PXgfOFHELgoY0hVOupQAYIxRcBFR/e7vMexf8FVP08j4baLgVREoTOQqjjT+enujcqEz2CLb6qrtwqlLLhWqaGzhzxSTAD2OZoMkN8as0CRUDT8Khex6hRSU6oUk1XOZIGdSL25w2GwrOLje8853rvtEispnNFyQUwe2GnuWKPr76/Cph1mc9zMlFc+d434oVt1+U/KPLSMBB5wMPVA==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(396003)(39860400002)(346002)(376002)(136003)(46966006)(36840700001)(36756003)(83380400001)(6286002)(55016002)(2616005)(6666004)(2906002)(186003)(16526019)(7636003)(356005)(82310400003)(336012)(82740400003)(1076003)(54906003)(5660300002)(6636002)(478600001)(316002)(36860700001)(7696005)(86362001)(110136005)(70206006)(26005)(36906005)(8676002)(426003)(8936002)(70586007)(47076005)(4326008);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "02 Jul 2021 06:19:06.1187 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 2bbe6427-cfdb-4444-0489-08d93d214bb7", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT059.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB3561", "Subject": "[dpdk-dev] [PATCH v3 20/22] net/mlx5: support index pool none local\n core operations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit supports the index pool none local core operations with\nan extra cache.\n\nSigned-off-by: Suanming Mou <suanmingm@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/mlx5_utils.c | 75 +++++++++++++++++++++++++----------\n drivers/net/mlx5/mlx5_utils.h | 3 +-\n 2 files changed, 56 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c\nindex 94abe79860..c34d6d62a8 100644\n--- a/drivers/net/mlx5/mlx5_utils.c\n+++ b/drivers/net/mlx5/mlx5_utils.c\n@@ -114,6 +114,7 @@ mlx5_ipool_create(struct mlx5_indexed_pool_config *cfg)\n \t\t\tmlx5_trunk_idx_offset_get(pool, TRUNK_MAX_IDX + 1);\n \tif (!cfg->per_core_cache)\n \t\tpool->free_list = TRUNK_INVALID;\n+\trte_spinlock_init(&pool->nlcore_lock);\n \treturn pool;\n }\n \n@@ -354,20 +355,14 @@ mlx5_ipool_allocate_from_global(struct mlx5_indexed_pool *pool, int cidx)\n }\n \n static void *\n-mlx5_ipool_get_cache(struct mlx5_indexed_pool *pool, uint32_t idx)\n+_mlx5_ipool_get_cache(struct mlx5_indexed_pool *pool, int cidx, uint32_t idx)\n {\n \tstruct mlx5_indexed_trunk *trunk;\n \tstruct mlx5_indexed_cache *lc;\n \tuint32_t trunk_idx;\n \tuint32_t entry_idx;\n-\tint cidx;\n \n \tMLX5_ASSERT(idx);\n-\tcidx = rte_lcore_index(rte_lcore_id());\n-\tif (unlikely(cidx == -1)) {\n-\t\trte_errno = ENOTSUP;\n-\t\treturn NULL;\n-\t}\n \tlc = mlx5_ipool_update_global_cache(pool, cidx);\n \tidx -= 1;\n \ttrunk_idx = mlx5_trunk_idx_get(pool, idx);\n@@ -378,15 +373,27 @@ mlx5_ipool_get_cache(struct mlx5_indexed_pool *pool, uint32_t idx)\n }\n \n static void *\n-mlx5_ipool_malloc_cache(struct mlx5_indexed_pool *pool, uint32_t *idx)\n+mlx5_ipool_get_cache(struct mlx5_indexed_pool *pool, uint32_t idx)\n {\n+\tvoid *entry;\n \tint cidx;\n \n \tcidx = rte_lcore_index(rte_lcore_id());\n \tif (unlikely(cidx == -1)) {\n-\t\trte_errno = ENOTSUP;\n-\t\treturn NULL;\n+\t\tcidx = RTE_MAX_LCORE;\n+\t\trte_spinlock_lock(&pool->nlcore_lock);\n \t}\n+\tentry = _mlx5_ipool_get_cache(pool, cidx, idx);\n+\tif (unlikely(cidx == RTE_MAX_LCORE))\n+\t\trte_spinlock_unlock(&pool->nlcore_lock);\n+\treturn entry;\n+}\n+\n+\n+static void *\n+_mlx5_ipool_malloc_cache(struct mlx5_indexed_pool *pool, int cidx,\n+\t\t\t uint32_t *idx)\n+{\n \tif (unlikely(!pool->cache[cidx])) {\n \t\tpool->cache[cidx] = pool->cfg.malloc(MLX5_MEM_ZERO,\n \t\t\tsizeof(struct mlx5_ipool_per_lcore) +\n@@ -399,29 +406,40 @@ mlx5_ipool_malloc_cache(struct mlx5_indexed_pool *pool, uint32_t *idx)\n \t} else if (pool->cache[cidx]->len) {\n \t\tpool->cache[cidx]->len--;\n \t\t*idx = pool->cache[cidx]->idx[pool->cache[cidx]->len];\n-\t\treturn mlx5_ipool_get_cache(pool, *idx);\n+\t\treturn _mlx5_ipool_get_cache(pool, cidx, *idx);\n \t}\n \t/* Not enough idx in global cache. Keep fetching from global. */\n \t*idx = mlx5_ipool_allocate_from_global(pool, cidx);\n \tif (unlikely(!(*idx)))\n \t\treturn NULL;\n-\treturn mlx5_ipool_get_cache(pool, *idx);\n+\treturn _mlx5_ipool_get_cache(pool, cidx, *idx);\n }\n \n-static void\n-mlx5_ipool_free_cache(struct mlx5_indexed_pool *pool, uint32_t idx)\n+static void *\n+mlx5_ipool_malloc_cache(struct mlx5_indexed_pool *pool, uint32_t *idx)\n {\n+\tvoid *entry;\n \tint cidx;\n+\n+\tcidx = rte_lcore_index(rte_lcore_id());\n+\tif (unlikely(cidx == -1)) {\n+\t\tcidx = RTE_MAX_LCORE;\n+\t\trte_spinlock_lock(&pool->nlcore_lock);\n+\t}\n+\tentry = _mlx5_ipool_malloc_cache(pool, cidx, idx);\n+\tif (unlikely(cidx == RTE_MAX_LCORE))\n+\t\trte_spinlock_unlock(&pool->nlcore_lock);\n+\treturn entry;\n+}\n+\n+static void\n+_mlx5_ipool_free_cache(struct mlx5_indexed_pool *pool, int cidx, uint32_t idx)\n+{\n \tstruct mlx5_ipool_per_lcore *ilc;\n \tstruct mlx5_indexed_cache *gc, *olc = NULL;\n \tuint32_t reclaim_num = 0;\n \n \tMLX5_ASSERT(idx);\n-\tcidx = rte_lcore_index(rte_lcore_id());\n-\tif (unlikely(cidx == -1)) {\n-\t\trte_errno = ENOTSUP;\n-\t\treturn;\n-\t}\n \t/*\n \t * When index was allocated on core A but freed on core B. In this\n \t * case check if local cache on core B was allocated before.\n@@ -464,6 +482,21 @@ mlx5_ipool_free_cache(struct mlx5_indexed_pool *pool, uint32_t idx)\n \tpool->cache[cidx]->len++;\n }\n \n+static void\n+mlx5_ipool_free_cache(struct mlx5_indexed_pool *pool, uint32_t idx)\n+{\n+\tint cidx;\n+\n+\tcidx = rte_lcore_index(rte_lcore_id());\n+\tif (unlikely(cidx == -1)) {\n+\t\tcidx = RTE_MAX_LCORE;\n+\t\trte_spinlock_lock(&pool->nlcore_lock);\n+\t}\n+\t_mlx5_ipool_free_cache(pool, cidx, idx);\n+\tif (unlikely(cidx == RTE_MAX_LCORE))\n+\t\trte_spinlock_unlock(&pool->nlcore_lock);\n+}\n+\n void *\n mlx5_ipool_malloc(struct mlx5_indexed_pool *pool, uint32_t *idx)\n {\n@@ -643,7 +676,7 @@ mlx5_ipool_destroy(struct mlx5_indexed_pool *pool)\n \tMLX5_ASSERT(pool);\n \tmlx5_ipool_lock(pool);\n \tif (pool->cfg.per_core_cache) {\n-\t\tfor (i = 0; i < RTE_MAX_LCORE; i++) {\n+\t\tfor (i = 0; i <= RTE_MAX_LCORE; i++) {\n \t\t\t/*\n \t\t\t * Free only old global cache. Pool gc will be\n \t\t\t * freed at last.\n@@ -712,7 +745,7 @@ mlx5_ipool_flush_cache(struct mlx5_indexed_pool *pool)\n \tfor (i = 0; i < gc->len; i++)\n \t\trte_bitmap_clear(ibmp, gc->idx[i] - 1);\n \t/* Clear core cache. */\n-\tfor (i = 0; i < RTE_MAX_LCORE; i++) {\n+\tfor (i = 0; i < RTE_MAX_LCORE + 1; i++) {\n \t\tstruct mlx5_ipool_per_lcore *ilc = pool->cache[i];\n \n \t\tif (!ilc)\ndiff --git a/drivers/net/mlx5/mlx5_utils.h b/drivers/net/mlx5/mlx5_utils.h\nindex 7d9b64c877..060c52f022 100644\n--- a/drivers/net/mlx5/mlx5_utils.h\n+++ b/drivers/net/mlx5/mlx5_utils.h\n@@ -248,6 +248,7 @@ struct mlx5_ipool_per_lcore {\n struct mlx5_indexed_pool {\n \tstruct mlx5_indexed_pool_config cfg; /* Indexed pool configuration. */\n \trte_spinlock_t rsz_lock; /* Pool lock for multiple thread usage. */\n+\trte_spinlock_t nlcore_lock;\n \t/* Dim of trunk pointer array. */\n \tunion {\n \t\tstruct {\n@@ -259,7 +260,7 @@ struct mlx5_indexed_pool {\n \t\tstruct {\n \t\t\tstruct mlx5_indexed_cache *gc;\n \t\t\t/* Global cache. */\n-\t\t\tstruct mlx5_ipool_per_lcore *cache[RTE_MAX_LCORE];\n+\t\t\tstruct mlx5_ipool_per_lcore *cache[RTE_MAX_LCORE + 1];\n \t\t\t/* Local cache. */\n \t\t\tstruct rte_bitmap *ibmp;\n \t\t\tvoid *bmp_mem;\n", "prefixes": [ "v3", "20/22" ] }