Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95077/?format=api
http://patches.dpdk.org/api/patches/95077/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210630124637.2987722-1-abhinandan.gujjar@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210630124637.2987722-1-abhinandan.gujjar@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210630124637.2987722-1-abhinandan.gujjar@intel.com", "date": "2021-06-30T12:46:37", "name": "test: fix crypto_op length for sessionless case", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9ca6d2e46663fcda78152e7394ed5f4d4c502e13", "submitter": { "id": 883, "url": "http://patches.dpdk.org/api/people/883/?format=api", "name": "Gujjar, Abhinandan S", "email": "abhinandan.gujjar@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210630124637.2987722-1-abhinandan.gujjar@intel.com/mbox/", "series": [ { "id": 17550, "url": "http://patches.dpdk.org/api/series/17550/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17550", "date": "2021-06-30T12:46:37", "name": "test: fix crypto_op length for sessionless case", "version": 1, "mbox": "http://patches.dpdk.org/series/17550/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/95077/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/95077/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D4B2EA0A0F;\n\tWed, 30 Jun 2021 14:49:21 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B59134127C;\n\tWed, 30 Jun 2021 14:47:44 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 6542041277\n for <dev@dpdk.org>; Wed, 30 Jun 2021 14:47:43 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Jun 2021 05:47:38 -0700", "from unknown (HELO localhost.localdomain) ([10.190.210.97])\n by orsmga007.jf.intel.com with ESMTP; 30 Jun 2021 05:47:37 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10030\"; a=\"208160819\"", "E=Sophos;i=\"5.83,312,1616482800\"; d=\"scan'208\";a=\"208160819\"", "E=Sophos;i=\"5.83,312,1616482800\"; d=\"scan'208\";a=\"447453358\"" ], "X-ExtLoop1": "1", "From": "Abhinandan Gujjar <abhinandan.gujjar@intel.com>", "To": "dev@dpdk.org,\n\tjerinj@marvell.com", "Cc": "gakhil@marvell.com,\n\tabhinandan.gujjar@intel.com,\n\tciara.power@intel.com", "Date": "Wed, 30 Jun 2021 18:16:37 +0530", "Message-Id": "<20210630124637.2987722-1-abhinandan.gujjar@intel.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] test: fix crypto_op length for sessionless case", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, private_data_offset for the sessionless is computed\nwrongly which includes extra bytes added because of using\nsizeof(struct rte_crypto_sym_xform) * 2) instead of\n(sizeof(union rte_event_crypto_metadata)). Due to this buffer\noverflow, the corruption was leading to test application\ncrash while freeing the ops mempool.\n\nFixes: 3c2c535ecfc0 (\"test: add event crypto adapter auto-test\")\nReported-by: ciara.power@intel.com\n\nSigned-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>\n---\n app/test/test_event_crypto_adapter.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c\nindex f689bc1f2..688ac0b2f 100644\n--- a/app/test/test_event_crypto_adapter.c\n+++ b/app/test/test_event_crypto_adapter.c\n@@ -229,7 +229,7 @@ test_op_forward_mode(uint8_t session_less)\n \t\tfirst_xform = &cipher_xform;\n \t\tsym_op->xform = first_xform;\n \t\tuint32_t len = IV_OFFSET + MAXIMUM_IV_LENGTH +\n-\t\t\t\t(sizeof(struct rte_crypto_sym_xform) * 2);\n+\t\t\t\t(sizeof(union rte_event_crypto_metadata));\n \t\top->private_data_offset = len;\n \t\t/* Fill in private data information */\n \t\trte_memcpy(&m_data.response_info, &response_info,\n@@ -424,7 +424,7 @@ test_op_new_mode(uint8_t session_less)\n \t\tfirst_xform = &cipher_xform;\n \t\tsym_op->xform = first_xform;\n \t\tuint32_t len = IV_OFFSET + MAXIMUM_IV_LENGTH +\n-\t\t\t\t(sizeof(struct rte_crypto_sym_xform) * 2);\n+\t\t\t\t(sizeof(union rte_event_crypto_metadata));\n \t\top->private_data_offset = len;\n \t\t/* Fill in private data information */\n \t\trte_memcpy(&m_data.response_info, &response_info,\n", "prefixes": [] }{ "id": 95077, "url": "