Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 9453,
    "url": "http://patches.dpdk.org/api/patches/9453/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1449741007-1022-2-git-send-email-remy.horton@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1449741007-1022-2-git-send-email-remy.horton@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1449741007-1022-2-git-send-email-remy.horton@intel.com",
    "date": "2015-12-10T09:50:06",
    "name": "[dpdk-dev,v1,1/2] examples/ethtool: Fix uninitialised variable",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "c6030b3a1129a4d86b2f400e53f71684e52a1130",
    "submitter": {
        "id": 326,
        "url": "http://patches.dpdk.org/api/people/326/?format=api",
        "name": "Remy Horton",
        "email": "remy.horton@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1449741007-1022-2-git-send-email-remy.horton@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/9453/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/9453/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 430158E58;\n\tThu, 10 Dec 2015 10:50:14 +0100 (CET)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 342035A6C\n\tfor <dev@dpdk.org>; Thu, 10 Dec 2015 10:50:11 +0100 (CET)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 10 Dec 2015 01:50:10 -0800",
            "from rhorton-mobl.ger.corp.intel.com (HELO localhost.ir.intel.com)\n\t([163.33.228.64])\n\tby fmsmga002.fm.intel.com with ESMTP; 10 Dec 2015 01:50:10 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.20,407,1444719600\"; d=\"scan'208\";a=\"870740166\"",
        "From": "Remy Horton <remy.horton@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Thu, 10 Dec 2015 09:50:06 +0000",
        "Message-Id": "<1449741007-1022-2-git-send-email-remy.horton@intel.com>",
        "X-Mailer": "git-send-email 1.9.3",
        "In-Reply-To": "<1449741007-1022-1-git-send-email-remy.horton@intel.com>",
        "References": "<1449741007-1022-1-git-send-email-remy.horton@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v1 1/2] examples/ethtool: Fix uninitialised\n\tvariable",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Fix Coverity warning with uninitialised field in structure being used.\nZero out all the other unused ones.\n\n>>> CID 120413 (#1 of 1): Uninitialized scalar variable (UNINIT)\n\nFixes: bda68ab9d1e7 (\"examples/ethtool: add user-space ethtool sample application\")\n\nSigned-off-by: Remy Horton <remy.horton@intel.com>\n---\n examples/ethtool/ethtool-app/ethapp.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/examples/ethtool/ethtool-app/ethapp.c b/examples/ethtool/ethtool-app/ethapp.c\nindex 3863b02..2ed4796 100644\n--- a/examples/ethtool/ethtool-app/ethapp.c\n+++ b/examples/ethtool/ethtool-app/ethapp.c\n@@ -339,6 +339,7 @@ pcmd_pause_callback(void *ptr_params,\n \tif (ptr_data != NULL) {\n \t\tstat = rte_ethtool_get_pauseparam(params->port, &info);\n \t} else {\n+\t\tmemset(&info, 0, sizeof(info));\n \t\tif (strcasecmp(\"all\", params->opt) == 0) {\n \t\t\tinfo.tx_pause = 1;\n \t\t\tinfo.rx_pause = 1;\n@@ -352,6 +353,8 @@ pcmd_pause_callback(void *ptr_params,\n \t\t\tinfo.tx_pause = 0;\n \t\t\tinfo.rx_pause = 0;\n \t\t}\n+\t\t/* Assume auto-negotiation wanted */\n+\t\tinfo.autoneg = 1;\n \t\tstat = rte_ethtool_set_pauseparam(params->port, &info);\n \t}\n \tif (stat == 0) {\n",
    "prefixes": [
        "dpdk-dev",
        "v1",
        "1/2"
    ]
}