Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94344/?format=api
{ "id": 94344, "url": "http://patches.dpdk.org/api/patches/94344/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210617110005.4132926-20-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210617110005.4132926-20-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210617110005.4132926-20-jiawenwu@trustnetic.com", "date": "2021-06-17T11:00:05", "name": "[v6,19/19] net/ngbe: support to close and reset device", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "1d7ca439fbfa36399a2bf0b9533be9f670dff249", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210617110005.4132926-20-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 17372, "url": "http://patches.dpdk.org/api/series/17372/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17372", "date": "2021-06-17T10:59:46", "name": "net: ngbe PMD", "version": 6, "mbox": "http://patches.dpdk.org/series/17372/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/94344/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/94344/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E8E5A0C4D;\n\tThu, 17 Jun 2021 13:00:27 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2EA9C410F3;\n\tThu, 17 Jun 2021 12:58:48 +0200 (CEST)", "from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128])\n by mails.dpdk.org (Postfix) with ESMTP id 6432441174\n for <dev@dpdk.org>; Thu, 17 Jun 2021 12:58:46 +0200 (CEST)", "from wxdbg.localdomain.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Thu, 17 Jun 2021 18:58:39 +0800 (CST)" ], "X-QQ-mid": "bizesmtp46t1623927520tex607ex", "X-QQ-SSF": "01400000000000D0E000B00A0000000", "X-QQ-FEAT": "0VmwRkEgV1FFuVSbpJlLEb8f/FC6WpQI2lODb35qZVouWtE8/eLLlI13s3a2o\n 7PG2F2tJBY8hQ7Ih9B8hUX8v2Ve+edDdg4bkT1/5YuRAkg5klBScFgcE34skjt4eAk+iMSo\n meXmibLWv1c2rlqpMhRFnaXB0IvluTCq8EvNRwp9pVe45jqXnx5w6uwQDkdQuKUERI89sxM\n SGlcE0rYf6jUTtKTSWEHm1Clg8XCp6TgQWpLrynaQZzDzWw+mTps6DimrTl+v73aHnf3v3/\n K1ICY9DOLKtP4B6gvoah+U8IDBIzpTNMjNb6POnMCZSM0a12oDpbnvx0x+XgQSrADYR6/lW\n rGMGETYRHNQ4nyqp3pGWtCUHKqnVQtVcM8bSVTj", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Thu, 17 Jun 2021 19:00:05 +0800", "Message-Id": "<20210617110005.4132926-20-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210617110005.4132926-1-jiawenwu@trustnetic.com>", "References": "<20210617110005.4132926-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign5", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v6 19/19] net/ngbe: support to close and reset\n device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support to close and reset device.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/ngbe/ngbe_ethdev.c | 61 ++++++++++++++++++++++++++++++++--\n drivers/net/ngbe/ngbe_ethdev.h | 2 ++\n drivers/net/ngbe/ngbe_rxtx.c | 20 +++++++++++\n 3 files changed, 81 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c\nindex ef8ea5ecff..695c1d26c8 100644\n--- a/drivers/net/ngbe/ngbe_ethdev.c\n+++ b/drivers/net/ngbe/ngbe_ethdev.c\n@@ -558,11 +558,66 @@ ngbe_dev_stop(struct rte_eth_dev *dev)\n static int\n ngbe_dev_close(struct rte_eth_dev *dev)\n {\n+\tstruct ngbe_hw *hw = ngbe_dev_hw(dev);\n+\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n+\tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n+\tint retries = 0;\n+\tint ret;\n+\n \tPMD_INIT_FUNC_TRACE();\n \n-\tRTE_SET_USED(dev);\n+\tngbe_pf_reset_hw(hw);\n+\n+\tret = ngbe_dev_stop(dev);\n+\n+\tngbe_dev_free_queues(dev);\n+\n+\t/* reprogram the RAR[0] in case user changed it. */\n+\tngbe_set_rar(hw, 0, hw->mac.addr, 0, true);\n+\n+\t/* Unlock any pending hardware semaphore */\n+\tngbe_swfw_lock_reset(hw);\n+\n+\t/* disable uio intr before callback unregister */\n+\trte_intr_disable(intr_handle);\n+\n+\tdo {\n+\t\tret = rte_intr_callback_unregister(intr_handle,\n+\t\t\t\tngbe_dev_interrupt_handler, dev);\n+\t\tif (ret >= 0 || ret == -ENOENT) {\n+\t\t\tbreak;\n+\t\t} else if (ret != -EAGAIN) {\n+\t\t\tPMD_INIT_LOG(ERR,\n+\t\t\t\t\"intr callback unregister failed: %d\",\n+\t\t\t\tret);\n+\t\t}\n+\t\trte_delay_ms(100);\n+\t} while (retries++ < (10 + NGBE_LINK_UP_TIME));\n+\n+\trte_free(dev->data->mac_addrs);\n+\tdev->data->mac_addrs = NULL;\n+\n+\trte_free(dev->data->hash_mac_addrs);\n+\tdev->data->hash_mac_addrs = NULL;\n+\n+\treturn ret;\n+}\n+\n+/*\n+ * Reset PF device.\n+ */\n+static int\n+ngbe_dev_reset(struct rte_eth_dev *dev)\n+{\n+\tint ret;\n+\n+\tret = eth_ngbe_dev_uninit(dev);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tret = eth_ngbe_dev_init(dev, NULL);\n \n-\treturn -EINVAL;\n+\treturn ret;\n }\n \n static int\n@@ -1101,6 +1156,8 @@ static const struct eth_dev_ops ngbe_eth_dev_ops = {\n \t.dev_infos_get = ngbe_dev_info_get,\n \t.dev_start = ngbe_dev_start,\n \t.dev_stop = ngbe_dev_stop,\n+\t.dev_close = ngbe_dev_close,\n+\t.dev_reset = ngbe_dev_reset,\n \t.link_update = ngbe_dev_link_update,\n \t.rx_queue_start\t = ngbe_dev_rx_queue_start,\n \t.rx_queue_stop = ngbe_dev_rx_queue_stop,\ndiff --git a/drivers/net/ngbe/ngbe_ethdev.h b/drivers/net/ngbe/ngbe_ethdev.h\nindex d576eef5d6..3893853645 100644\n--- a/drivers/net/ngbe/ngbe_ethdev.h\n+++ b/drivers/net/ngbe/ngbe_ethdev.h\n@@ -67,6 +67,8 @@ ngbe_dev_intr(struct rte_eth_dev *dev)\n */\n void ngbe_dev_clear_queues(struct rte_eth_dev *dev);\n \n+void ngbe_dev_free_queues(struct rte_eth_dev *dev);\n+\n void ngbe_dev_rx_queue_release(void *rxq);\n \n void ngbe_dev_tx_queue_release(void *txq);\ndiff --git a/drivers/net/ngbe/ngbe_rxtx.c b/drivers/net/ngbe/ngbe_rxtx.c\nindex 0801424245..62b1523c77 100644\n--- a/drivers/net/ngbe/ngbe_rxtx.c\n+++ b/drivers/net/ngbe/ngbe_rxtx.c\n@@ -935,6 +935,26 @@ ngbe_dev_clear_queues(struct rte_eth_dev *dev)\n \t}\n }\n \n+void\n+ngbe_dev_free_queues(struct rte_eth_dev *dev)\n+{\n+\tunsigned int i;\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tngbe_dev_rx_queue_release(dev->data->rx_queues[i]);\n+\t\tdev->data->rx_queues[i] = NULL;\n+\t}\n+\tdev->data->nb_rx_queues = 0;\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tngbe_dev_tx_queue_release(dev->data->tx_queues[i]);\n+\t\tdev->data->tx_queues[i] = NULL;\n+\t}\n+\tdev->data->nb_tx_queues = 0;\n+}\n+\n static int __rte_cold\n ngbe_alloc_rx_queue_mbufs(struct ngbe_rx_queue *rxq)\n {\n", "prefixes": [ "v6", "19/19" ] }