Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94009/?format=api
{ "id": 94009, "url": "http://patches.dpdk.org/api/patches/94009/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210607175943.31690-54-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210607175943.31690-54-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210607175943.31690-54-ndabilpuram@marvell.com", "date": "2021-06-07T17:59:34", "name": "[v2,53/62] net/cnxk: support for rss in rte_flow", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "1b846a2ee5416b5a1c3697289228865aaee724e0", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210607175943.31690-54-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 17256, "url": "http://patches.dpdk.org/api/series/17256/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17256", "date": "2021-06-07T17:58:41", "name": "Marvell CNXK Ethdev Driver", "version": 2, "mbox": "http://patches.dpdk.org/series/17256/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/94009/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/94009/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B5958A034F;\n\tMon, 7 Jun 2021 20:09:36 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E69FE411CB;\n\tMon, 7 Jun 2021 20:05:51 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id A518E4120B\n for <dev@dpdk.org>; Mon, 7 Jun 2021 20:05:50 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 157I1avY017507 for <dev@dpdk.org>; Mon, 7 Jun 2021 11:05:50 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 391ecv2eqh-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 07 Jun 2021 11:05:50 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Mon, 7 Jun 2021 11:05:48 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 7 Jun 2021 11:05:48 -0700", "from hyd1588t430.marvell.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 6B7853F7040;\n Mon, 7 Jun 2021 11:05:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=7dne/OXMrNdTnyXq4IGwhQW1WeAH1VATAKLHu3gqnBQ=;\n b=LhJwlfnDJYbzVE1s0MWvOAj+clH90zXo6YcatAIVfTNlH83UxNWv33zA+RWT7DU6s1Ev\n YrfmAaaks4aOXjNfTTUvO1khVUmEq0Bi/Bd4lG2V4AXdU/Esno2X4RNkn4LDExlLNH4m\n XKDnhUkHHFJ7qOBZJZisOg6abRejFVlFuvDpTaU+GKJdGJK/vvg57Y7ao1ZHmf8WxYgm\n NbwnrIZP65j/756mbI2gOabWF2hLLQuAAaw6cHolUvw0zORb50KNvzc0iLZuOq0b07PZ\n dCL9/O0FI+miMZ+LOXu8uVM4/wuXaTwglAHGz64tO0qRRmCOeuLPxZdwBKKv1hfNwbdS fA==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<jerinj@marvell.com>, <skori@marvell.com>, <skoteshwar@marvell.com>,\n <pbhagavatula@marvell.com>, <kirankumark@marvell.com>,\n <psatheesh@marvell.com>, <asekhar@marvell.com>", "Date": "Mon, 7 Jun 2021 23:29:34 +0530", "Message-ID": "<20210607175943.31690-54-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20210607175943.31690-1-ndabilpuram@marvell.com>", "References": "<20210306153404.10781-1-ndabilpuram@marvell.com>\n <20210607175943.31690-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "huuux0Ug6CPtLnfveNP6wQbPVUoZXHAc", "X-Proofpoint-ORIG-GUID": "huuux0Ug6CPtLnfveNP6wQbPVUoZXHAc", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761\n definitions=2021-06-07_14:2021-06-04,\n 2021-06-07 signatures=0", "Subject": "[dpdk-dev] [PATCH v2 53/62] net/cnxk: support for rss in rte_flow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Satheesh Paul <psatheesh@marvell.com>\n\nAdded support for rss action in rte_flow code based on ROC.\n\nSigned-off-by: Satheesh Paul <psatheesh@marvell.com>\n---\n drivers/net/cnxk/cnxk_rte_flow.c | 72 +++++++++++++++++++++++++++++++++++-----\n 1 file changed, 64 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/cnxk/cnxk_rte_flow.c b/drivers/net/cnxk/cnxk_rte_flow.c\nindex d0e7bdc..8486e9e 100644\n--- a/drivers/net/cnxk/cnxk_rte_flow.c\n+++ b/drivers/net/cnxk/cnxk_rte_flow.c\n@@ -4,15 +4,64 @@\n #include <cnxk_rte_flow.h>\n \n static int\n-cnxk_map_actions(struct rte_eth_dev *dev,\n+npc_rss_action_validate(struct rte_eth_dev *dev,\n+\t\t\tconst struct rte_flow_attr *attr,\n+\t\t\tconst struct rte_flow_action *act)\n+{\n+\tconst struct rte_flow_action_rss *rss;\n+\n+\trss = (const struct rte_flow_action_rss *)act->conf;\n+\n+\tif (attr->egress) {\n+\t\tplt_err(\"No support of RSS in egress\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_RSS) {\n+\t\tplt_err(\"multi-queue mode is disabled\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\tif (!rss || !rss->queue_num) {\n+\t\tplt_err(\"no valid queues\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (rss->func != RTE_ETH_HASH_FUNCTION_DEFAULT) {\n+\t\tplt_err(\"non-default RSS hash functions are not supported\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\tif (rss->key_len && rss->key_len > ROC_NIX_RSS_KEY_LEN) {\n+\t\tplt_err(\"RSS hash key too large\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static void\n+npc_rss_flowkey_get(struct cnxk_eth_dev *dev,\n+\t\t const struct roc_npc_action *rss_action,\n+\t\t uint32_t *flowkey_cfg)\n+{\n+\tconst struct roc_npc_action_rss *rss;\n+\n+\trss = (const struct roc_npc_action_rss *)rss_action->conf;\n+\n+\t*flowkey_cfg = cnxk_rss_ethdev_to_nix(dev, rss->types, rss->level);\n+}\n+\n+static int\n+cnxk_map_actions(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,\n \t\t const struct rte_flow_action actions[],\n-\t\t struct roc_npc_action in_actions[])\n+\t\t struct roc_npc_action in_actions[], uint32_t *flowkey_cfg)\n {\n \tstruct cnxk_eth_dev *hw = dev->data->dev_private;\n \tconst struct rte_flow_action_count *act_count;\n \tconst struct rte_flow_action_queue *act_q;\n+\tint i = 0, rc = 0;\n \tint rq;\n-\tint i = 0;\n \n \tRTE_SET_USED(hw);\n \n@@ -68,7 +117,12 @@ cnxk_map_actions(struct rte_eth_dev *dev,\n \t\t\tbreak;\n \n \t\tcase RTE_FLOW_ACTION_TYPE_RSS:\n+\t\t\trc = npc_rss_action_validate(dev, attr, actions);\n+\t\t\tif (rc)\n+\t\t\t\tgoto err_exit;\n \t\t\tin_actions[i].type = ROC_NPC_ACTION_TYPE_RSS;\n+\t\t\tin_actions[i].conf = actions->conf;\n+\t\t\tnpc_rss_flowkey_get(hw, &in_actions[i], flowkey_cfg);\n \t\t\tbreak;\n \n \t\tcase RTE_FLOW_ACTION_TYPE_SECURITY:\n@@ -94,7 +148,7 @@ cnxk_map_flow_data(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,\n \t\t const struct rte_flow_action actions[],\n \t\t struct roc_npc_attr *in_attr,\n \t\t struct roc_npc_item_info in_pattern[],\n-\t\t struct roc_npc_action in_actions[])\n+\t\t struct roc_npc_action in_actions[], uint32_t *flowkey_cfg)\n {\n \tint i = 0;\n \n@@ -113,7 +167,7 @@ cnxk_map_flow_data(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,\n \t}\n \tin_pattern[i].type = ROC_NPC_ITEM_TYPE_END;\n \n-\treturn cnxk_map_actions(dev, actions, in_actions);\n+\treturn cnxk_map_actions(dev, attr, actions, in_actions, flowkey_cfg);\n }\n \n static int\n@@ -128,12 +182,13 @@ cnxk_flow_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,\n \tstruct roc_npc *npc = &hw->npc;\n \tstruct roc_npc_attr in_attr;\n \tstruct roc_npc_flow flow;\n+\tuint32_t flowkey_cfg = 0;\n \tint rc;\n \n \tmemset(&flow, 0, sizeof(flow));\n \n \trc = cnxk_map_flow_data(dev, attr, pattern, actions, &in_attr,\n-\t\t\t\tin_pattern, in_actions);\n+\t\t\t\tin_pattern, in_actions, &flowkey_cfg);\n \tif (rc) {\n \t\trte_flow_error_set(error, 0, RTE_FLOW_ERROR_TYPE_ACTION_NUM,\n \t\t\t\t NULL, \"Failed to map flow data\");\n@@ -155,11 +210,12 @@ cnxk_flow_create(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,\n \tstruct roc_npc *npc = &hw->npc;\n \tstruct roc_npc_attr in_attr;\n \tstruct roc_npc_flow *flow;\n-\tint errcode;\n+\tint errcode = 0;\n \tint rc;\n \n \trc = cnxk_map_flow_data(dev, attr, pattern, actions, &in_attr,\n-\t\t\t\tin_pattern, in_actions);\n+\t\t\t\tin_pattern, in_actions,\n+\t\t\t\t&npc->flowkey_cfg_state);\n \tif (rc) {\n \t\trte_flow_error_set(error, 0, RTE_FLOW_ERROR_TYPE_ACTION_NUM,\n \t\t\t\t NULL, \"Failed to map flow data\");\n", "prefixes": [ "v2", "53/62" ] }