Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93906/?format=api
{ "id": 93906, "url": "http://patches.dpdk.org/api/patches/93906/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210604144225.287678-8-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210604144225.287678-8-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210604144225.287678-8-andrew.rybchenko@oktetlabs.ru", "date": "2021-06-04T14:42:21", "name": "[07/11] net/sfc: fix MAC stats update to work for stopped device", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "288d023f7a2f7718fc4a167509c1158c2fc51486", "submitter": { "id": 2013, "url": "http://patches.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210604144225.287678-8-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 17239, "url": "http://patches.dpdk.org/api/series/17239/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17239", "date": "2021-06-04T14:42:14", "name": "net/sfc: provide Rx/Tx doorbells stats", "version": 1, "mbox": "http://patches.dpdk.org/series/17239/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/93906/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/93906/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 18797A0A0F;\n\tFri, 4 Jun 2021 16:43:20 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 078D5410F1;\n\tFri, 4 Jun 2021 16:43:13 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 9230040E78;\n Fri, 4 Jun 2021 16:43:09 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 66ECB7F563; Fri, 4 Jun 2021 17:43:09 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 1BA367F684;\n Fri, 4 Jun 2021 17:42:36 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 1BA367F684", "Authentication-Results": "shelob.oktetlabs.ru/1BA367F684; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>, stable@dpdk.org,\n Andy Moreton <amoreton@xilinx.com>, Andrew Lee <alee@solarflare.com>,\n Robert Stonehouse <rstonehouse@solarflare.com>", "Date": "Fri, 4 Jun 2021 17:42:21 +0300", "Message-Id": "<20210604144225.287678-8-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 07/11] net/sfc: fix MAC stats update to work for\n stopped device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\n\nFixes: 1caab2f1e68 (\"net/sfc: add basic statistics\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc.h | 2 +-\n drivers/net/sfc/sfc_ethdev.c | 6 +++---\n drivers/net/sfc/sfc_port.c | 11 +++++++----\n 3 files changed, 11 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h\nindex 972d32606d..1594f934ba 100644\n--- a/drivers/net/sfc/sfc.h\n+++ b/drivers/net/sfc/sfc.h\n@@ -422,7 +422,7 @@ int sfc_port_start(struct sfc_adapter *sa);\n void sfc_port_stop(struct sfc_adapter *sa);\n void sfc_port_link_mode_to_info(efx_link_mode_t link_mode,\n \t\t\t\tstruct rte_eth_link *link_info);\n-int sfc_port_update_mac_stats(struct sfc_adapter *sa);\n+int sfc_port_update_mac_stats(struct sfc_adapter *sa, boolean_t manual_update);\n int sfc_port_reset_mac_stats(struct sfc_adapter *sa);\n int sfc_set_rx_mode(struct sfc_adapter *sa);\n int sfc_set_rx_mode_unchecked(struct sfc_adapter *sa);\ndiff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex ae9304f90f..bbc22723f6 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -615,7 +615,7 @@ sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \n \tsfc_adapter_lock(sa);\n \n-\tret = sfc_port_update_mac_stats(sa);\n+\tret = sfc_port_update_mac_stats(sa, B_FALSE);\n \tif (ret != 0)\n \t\tgoto unlock;\n \n@@ -733,7 +733,7 @@ sfc_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\n \n \tsfc_adapter_lock(sa);\n \n-\trc = sfc_port_update_mac_stats(sa);\n+\trc = sfc_port_update_mac_stats(sa, B_FALSE);\n \tif (rc != 0) {\n \t\tSFC_ASSERT(rc > 0);\n \t\tnstats = -rc;\n@@ -797,7 +797,7 @@ sfc_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,\n \n \tsfc_adapter_lock(sa);\n \n-\trc = sfc_port_update_mac_stats(sa);\n+\trc = sfc_port_update_mac_stats(sa, B_FALSE);\n \tif (rc != 0) {\n \t\tSFC_ASSERT(rc > 0);\n \t\tret = -rc;\ndiff --git a/drivers/net/sfc/sfc_port.c b/drivers/net/sfc/sfc_port.c\nindex bb9e01d96b..8c432c15f5 100644\n--- a/drivers/net/sfc/sfc_port.c\n+++ b/drivers/net/sfc/sfc_port.c\n@@ -26,7 +26,8 @@\n /**\n * Update MAC statistics in the buffer.\n *\n- * @param\tsa\tAdapter\n+ * @param\tsa\t\tAdapter\n+ * @param\tforce_upload\tFlag to upload MAC stats in any case\n *\n * @return Status code\n * @retval\t0\tSuccess\n@@ -34,7 +35,7 @@\n * @retval\tENOMEM\tMemory allocation failure\n */\n int\n-sfc_port_update_mac_stats(struct sfc_adapter *sa)\n+sfc_port_update_mac_stats(struct sfc_adapter *sa, boolean_t force_upload)\n {\n \tstruct sfc_port *port = &sa->port;\n \tefsys_mem_t *esmp = &port->mac_stats_dma_mem;\n@@ -46,14 +47,14 @@ sfc_port_update_mac_stats(struct sfc_adapter *sa)\n \tSFC_ASSERT(sfc_adapter_is_locked(sa));\n \n \tif (sa->state != SFC_ADAPTER_STARTED)\n-\t\treturn EINVAL;\n+\t\treturn 0;\n \n \t/*\n \t * If periodic statistics DMA'ing is off or if not supported,\n \t * make a manual request and keep an eye on timer if need be\n \t */\n \tif (!port->mac_stats_periodic_dma_supported ||\n-\t (port->mac_stats_update_period_ms == 0)) {\n+\t (port->mac_stats_update_period_ms == 0) || force_upload) {\n \t\tif (port->mac_stats_update_period_ms != 0) {\n \t\t\tuint64_t timestamp = sfc_get_system_msecs();\n \n@@ -367,6 +368,8 @@ sfc_port_stop(struct sfc_adapter *sa)\n \t(void)efx_mac_stats_periodic(sa->nic, &sa->port.mac_stats_dma_mem,\n \t\t\t\t 0, B_FALSE);\n \n+\tsfc_port_update_mac_stats(sa, B_TRUE);\n+\n \tefx_port_fini(sa->nic);\n \tefx_filter_fini(sa->nic);\n \n", "prefixes": [ "07/11" ] }