Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93687/?format=api
{ "id": 93687, "url": "http://patches.dpdk.org/api/patches/93687/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210601071122.1612432-3-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210601071122.1612432-3-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210601071122.1612432-3-michaelba@nvidia.com", "date": "2021-06-01T07:11:21", "name": "[3/4] vdpa/mlx5: fix constant type in QP creation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "798401729e3189c638efd0304c168a6b23f11e02", "submitter": { "id": 1949, "url": "http://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210601071122.1612432-3-michaelba@nvidia.com/mbox/", "series": [ { "id": 17180, "url": "http://patches.dpdk.org/api/series/17180/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17180", "date": "2021-06-01T07:11:21", "name": "[1/4] regex/mlx5: fix size of setup constants", "version": 1, "mbox": "http://patches.dpdk.org/series/17180/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/93687/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/93687/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F00BAA0A0C;\n\tTue, 1 Jun 2021 09:31:17 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7983E41104;\n\tTue, 1 Jun 2021 09:11:56 +0200 (CEST)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2064.outbound.protection.outlook.com [40.107.220.64])\n by mails.dpdk.org (Postfix) with ESMTP id 0054341100;\n Tue, 1 Jun 2021 09:11:54 +0200 (CEST)", "from BN9PR03CA0326.namprd03.prod.outlook.com (2603:10b6:408:112::31)\n by BY5PR12MB4904.namprd12.prod.outlook.com (2603:10b6:a03:1d3::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.21; Tue, 1 Jun\n 2021 07:11:53 +0000", "from BN8NAM11FT014.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:112:cafe::39) by BN9PR03CA0326.outlook.office365.com\n (2603:10b6:408:112::31) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.24 via Frontend\n Transport; Tue, 1 Jun 2021 07:11:53 +0000", "from mail.nvidia.com (216.228.112.34) by\n BN8NAM11FT014.mail.protection.outlook.com (10.13.177.142) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4150.30 via Frontend Transport; Tue, 1 Jun 2021 07:11:53 +0000", "from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 1 Jun\n 2021 07:11:51 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=VAVaNFTOTz4myY09vPzHoz6PV9HIjAIesNNVwPhP5icuv8eA2v5LniZl4OdeWRs4+4FEP/ur+8L7pM382Fw3MMV8qNI/D1CtRU0wXn6SKyM4PHnYzNBzssVxAqnmor4cDQhHuNBUND2WXMVYNh3Q1S+IBxrgzUzKwD4nppLVUheiosokNqVx3hlu1m/CuNVn9A2krzY15VQZrQtXHNNohC5K5pZp4ns4zpyCFeAqC0DPP9OE9rwLF/+h4dhEdF+2q3WYxkHzE3VUslYMRVCKXTxlh2e8feRzNAG0QK/BX2LQUR6qHd8+xGSQBaiBvgzZoF2TWCtB8XNGnWAYSBTv0g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=xA9umsA4gLUKdQaZsI35BL1/XSqs9fWND64TDm7joyY=;\n b=jZgaz2Rrvk9zpxWD2Y/srycA2rwVDoUmjqtaNWzgfxvvzELAbgrldjhfIZiLGaav58aygDnEU3xezuVpfDpb+pB7HT9peLpgWSKAP8dJIT/tnMKkmInLPYcBluKAsi7CrRUh1xmSH543LBxuYvPpbSNpKWnPMMHVe2esGs+BjUQ3F3NcR71nR9k/xR7Em5mbadoiegXvaui5jmryZOSMkCVcnRkVas36APVN2t7ayJxC3WefTC+Yr3KBkDCS3oPgMncL88ujzjAs/cf4c2isMvNgKLG0jJ10kdznfuPxQdK98BLFsvuWb4BuMG880t8+Fbby/bL8fgrmLSvF5j7vZw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=xA9umsA4gLUKdQaZsI35BL1/XSqs9fWND64TDm7joyY=;\n b=p9QI3jJrwYkMkd9w2RwfMxznsgBDxAQTt+DSC0Un0GkwjBQ1EQXW7mQlPBqQP6Uv+F9fVVPq/TCwjUMWnRWONZ7uP4iic84uSOjNzTZUyDPipSHT5qTZvOExv7s6kVLQFAiXwhqwUa0oX+TnlLo7CcFEepQEzhivOyGDgrYyXW2z6qI4YmWu7xScOYYDdXGU27MgQ9+0a7x8WtNjOmQHWLf69wss6Gu0Czy14zGA7DSNc+TGQWTy73kgj/coYoJ5Muk2GojPVkkHOmCZ0GkPGVmrkPW170IjtSDNMOU7cmW1zsO9WgpaIcPsqmTZqG9YgKKAY1mX8RsAkFBm9CZ9lA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>, <stable@dpdk.org>", "Date": "Tue, 1 Jun 2021 10:11:21 +0300", "Message-ID": "<20210601071122.1612432-3-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210601071122.1612432-1-michaelba@nvidia.com>", "References": "<20210601071122.1612432-1-michaelba@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.145.6]", "X-ClientProxiedBy": "HQMAIL107.nvidia.com (172.20.187.13) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "3833df6c-8a5f-4be0-f24b-08d924cc8892", "X-MS-TrafficTypeDiagnostic": "BY5PR12MB4904:", "X-Microsoft-Antispam-PRVS": "\n <BY5PR12MB4904B166C5C6DE493A58C30ECC3E9@BY5PR12MB4904.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:4303;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n cMVhd2BKd5GUp2DwHmt+96EoEjZ4Xpm1QK0arJPxdu29EAyVM+/ihbFc8IXyVzwRc95QfgLdlwhIdq1hAUIfmugskG3xFdQu9100nsjGOGwUwfHRwi8rZNdtxlSZ0evP7d8F9NnloAv1UvTh3cwpD/hnZljxeLDNc3LhIo/UaufgGP+LmSOl96lqXSE7riuAAerHP5tnZvT1ceHlgmLLwJ5CEDguFFnlCYmSJfYCWXqXe2BPI2l28CewnNVSPjvJaG+h27JAEUyD1oPNg8HmuDBr1OD25DBp7CJrQ7IBheQcWotKBOWY7rbHmvtpnz8QbJdA76WF9ZC2oWbPMmxqPQOJ3n6Lzvswx4Gl6X13OLzReFV8fsDHT8Q4VspPEGGUai6epW6MB4aGIwtSl/CzdMGx1wXBUv12ScaPYiEAdGlLythsaPVDiRgI+KgOKJv129VqnBWgdIbx1R8xnx3C9Ml4Zy174GcAOGrPVWjVegoQExV5WfxK4CoY505L624XWbcGVqH8jKGKje+aMLRg+wbuuwpG8rmkgFl0Dbic9IQt/Tturmg8qTogsJC3BBuQtwC4b7QSuEIFOZv5MVyUF1W00SwgugRrFokFolcmcVSRoQPTE9pHwYsGyjWYXR+yYK7DDCcQhRDA9MNE0aS8cg==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(376002)(396003)(136003)(39860400002)(346002)(46966006)(36840700001)(36906005)(36860700001)(426003)(7696005)(4326008)(82310400003)(54906003)(83380400001)(450100002)(316002)(8676002)(7636003)(47076005)(478600001)(55016002)(82740400003)(70206006)(6286002)(2906002)(6666004)(6916009)(356005)(5660300002)(26005)(70586007)(86362001)(16526019)(8936002)(2616005)(1076003)(336012)(36756003)(186003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "01 Jun 2021 07:11:53.0956 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 3833df6c-8a5f-4be0-f24b-08d924cc8892", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT014.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR12MB4904", "Subject": "[dpdk-dev] [PATCH 3/4] vdpa/mlx5: fix constant type in QP creation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The mlx5_vdpa_event_qp_create function makes shifting to the numeric\nconstant 1, then multiplies it by another constant and finally assigns\nit into a uint64_t variable.\n\nThe numeric constant type is an int with a 32-bit sign. if after\nshifting , its MSB (bit of sign) will change, the uint64 variable will\nget into it a different value than what the function intended it to get.\n\nSet the numeric constant 1 to be uint64_t in the first place.\n\nFixes: 8395927cdfaf (\"vdpa/mlx5: prepare HW queues\")\nCc: stable@dpdk.org\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa_event.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c\nindex 88f6a4256d..3541c652ce 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c\n@@ -629,8 +629,8 @@ mlx5_vdpa_event_qp_create(struct mlx5_vdpa_priv *priv, uint16_t desc_n,\n \tattr.wq_umem_id = eqp->umem_obj->umem_id;\n \tattr.wq_umem_offset = 0;\n \tattr.dbr_umem_id = eqp->umem_obj->umem_id;\n-\tattr.dbr_address = (1 << log_desc_n) * MLX5_WSEG_SIZE;\n \tattr.ts_format = mlx5_ts_format_conv(priv->qp_ts_format);\n+\tattr.dbr_address = RTE_BIT64(log_desc_n) * MLX5_WSEG_SIZE;\n \teqp->sw_qp = mlx5_devx_cmd_create_qp(priv->ctx, &attr);\n \tif (!eqp->sw_qp) {\n \t\tDRV_LOG(ERR, \"Failed to create SW QP(%u).\", rte_errno);\n", "prefixes": [ "3/4" ] }