Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93430/?format=api
{ "id": 93430, "url": "http://patches.dpdk.org/api/patches/93430/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210525065818.10379-1-muhammad.ahmad@emumba.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210525065818.10379-1-muhammad.ahmad@emumba.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210525065818.10379-1-muhammad.ahmad@emumba.com", "date": "2021-05-25T06:58:18", "name": "[RFC] Add selection between vector and scalar mode in ixgbe", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b713b6b00c72b99efc8f85a5a246d29b41698bcf", "submitter": { "id": 1602, "url": "http://patches.dpdk.org/api/people/1602/?format=api", "name": "Muhammad Ahmad", "email": "muhammad.ahmad@emumba.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210525065818.10379-1-muhammad.ahmad@emumba.com/mbox/", "series": [ { "id": 17111, "url": "http://patches.dpdk.org/api/series/17111/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17111", "date": "2021-05-25T06:58:18", "name": "[RFC] Add selection between vector and scalar mode in ixgbe", "version": 1, "mbox": "http://patches.dpdk.org/series/17111/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/93430/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/93430/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A2782A0546;\n\tTue, 25 May 2021 08:58:35 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1E8954003F;\n\tTue, 25 May 2021 08:58:35 +0200 (CEST)", "from mail-wr1-f44.google.com (mail-wr1-f44.google.com\n [209.85.221.44]) by mails.dpdk.org (Postfix) with ESMTP id 3D6354003E\n for <dev@dpdk.org>; Tue, 25 May 2021 08:58:34 +0200 (CEST)", "by mail-wr1-f44.google.com with SMTP id q5so30904341wrs.4\n for <dev@dpdk.org>; Mon, 24 May 2021 23:58:34 -0700 (PDT)", "from localhost.localdomain (115-186-141-82.nayatel.pk.\n [115.186.141.82])\n by smtp.gmail.com with ESMTPSA id g66sm9822475wma.11.2021.05.24.23.58.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 24 May 2021 23:58:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=emumba-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id;\n bh=sZcuA3QXPbDeIIW46XpoiRL90yDQfOggb0WhubDkB9g=;\n b=GLdT/ppcesXbpg6IYNuFs52Bq8VY4qvHADskyH2ICk2pQyIs/Z/Ku6KRYNhfHx+l5Q\n CwrW9mLCgLto15nLTOpLC5thuAfijfmf26muEbUxuXS8FFihBTybDfUq6eBL6UOZIPJm\n j5vbC3+O/xJzhmJ4sfcxgvOpXGv6/W7uRSByQXhOCUR+C+jZp5BBTaKigW5R7eUOPPPL\n 5xNWvDfGAlSpSId1MuSiWBVZ1BvGCpfuk3bloPDS/NTjclXeckybll9IfKQb5nLn9HXh\n lCkzM9lDGwl3ihOVEyhrWzhcmqFdUCrRsowKz2HvQXsIxtc1O3l4rot9zHBqyrGJhp9E\n g0aw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id;\n bh=sZcuA3QXPbDeIIW46XpoiRL90yDQfOggb0WhubDkB9g=;\n b=nr/xeOMgxKr8tsvTi68ygoEMhx7UlUr5D15nQbtsvSu408sLCTjWCVpyg+0zT5OuQS\n 6DZdfr/zZ8yDBsiLU2tsZRX7eRHSEWnoJX1JmLVST+jGYgKLE3Riv7EBT0tHLZYaOX5u\n h3+mKwhJfNGyDTzrSNiwCOWEb5g8uLEFd5eMYaitdlWLarvnjASHkcmsn7ovamGJiu1x\n E14ZtlxtTf5A4D8iI5wUrigGwRZLD7ICByL32/eSsx3J2Xfjqe68ZYHrdpmgsYJmv8mG\n fuEikiimmVResRTmTnTtI58Wxyqvc7bs7dmtrA48LiWJ4jlFXOD2PBPLvtGwVJOarGUu\n M6Uw==", "X-Gm-Message-State": "AOAM533BEwMYJRa7AOrX2k0K3b3xBEFIklJdLkLD3/mVv5Oj272gidE7\n qhJiT9F1HWNKcWAGIvyQIpd7A/kvfPJ+CsRFsaU=", "X-Google-Smtp-Source": "\n ABdhPJwBXkRageJM3I4tZccW6/aCsQ0MK+JiISHt8AK70UO7T5NhvVxSO4P6NWS9UK4Ak69BhZHWPQ==", "X-Received": "by 2002:a5d:6484:: with SMTP id o4mr24855891wri.8.1621925913632;\n Mon, 24 May 2021 23:58:33 -0700 (PDT)", "From": "Muhammad Ahmad <muhammad.ahmad@emumba.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, qi.z.zhang@intel.com, bruce.richardson@intel.com,\n konstantin.ananyev@intel.com, jia.guo@intel.com, beilei.xing@intel.com,\n Muhammad Ahmad <muhammad.ahmad@emumba.com>", "Date": "Tue, 25 May 2021 11:58:18 +0500", "Message-Id": "<20210525065818.10379-1-muhammad.ahmad@emumba.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [RFC] Add selection between vector and scalar mode in\n ixgbe", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The selection between scalar mode and vector mode was removed for\nixgbe driver in DPDK 20.02. The code base still has code\nfor scalar mode but it cannot be selected at compile time. The\nvector mode is adequate for applications which require high\nthroughput which is the case most of the time, but scalar mode has\na use case in ultra-low-latency fintech applications for algorithmic\ntrading. This use case was also presented at the DPDK userspace\nsummit in September 2020.\nThis patch enables the ability to select between scalar and vector\nmodes for ixgbe drivers in the config.\nIn the future we can introduce API in ehtdev, which allow user to\nselect between latency and throughput mode. \n\nSigned-off-by: Muhammad Ahmad <muhammad.ahmad@emumba.com>\n---\n config/rte_config.h | 3 +++\n drivers/net/ixgbe/ixgbe_ethdev.c | 9 ++++++++-\n 2 files changed, 11 insertions(+), 1 deletion(-)\n\n RTE_LOG_REGISTER(ixgbe_logtype_tx_free, pmd.net.ixgbe.tx_free, DEBUG);\n #endif\n+", "diff": "diff --git a/config/rte_config.h b/config/rte_config.h\nindex 8aa46a1aa..cc30f7f39 100644\n--- a/config/rte_config.h\n+++ b/config/rte_config.h\n@@ -121,6 +121,9 @@\n /* hns3 defines */\n #define RTE_LIBRTE_HNS3_MAX_TQP_NUM_PER_PF 256\n \n+/*ixgbe defines*/\n+#define RTE_IXGBE_SCALAR_ENABLE 0\n+\n /* i40e defines */\n #define RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC 1\n #undef RTE_LIBRTE_I40E_16BYTE_RX_DESC\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 00101c2ee..c992dc7e5 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -84,7 +84,7 @@\n #define IXGBE_DEFAULT_RX_WTHRESH 0\n \n #define IXGBE_DEFAULT_TX_FREE_THRESH 32\n #define IXGBE_DEFAULT_TX_PTHRESH 32\n #define IXGBE_DEFAULT_TX_HTHRESH 0\n #define IXGBE_DEFAULT_TX_WTHRESH 0\n #define IXGBE_DEFAULT_TX_RSBIT_THRESH 32\n@@ -2415,6 +2415,12 @@ ixgbe_dev_configure(struct rte_eth_dev *dev)\n \t */\n \tadapter->rx_bulk_alloc_allowed = true;\n \tadapter->rx_vec_allowed = true;\n+\n+\t#if RTE_IXGBE_SCALAR_ENABLE == 1\n+\tadapter->rx_vec_allowed = false;\n+\t#endif\n \n \treturn 0;\n }\n@@ -9121,3 +9127,4 @@ RTE_LOG_REGISTER(ixgbe_logtype_tx, pmd.net.ixgbe.tx, DEBUG);\n #ifdef RTE_LIBRTE_IXGBE_DEBUG_TX_FREE\n", "prefixes": [ "RFC" ] }