Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93427/?format=api
{ "id": 93427, "url": "http://patches.dpdk.org/api/patches/93427/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210524185952.673258-3-lance.richardson@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210524185952.673258-3-lance.richardson@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210524185952.673258-3-lance.richardson@broadcom.com", "date": "2021-05-24T18:59:50", "name": "[2/3] net/bnxt: fix Rx burst size constraint", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d7b9487c3665434df2656fafff88e266931c3f74", "submitter": { "id": 1323, "url": "http://patches.dpdk.org/api/people/1323/?format=api", "name": "Lance Richardson", "email": "lance.richardson@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210524185952.673258-3-lance.richardson@broadcom.com/mbox/", "series": [ { "id": 17109, "url": "http://patches.dpdk.org/api/series/17109/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17109", "date": "2021-05-24T18:59:48", "name": "net/bnxt: vector mode patches", "version": 1, "mbox": "http://patches.dpdk.org/series/17109/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/93427/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/93427/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E561A0547;\n\tMon, 24 May 2021 21:00:23 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EF46641109;\n\tMon, 24 May 2021 21:00:20 +0200 (CEST)", "from mail-pl1-f176.google.com (mail-pl1-f176.google.com\n [209.85.214.176])\n by mails.dpdk.org (Postfix) with ESMTP id F1823410FE\n for <dev@dpdk.org>; Mon, 24 May 2021 21:00:19 +0200 (CEST)", "by mail-pl1-f176.google.com with SMTP id b7so10939434plg.0\n for <dev@dpdk.org>; Mon, 24 May 2021 12:00:19 -0700 (PDT)", "from localhost.localdomain ([192.19.231.250])\n by smtp.gmail.com with ESMTPSA id g4sm12239049pgu.46.2021.05.24.12.00.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 24 May 2021 12:00:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version; bh=2T25zHICG7eQeieMi/2cMn7A6yxZPv8YBbpL+DAvDVg=;\n b=VdG5PoaGsRohR7feD8GkmkIgqbEjmT5X/ehX9nbm19Bh7bQX7DgUtxvQDVRhtL+kVz\n zeFmFq8IiTMfvWnPITsBCVds2Iqhns+rFFvsMxBUhSfknmFm37xgqbtNlF5evc1EW5gn\n cECM0sGCsxM+8nPVxkrzo2y+hjOFpoPW8jnCE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version;\n bh=2T25zHICG7eQeieMi/2cMn7A6yxZPv8YBbpL+DAvDVg=;\n b=lCKw37oX26xQxG7f5k5RIc3L5A+RK7BELQroz2tq8/m2pcBEE+SD4Q+9kMn7IBiB4a\n 7+rMEosirGydFCbqGg2hPG/UoGnES+PBy+RJwoLwou17jyeq3/ZgBawajJ2siJy/cAiq\n 7scGrY4SdC5ee3FVlMND/QGquB35hbTJ6tLhR4sbEbsxm1kHd8TEQN7ff2Nvc3T4cRY1\n dH9yYLWbRKmO9t8KgQIbMgm+Se122S+mep+yChlGygg3PY5ZdorbW1kW7dkp383Oy1R0\n FuO6d21QuwdT6S3p0s0kYPYehqoR4QSemf54rLvoxg5wcTxlQYNVuRN8cXb5B56eBbJh\n 4O1A==", "X-Gm-Message-State": "AOAM533DY6IEnHIngWbbuKGE+MxHjoMEnfQJ47AU/3p9N7S160edUO8N\n hErqYB/5D0BvrTA/uSDB+L7DTA==", "X-Google-Smtp-Source": "\n ABdhPJzCa7gn5SQBmiPUdKiwW9lFi0k7AxPkoMf2mwcgfZB512v6GvcfyY4AjKBIc8lMRhiYRN6wHQ==", "X-Received": "by 2002:a17:903:31d3:b029:ee:bccd:e686 with SMTP id\n v19-20020a17090331d3b02900eebccde686mr27151688ple.1.1621882818982;\n Mon, 24 May 2021 12:00:18 -0700 (PDT)", "From": "Lance Richardson <lance.richardson@broadcom.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Ruifeng Wang <ruifeng.wang@arm.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Mon, 24 May 2021 14:59:50 -0400", "Message-Id": "<20210524185952.673258-3-lance.richardson@broadcom.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210524185952.673258-1-lance.richardson@broadcom.com>", "References": "<20210524185952.673258-1-lance.richardson@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"000000000000505a7505c31805de\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.29", "Subject": "[dpdk-dev] [PATCH 2/3] net/bnxt: fix Rx burst size constraint", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The burst receive function should return all packets currently\npresent in the receive ring up to the requested burst size,\nupdate vector mode receive functions accordingly.\n\nFixes: 398358341419 (\"net/bnxt: support NEON\")\nFixes: bc4a000f2f53 (\"net/bnxt: implement SSE vector mode\")\nCc: stable@dpdk.org\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 29 +++++++++++++++++++++------\n drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 29 +++++++++++++++++++++------\n 2 files changed, 46 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c\nindex a6fbc0b0bf..a6e630ea5e 100644\n--- a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c\n+++ b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c\n@@ -158,9 +158,8 @@ descs_to_mbufs(uint32x4_t mm_rxcmp[4], uint32x4_t mm_rxcmp1[4],\n \tvst1q_u32((uint32_t *)&mbuf[3]->rx_descriptor_fields1, tmp);\n }\n \n-uint16_t\n-bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n-\t\t uint16_t nb_pkts)\n+static uint16_t\n+recv_burst_vec_neon(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n {\n \tstruct bnxt_rx_queue *rxq = rx_queue;\n \tstruct bnxt_cp_ring_info *cpr = rxq->cp_ring;\n@@ -185,9 +184,6 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tif (rxq->rxrearm_nb >= rxq->rx_free_thresh)\n \t\tbnxt_rxq_rearm(rxq, rxr);\n \n-\t/* Return no more than RTE_BNXT_MAX_RX_BURST per call. */\n-\tnb_pkts = RTE_MIN(nb_pkts, RTE_BNXT_MAX_RX_BURST);\n-\n \tcons = raw_cons & (cp_ring_size - 1);\n \tmbcons = (raw_cons / 2) & (rx_ring_size - 1);\n \n@@ -305,6 +301,27 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \treturn nb_rx_pkts;\n }\n \n+uint16_t\n+bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n+{\n+\tuint16_t cnt = 0;\n+\n+\twhile (nb_pkts > RTE_BNXT_MAX_RX_BURST) {\n+\t\tuint16_t burst;\n+\n+\t\tburst = recv_burst_vec_neon(rx_queue, rx_pkts + cnt,\n+\t\t\t\t\t RTE_BNXT_MAX_RX_BURST);\n+\n+\t\tcnt += burst;\n+\t\tnb_pkts -= burst;\n+\n+\t\tif (burst < RTE_BNXT_MAX_RX_BURST)\n+\t\t\treturn cnt;\n+\t}\n+\n+\treturn cnt + recv_burst_vec_neon(rx_queue, rx_pkts + cnt, nb_pkts);\n+}\n+\n static void\n bnxt_handle_tx_cp_vec(struct bnxt_tx_queue *txq)\n {\ndiff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c\nindex 6dd18a0077..fe074f82cf 100644\n--- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c\n+++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c\n@@ -149,9 +149,8 @@ descs_to_mbufs(__m128i mm_rxcmp[4], __m128i mm_rxcmp1[4],\n \t_mm_store_si128((void *)&mbuf[3]->rx_descriptor_fields1, t0);\n }\n \n-uint16_t\n-bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n-\t\t uint16_t nb_pkts)\n+static uint16_t\n+recv_burst_vec_sse(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n {\n \tstruct bnxt_rx_queue *rxq = rx_queue;\n \tconst __m128i mbuf_init = _mm_set_epi64x(0, rxq->mbuf_initializer);\n@@ -176,9 +175,6 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tif (rxq->rxrearm_nb >= rxq->rx_free_thresh)\n \t\tbnxt_rxq_rearm(rxq, rxr);\n \n-\t/* Return no more than RTE_BNXT_MAX_RX_BURST per call. */\n-\tnb_pkts = RTE_MIN(nb_pkts, RTE_BNXT_MAX_RX_BURST);\n-\n \tcons = raw_cons & (cp_ring_size - 1);\n \tmbcons = (raw_cons / 2) & (rx_ring_size - 1);\n \n@@ -286,6 +282,27 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,\n \treturn nb_rx_pkts;\n }\n \n+uint16_t\n+bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n+{\n+\tuint16_t cnt = 0;\n+\n+\twhile (nb_pkts > RTE_BNXT_MAX_RX_BURST) {\n+\t\tuint16_t burst;\n+\n+\t\tburst = recv_burst_vec_sse(rx_queue, rx_pkts + cnt,\n+\t\t\t\t\t RTE_BNXT_MAX_RX_BURST);\n+\n+\t\tcnt += burst;\n+\t\tnb_pkts -= burst;\n+\n+\t\tif (burst < RTE_BNXT_MAX_RX_BURST)\n+\t\t\treturn cnt;\n+\t}\n+\n+\treturn cnt + recv_burst_vec_sse(rx_queue, rx_pkts + cnt, nb_pkts);\n+}\n+\n static void\n bnxt_handle_tx_cp_vec(struct bnxt_tx_queue *txq)\n {\n", "prefixes": [ "2/3" ] }