Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 93395,
    "url": "http://patches.dpdk.org/api/patches/93395/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210524093754.21046-1-thierry.herbelot@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210524093754.21046-1-thierry.herbelot@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210524093754.21046-1-thierry.herbelot@6wind.com",
    "date": "2021-05-24T09:37:54",
    "name": "[v2] net/pfe: no need to check dev to be NULL Pointer",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "44119e97b433f3ec9b5e129572e652aae46f4cc8",
    "submitter": {
        "id": 897,
        "url": "http://patches.dpdk.org/api/people/897/?format=api",
        "name": "Thierry Herbelot",
        "email": "thierry.herbelot@6wind.com"
    },
    "delegate": {
        "id": 3961,
        "url": "http://patches.dpdk.org/api/users/3961/?format=api",
        "username": "arybchenko",
        "first_name": "Andrew",
        "last_name": "Rybchenko",
        "email": "andrew.rybchenko@oktetlabs.ru"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210524093754.21046-1-thierry.herbelot@6wind.com/mbox/",
    "series": [
        {
            "id": 17093,
            "url": "http://patches.dpdk.org/api/series/17093/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=17093",
            "date": "2021-05-24T09:37:54",
            "name": "[v2] net/pfe: no need to check dev to be NULL Pointer",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/17093/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/93395/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/93395/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5B307A0547;\n\tMon, 24 May 2021 11:38:04 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BA8C04003E;\n\tMon, 24 May 2021 11:38:03 +0200 (CEST)",
            "from proxy.6wind.com (host.78.145.23.62.rev.coltfrance.com\n [62.23.145.78]) by mails.dpdk.org (Postfix) with ESMTP id 6B7AF4003C;\n Mon, 24 May 2021 11:38:02 +0200 (CEST)",
            "from localhost (unknown [10.16.0.39])\n by proxy.6wind.com (Postfix) with ESMTP id 48A5B9B4AA9;\n Mon, 24 May 2021 11:38:02 +0200 (CEST)"
        ],
        "From": "Thierry Herbelot <thierry.herbelot@6wind.com>",
        "To": "dev@dpdk.org",
        "Cc": "Thierry Herbelot <thierry.herbelot@6wind.com>,\n Thomas Monjalon <thomas@monjalon.net>, stable@dpdk.org,\n Gagandeep Singh <g.singh@nxp.com>",
        "Date": "Mon, 24 May 2021 11:37:54 +0200",
        "Message-Id": "<20210524093754.21046-1-thierry.herbelot@6wind.com>",
        "X-Mailer": "git-send-email 2.29.2",
        "In-Reply-To": "<20210524085917.16254-1-thierry.herbelot@6wind.com>",
        "References": "<20210524085917.16254-1-thierry.herbelot@6wind.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v2] net/pfe: no need to check dev to be NULL\n Pointer",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "librte_ethdev library is already doing some checks on dev before calling\nthe link update.\n\nFixes: acd4818ea2a45 (\"net/pfe: add link status update\")\nCc: stable@dpdk.org\nCc: Gagandeep Singh <g.singh@nxp.com>\n\nSigned-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>\n--\nV2: rework after noting dev cannot be NULL\n---\n drivers/net/pfe/pfe_ethdev.c | 5 -----\n 1 file changed, 5 deletions(-)",
    "diff": "diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c\nindex 3135466713fb..feec4d10a26e 100644\n--- a/drivers/net/pfe/pfe_ethdev.c\n+++ b/drivers/net/pfe/pfe_ethdev.c\n@@ -582,11 +582,6 @@ pfe_eth_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused)\n \tstruct rte_eth_link link, old;\n \tunsigned int lstatus = 1;\n \n-\tif (dev == NULL) {\n-\t\tPFE_PMD_ERR(\"Invalid device in link_update.\\n\");\n-\t\treturn 0;\n-\t}\n-\n \tmemset(&old, 0, sizeof(old));\n \tmemset(&link, 0, sizeof(struct rte_eth_link));\n \n",
    "prefixes": [
        "v2"
    ]
}