Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93162/?format=api
{ "id": 93162, "url": "http://patches.dpdk.org/api/patches/93162/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210511131435.1226820-2-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210511131435.1226820-2-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210511131435.1226820-2-ferruh.yigit@intel.com", "date": "2021-05-11T13:14:33", "name": "[v3,2/4] net/bnx2x: fix build with gcc11", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fa44b4bee1c1fdbbba326455634cd1b2c71f25f0", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210511131435.1226820-2-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 16927, "url": "http://patches.dpdk.org/api/series/16927/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16927", "date": "2021-05-11T13:14:32", "name": "[v3,1/4] net/bnx2x: fix build with gcc11", "version": 3, "mbox": "http://patches.dpdk.org/series/16927/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/93162/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/93162/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 55C57A0A0E;\n\tTue, 11 May 2021 15:14:48 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 272B041104;\n\tTue, 11 May 2021 15:14:44 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 8AEF3406A3;\n Tue, 11 May 2021 15:14:42 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 May 2021 06:14:42 -0700", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.27])\n by fmsmga001.fm.intel.com with ESMTP; 11 May 2021 06:14:40 -0700" ], "IronPort-SDR": [ "\n UISltvMCdpbNvkpVigGs8gP8ciUg6VEkxfk7MYv3EbK4a3m4GHyS6mJxZwTocpW3pFwc8vUVM4\n K/NtvzJre+YQ==", "\n KvIrDEFZNTt15AvJWRk1vzbduWV2Vo5WFPzwM9B0nrxg9JvKQor8fjr47rs5BToOnybMjS3Zby\n XoebFnSqqMuQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9980\"; a=\"284928119\"", "E=Sophos;i=\"5.82,290,1613462400\"; d=\"scan'208\";a=\"284928119\"", "E=Sophos;i=\"5.82,290,1613462400\"; d=\"scan'208\";a=\"537021104\"" ], "X-ExtLoop1": "1", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Rasesh Mody <rmody@marvell.com>,\n\tShahed Shaikh <shshaikh@marvell.com>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, stable@dpdk.org,\n Kevin Traynor <ktraynor@redhat.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>", "Date": "Tue, 11 May 2021 14:14:33 +0100", "Message-Id": "<20210511131435.1226820-2-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210511131435.1226820-1-ferruh.yigit@intel.com>", "References": "<20210510150319.1496105-1-ferruh.yigit@intel.com>\n <20210511131435.1226820-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 2/4] net/bnx2x: fix build with gcc11", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Reproduced with '--buildtype=debugoptimized' config,\ncompiler version: gcc (GCC) 12.0.0 20210509 (experimental)\n\nBuild error:\nIn file included from ../drivers/net/bnx2x/bnx2x.c:16:\n../drivers/net/bnx2x/bnx2x.c: In function ‘bnx2x_hc_ack_sb’:\n../drivers/net/bnx2x/bnx2x.h:1528:35:\n warning: ‘igu_ack’ is used uninitialized [-Wuninitialized]\n #define REG_WR32(sc, offset, val) bnx2x_reg_write32(sc, (offset), val)\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n../drivers/net/bnx2x/bnx2x.h:1531:33:\n\tnote: in expansion of macro ‘REG_WR32’\n 1531 | #define REG_WR(sc, offset, val) REG_WR32(sc, offset, val)\n | ^~~~~~~~\n../drivers/net/bnx2x/bnx2x.h:1916:9: note: in expansion of macro ‘REG_WR’\n 1916 | REG_WR(sc, hc_addr, *val);\n | ^~~~~~\n../drivers/net/bnx2x/bnx2x.h:1905:33: note: ‘igu_ack’ declared here\n 1905 | struct igu_ack_register igu_ack;\n | ^~~~~~~\n\nREG_WR32 requires 'uint32_t', use union instead of cast to 'uint32_t'.\n\nBugzilla ID: 692\nFixes: 38dff79ba736 (\"net/bnx2x: update HSI\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\nAcked-by: Kevin Traynor <ktraynor@redhat.com>\n---\nCc: rmody@marvell.com\nCc: Kevin Traynor <ktraynor@redhat.com>\nCc: Ajit Khaparde <ajit.khaparde@broadcom.com>\n\nv3:\n* Add missing Bugzilla tag\n---\n drivers/net/bnx2x/bnx2x.h | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h\nindex e13ab1557418..80d19cbfd665 100644\n--- a/drivers/net/bnx2x/bnx2x.h\n+++ b/drivers/net/bnx2x/bnx2x.h\n@@ -1902,18 +1902,19 @@ bnx2x_hc_ack_sb(struct bnx2x_softc *sc, uint8_t sb_id, uint8_t storm,\n {\n \tuint32_t hc_addr = (HC_REG_COMMAND_REG + SC_PORT(sc) * 32 +\n \t\t\tCOMMAND_REG_INT_ACK);\n-\tstruct igu_ack_register igu_ack;\n-\tuint32_t *val = NULL;\n+\tunion {\n+\t\tstruct igu_ack_register igu_ack;\n+\t\tuint32_t val;\n+\t} val;\n \n-\tigu_ack.status_block_index = index;\n-\tigu_ack.sb_id_and_flags =\n+\tval.igu_ack.status_block_index = index;\n+\tval.igu_ack.sb_id_and_flags =\n \t\t((sb_id << IGU_ACK_REGISTER_STATUS_BLOCK_ID_SHIFT) |\n \t\t (storm << IGU_ACK_REGISTER_STORM_ID_SHIFT) |\n \t\t (update << IGU_ACK_REGISTER_UPDATE_INDEX_SHIFT) |\n \t\t (op << IGU_ACK_REGISTER_INTERRUPT_MODE_SHIFT));\n \n-\tval = (uint32_t *)&igu_ack;\n-\tREG_WR(sc, hc_addr, *val);\n+\tREG_WR(sc, hc_addr, val.val);\n \n \t/* Make sure that ACK is written */\n \tmb();\n", "prefixes": [ "v3", "2/4" ] }