Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93026/?format=api
{ "id": 93026, "url": "http://patches.dpdk.org/api/patches/93026/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210506142526.28245-22-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210506142526.28245-22-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210506142526.28245-22-mk@semihalf.com", "date": "2021-05-06T14:25:25", "name": "[v3,21/22] net/ena: report default ring size", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "549a43d2cca98ff65618bf6a0f5fe0ffe3ab6532", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210506142526.28245-22-mk@semihalf.com/mbox/", "series": [ { "id": 16861, "url": "http://patches.dpdk.org/api/series/16861/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16861", "date": "2021-05-06T14:25:04", "name": "net/ena: update ENA PMD to v2.3.0", "version": 3, "mbox": "http://patches.dpdk.org/series/16861/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/93026/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/93026/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 26EF6A0524;\n\tThu, 6 May 2021 16:28:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1CF1B41198;\n\tThu, 6 May 2021 16:26:16 +0200 (CEST)", "from mail-lf1-f44.google.com (mail-lf1-f44.google.com\n [209.85.167.44]) by mails.dpdk.org (Postfix) with ESMTP id 65E314003F\n for <dev@dpdk.org>; Thu, 6 May 2021 16:26:11 +0200 (CEST)", "by mail-lf1-f44.google.com with SMTP id z13so8101384lft.1\n for <dev@dpdk.org>; Thu, 06 May 2021 07:26:11 -0700 (PDT)", "from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl.\n [89.79.189.199])\n by smtp.gmail.com with ESMTPSA id b40sm892908ljr.101.2021.05.06.07.26.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 06 May 2021 07:26:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=OVjiNi3rEM6c2TPW5cj3QlpdyHt7FsIV4QxsJDBzno0=;\n b=TZTIKLyavPOw4IMAhcUX7ZurVRsJzaPmEISAwtTj0vc8ePRrNL8DAEVOyHJK6Ze4DK\n zwk6q0FKYuG8h/VJmYQdIoM3KIezazmffLgxxClpxAgLBDy5zh5jUEM/7v63OAn2T5sh\n 23S1tnCSCMsaRS8BhlRUlTBCMKdxQ/pRV2H+XKiBNOjMPXuX9Cq5bD/o8oTit1lHPji0\n Ck5SGtW0htknkCHa6yjWKBm8lY5F1c8MPLIgJr5IeNW05Jnv6ADI+NCeEnByqjJzNQCL\n h0lhfH5LlnXPIhM7jmNUBP4hvvADiHjjIcXAzUl+D9+4iRE4AjnBY1vkYRWJeGpIffhO\n YP8Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=OVjiNi3rEM6c2TPW5cj3QlpdyHt7FsIV4QxsJDBzno0=;\n b=qJ75Owje3ZGkd2+ZMmYCYTRS1A2fRCilB6oToad2roHa6cSi73bvS2xxSjF0/fOv9w\n sskm4YdrbrXfyIg+TY4GZNIXiAocUUoQi8s2oAgzZGnfgu9INw9O7p8EvRpQl/Pa5HbA\n vMH0G2xhgkrwaF2/HmdGZ4uVyeRWUN3x9p/qxQGCfIER5hJVspH80lwjbPBzPAwbJtKs\n c8JgHvuDfM3sa92ipdDY9M3oUMZC/IIBQu6FF3RZUKQcPrrv9cSc72b9RzMhikFqGPys\n 5nAZNtZ5ZZ4gZbT2GT2tdeENYn1Cz9jEkqZXYlvrt/EsPBmhaeBd+5ukco7SqYZ3o25v\n vpAg==", "X-Gm-Message-State": "AOAM5300KtqSq8U4my9shUqNJyGDHup68tIelaMxL1a7jaeoSam1E1Lp\n J/5zkCnpa+ws9oqtnwOua0NvdlpFdjjOpncC", "X-Google-Smtp-Source": "\n ABdhPJyDZGMunzAuvua64pfnVubDUuK8d6jIHbdChe60zAo2f8j/wBISOYCdYPhBFrawDUnA2OyF6Q==", "X-Received": "by 2002:ac2:5626:: with SMTP id b6mr3185499lff.147.1620311170742;\n Thu, 06 May 2021 07:26:10 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com,\n upstream@semihalf.com, Stanislaw Kardach <kda@semihalf.com>,\n stable@dpdk.org, Michal Krawczyk <mk@semihalf.com>,\n Shay Agroskin <shayagr@amazon.com>", "Date": "Thu, 6 May 2021 16:25:25 +0200", "Message-Id": "<20210506142526.28245-22-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210506142526.28245-1-mk@semihalf.com>", "References": "<20210505073348.6394-1-mk@semihalf.com>\n <20210506142526.28245-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 21/22] net/ena: report default ring size", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stanislaw Kardach <kda@semihalf.com>\n\nRemove invalid ring size alignment logic and add default rx and tx port\nring sizes to the device info spec.\n\nThe logic in lines 1297 and 1371 is invalid. The\nRTE_ETH_DEV_FALLBACK_RX_RINGSIZE (and the TX counterpart) is a value\nthat rte_eth_rx_queue_setup() will set if\ndev_info.default_rxportconf.ring_size is 0 and user provided 0 in\nnb_rx_desc argument. However the current code treats it as a hint for\nthe PMD to change the ring size to internal defaults.\n\nAdditionally since the ENA_DEFAULT_RING_SIZE is defined, report it in\nthe device capabilities so that both rte_ethdev code and the user can\nutilize it for device configuration.\n\nFixes: ea93d37eb49d (\"net/ena: add HW queues depth setup\")\nCc: stable@dpdk.org\n\nSigned-off-by: Stanislaw Kardach <kda@semihalf.com>\nReviewed-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Shay Agroskin <shayagr@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 73e99e956a..c5d8e7d43e 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -1294,9 +1294,6 @@ static int ena_tx_queue_setup(struct rte_eth_dev *dev,\n \t\treturn -EINVAL;\n \t}\n \n-\tif (nb_desc == RTE_ETH_DEV_FALLBACK_TX_RINGSIZE)\n-\t\tnb_desc = adapter->max_tx_ring_size;\n-\n \ttxq->port_id = dev->data->port_id;\n \ttxq->next_to_clean = 0;\n \ttxq->next_to_use = 0;\n@@ -1368,9 +1365,6 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev,\n \t\treturn ENA_COM_FAULT;\n \t}\n \n-\tif (nb_desc == RTE_ETH_DEV_FALLBACK_RX_RINGSIZE)\n-\t\tnb_desc = adapter->max_rx_ring_size;\n-\n \tif (!rte_is_power_of_2(nb_desc)) {\n \t\tPMD_DRV_LOG(ERR,\n \t\t\t\"Unsupported size of RX queue: %d is not a power of 2.\\n\",\n@@ -2130,6 +2124,9 @@ static int ena_infos_get(struct rte_eth_dev *dev,\n \tdev_info->tx_desc_lim.nb_mtu_seg_max = RTE_MIN(ENA_PKT_MAX_BUFS,\n \t\t\t\t\tadapter->max_tx_sgl_size);\n \n+\tdev_info->default_rxportconf.ring_size = ENA_DEFAULT_RING_SIZE;\n+\tdev_info->default_txportconf.ring_size = ENA_DEFAULT_RING_SIZE;\n+\n \treturn 0;\n }\n \n", "prefixes": [ "v3", "21/22" ] }