Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93025/?format=api
{ "id": 93025, "url": "http://patches.dpdk.org/api/patches/93025/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210506142526.28245-21-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210506142526.28245-21-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210506142526.28245-21-mk@semihalf.com", "date": "2021-05-06T14:25:24", "name": "[v3,20/22] net/ena: disable dev_ops not supported in SMP", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "99ee526a78540dc6aae7d7502781889528512c22", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210506142526.28245-21-mk@semihalf.com/mbox/", "series": [ { "id": 16861, "url": "http://patches.dpdk.org/api/series/16861/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16861", "date": "2021-05-06T14:25:04", "name": "net/ena: update ENA PMD to v2.3.0", "version": 3, "mbox": "http://patches.dpdk.org/series/16861/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/93025/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/93025/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9AC62A0524;\n\tThu, 6 May 2021 16:28:15 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BC9CC4118D;\n\tThu, 6 May 2021 16:26:14 +0200 (CEST)", "from mail-lf1-f52.google.com (mail-lf1-f52.google.com\n [209.85.167.52]) by mails.dpdk.org (Postfix) with ESMTP id 0CF9641134\n for <dev@dpdk.org>; Thu, 6 May 2021 16:26:10 +0200 (CEST)", "by mail-lf1-f52.google.com with SMTP id j10so8019560lfb.12\n for <dev@dpdk.org>; Thu, 06 May 2021 07:26:10 -0700 (PDT)", "from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl.\n [89.79.189.199])\n by smtp.gmail.com with ESMTPSA id b40sm892908ljr.101.2021.05.06.07.26.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 06 May 2021 07:26:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=XqLFWwFfQzvhqGVnyC/bfONOpaXwYUdQmB1U7FEKRIU=;\n b=HJgLkvEvjQE7IBxeC/z0FT6CHQdNb2lJtwHL1hpkEw3MP4Ix0vgZ3vRwNRF7fCovju\n Yb1A+szLy/01kE0rHNF/muxBDKX8i8Ommiy5vh4vG5J3QSZaeHmrV4ONYKAwwFqIXqgm\n 9e4R7x1qW3AUDtCYG8IFLigIDSeTrZ6iuJrMLwbmpDk/f7Cnaw2ibmtlxIE4NZPtRpyw\n fvDtil5XicjBFsdWCqFfF2W7CoR5J9tYoWS8/vgSS0jpwHr+ocyXMGiXWyjkOgiT0E2n\n pTmF5lsjWKxKPwdq1oK2Kg9BtUtG2wG/0iJj2PFsjGtaGi+sVU401QeZKdzPl4rHXd9i\n yukw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=XqLFWwFfQzvhqGVnyC/bfONOpaXwYUdQmB1U7FEKRIU=;\n b=ljBYGQIRzwmSrGLb73sE6++886DP9itUk6YSYQwSKcWohpnvOWHp48SrSn8+qGam4C\n tZI5/b+K+4vJRqabX62oxYdNWgIGxqNv8ZcXfrtuKy/XWzS1+U3vKOEqNgUxMgkOt0hc\n A0s6/IIQtCZizT81wBTtXHbA1r+ifH852my64Gj7o8AG78e7e2krUmkUZ7eIt02qlJeD\n LUHgIEADLkUZM5I9gE6SOMDePJ6lnZ8dwQ1SFU0J+DDzM/HrSpTArgyr4D1t4lNmFTW9\n XGnj82TBZNn/6TUh9ypDJp2IhZhqt7Q5288nlsNvVJkszih2N8TWq7EFdE717d4UEom5\n AgDQ==", "X-Gm-Message-State": "AOAM532UXCfSHf4wBCUi3iOAIkLyH3SZN+4CDPunzHzfI+fW1C3wgUib\n layxBM+0VNoJT2iwCA278QMTDtgqJm5joyXy", "X-Google-Smtp-Source": "\n ABdhPJxC40/fyBV7Hab0s8kWF0iZXLWJRNY4VWuCElR5Ea1mv9AymRB/DJzUlv5KPysQsrYBg73UJw==", "X-Received": "by 2002:ac2:5059:: with SMTP id a25mr3045121lfm.484.1620311169247;\n Thu, 06 May 2021 07:26:09 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com,\n upstream@semihalf.com, Stanislaw Kardach <kda@semihalf.com>,\n Michal Krawczyk <mk@semihalf.com>, Shay Agroskin <shayagr@amazon.com>", "Date": "Thu, 6 May 2021 16:25:24 +0200", "Message-Id": "<20210506142526.28245-21-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210506142526.28245-1-mk@semihalf.com>", "References": "<20210505073348.6394-1-mk@semihalf.com>\n <20210506142526.28245-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 20/22] net/ena: disable dev_ops not supported\n in SMP", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stanislaw Kardach <kda@semihalf.com>\n\nFor dev_ops not supported in SMP, either return -EPERM or return without\ndoing anything. In both cases log a warning.\n\nSigned-off-by: Stanislaw Kardach <kda@semihalf.com>\nReviewed-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Shay Agroskin <shayagr@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 90ea40513a..73e99e956a 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -529,6 +529,12 @@ ena_dev_reset(struct rte_eth_dev *dev)\n {\n \tint rc = 0;\n \n+\t/* Cannot release memory in secondary process */\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n+\t\tPMD_DRV_LOG(WARNING, \"dev_reset not supported in secondary.\\n\");\n+\t\treturn -EPERM;\n+\t}\n+\n \tena_destroy_device(dev);\n \trc = eth_ena_dev_init(dev);\n \tif (rc)\n@@ -1052,6 +1058,12 @@ static int ena_start(struct rte_eth_dev *dev)\n \tuint64_t ticks;\n \tint rc = 0;\n \n+\t/* Cannot allocate memory in secondary process */\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n+\t\tPMD_DRV_LOG(WARNING, \"dev_start not supported in secondary.\\n\");\n+\t\treturn -EPERM;\n+\t}\n+\n \trc = ena_check_valid_conf(adapter);\n \tif (rc)\n \t\treturn rc;\n@@ -1098,6 +1110,12 @@ static int ena_stop(struct rte_eth_dev *dev)\n \tstruct ena_com_dev *ena_dev = &adapter->ena_dev;\n \tint rc;\n \n+\t/* Cannot free memory in secondary process */\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n+\t\tPMD_DRV_LOG(WARNING, \"dev_stop not supported in secondary.\\n\");\n+\t\treturn -EPERM;\n+\t}\n+\n \trte_timer_stop_sync(&adapter->timer_wd);\n \tena_queue_stop_all(dev, ENA_RING_TYPE_TX);\n \tena_queue_stop_all(dev, ENA_RING_TYPE_RX);\n", "prefixes": [ "v3", "20/22" ] }