Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93019/?format=api
{ "id": 93019, "url": "http://patches.dpdk.org/api/patches/93019/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210506142526.28245-15-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210506142526.28245-15-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210506142526.28245-15-mk@semihalf.com", "date": "2021-05-06T14:25:18", "name": "[v3,14/22] net/ena: indicate Rx RSS hash presence", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "31911ebe4432ca87ef025d6ba0eae4afe09ae02c", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210506142526.28245-15-mk@semihalf.com/mbox/", "series": [ { "id": 16861, "url": "http://patches.dpdk.org/api/series/16861/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16861", "date": "2021-05-06T14:25:04", "name": "net/ena: update ENA PMD to v2.3.0", "version": 3, "mbox": "http://patches.dpdk.org/series/16861/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/93019/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/93019/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DF8F7A0524;\n\tThu, 6 May 2021 16:27:35 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 077934116F;\n\tThu, 6 May 2021 16:26:05 +0200 (CEST)", "from mail-lf1-f50.google.com (mail-lf1-f50.google.com\n [209.85.167.50]) by mails.dpdk.org (Postfix) with ESMTP id 9F1DE4111F\n for <dev@dpdk.org>; Thu, 6 May 2021 16:26:01 +0200 (CEST)", "by mail-lf1-f50.google.com with SMTP id z13so8100631lft.1\n for <dev@dpdk.org>; Thu, 06 May 2021 07:26:01 -0700 (PDT)", "from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl.\n [89.79.189.199])\n by smtp.gmail.com with ESMTPSA id b40sm892908ljr.101.2021.05.06.07.25.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 06 May 2021 07:26:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=CCn/jybjwpSYdpjlPdx2Ac4wk64prMVI0wGVgKgb4uo=;\n b=TDpEMKs+KeiwJdUYZz//gGdsWKmCrGeVm+dPFy/xm+wkO64YYS01DgcqpeFXPr7Jc3\n lQ6TOSPHWY0FWQEh42pByRBuF7NJHlTu2eWO3NPxwcl9NCcGgtF1su/EomViO1stctVv\n H94UkDm529CX+x0XZgR0W3J0HUlQYT9uaaIzkXsCl0DAOuhxr79ZlE8Fzq/47UnAc/y9\n tYHmA4cIZOWIefIz+yzj0XNwp+xDTgd/Jc8OkJ2T5fdSUlN5haGauUKzAxEmuTmYDDnW\n gObLOCuz2bpwtECLNHrptVOQR/Qn/zEgTPqH8zvCiloKiM3Yd9xx4wuR9QfjUa7XVOaT\n UXig==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=CCn/jybjwpSYdpjlPdx2Ac4wk64prMVI0wGVgKgb4uo=;\n b=UoLCaxi1aKXkIo2odveXHfbcyCJ+sYUV67z4pF59B0pJZ/+/7zKZLnKj9yf4VgylAt\n 7uyoZlc6QUp+1xOWn/eRhBmY6uPt9w2hEoyEkMZu7PQKBLyPwbv5IUyB1V1FoZr/O8s/\n hUof7Tqgod5kuKSvmIoLs3elsLf39Rxwgzg4lcA7946dDL9OkT9e5pvP5ewYiYrIzdc0\n wAEKJMmIpA7WHOChtDkREDBT8Nf4neQV+PK2iYaja/yepNxfyMtYj+2TYEkxwKxHCD88\n pSHC3UWqG1Lr86Y6TnkubYHZ/QCHiG02N2NNxe1YexBAvVyLE+2Kzqmre0D/KYXjkcyD\n 4u2Q==", "X-Gm-Message-State": "AOAM531ES/6KOlwiyu644BE24UFCPw9w7h0sUOt2o382xhQVPZ7kmTCp\n f7H4Rh4VvsHio3ZWiESPwvf44AXvXimUOtYT", "X-Google-Smtp-Source": "\n ABdhPJw68CxTnDwsPf9m4wqJgBmwR+pLfTZUVdmfIN+TC3zj3rkQppRTJl3A/rfZP7RQBPfT+0oi+g==", "X-Received": "by 2002:ac2:4857:: with SMTP id 23mr3189510lfy.541.1620311160948;\n Thu, 06 May 2021 07:26:00 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com,\n upstream@semihalf.com, Michal Krawczyk <mk@semihalf.com>, stable@dpdk.org,\n Amit Bernstein <amitbern@amazon.com>", "Date": "Thu, 6 May 2021 16:25:18 +0200", "Message-Id": "<20210506142526.28245-15-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210506142526.28245-1-mk@semihalf.com>", "References": "<20210505073348.6394-1-mk@semihalf.com>\n <20210506142526.28245-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 14/22] net/ena: indicate Rx RSS hash presence", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To make it possible to the app to determine if the hash was calculated\nfor the packet or not, the PKT_RX_RSS_HASH should be set in the mbuf's\nol_flags.\n\nAs the PMD wasn't setting that, the application couldn't check if there\nis a hash in a proper way.\n\nThe hash is valid only if it's UDP or TCP and the IP packet wasn't\nfragmented.\n\nFixes: e5df9f33db00 (\"net/ena: fix passing RSS hash to mbuf\")\nCc: stable@dpdk.org\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Amit Bernstein <amitbern@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 6092288239..5d107775f4 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -51,6 +51,8 @@\n \n #define ENA_MIN_RING_DESC\t128\n \n+#define ENA_PTYPE_HAS_HASH\t(RTE_PTYPE_L4_TCP | RTE_PTYPE_L4_UDP)\n+\n enum ethtool_stringset {\n \tETH_SS_TEST = 0,\n \tETH_SS_STATS,\n@@ -314,6 +316,11 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf,\n \t\telse\n \t\t\tol_flags |= PKT_RX_L4_CKSUM_GOOD;\n \n+\tif (likely((packet_type & ENA_PTYPE_HAS_HASH) && !ena_rx_ctx->frag)) {\n+\t\tol_flags |= PKT_RX_RSS_HASH;\n+\t\tmbuf->hash.rss = ena_rx_ctx->hash;\n+\t}\n+\n \tmbuf->ol_flags = ol_flags;\n \tmbuf->packet_type = packet_type;\n }\n@@ -2245,8 +2252,6 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t\t++rx_ring->rx_stats.bad_csum;\n \t\t}\n \n-\t\tmbuf->hash.rss = ena_rx_ctx.hash;\n-\n \t\trx_pkts[completed] = mbuf;\n \t\trx_ring->rx_stats.bytes += mbuf->pkt_len;\n \t}\n", "prefixes": [ "v3", "14/22" ] }