Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/93010/?format=api
{ "id": 93010, "url": "http://patches.dpdk.org/api/patches/93010/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210506142526.28245-6-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210506142526.28245-6-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210506142526.28245-6-mk@semihalf.com", "date": "2021-05-06T14:25:09", "name": "[v3,05/22] net/ena/base: fix issues from the static code scan", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "be3c1f550cab454e7770025e6370ff0ca17b306f", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210506142526.28245-6-mk@semihalf.com/mbox/", "series": [ { "id": 16861, "url": "http://patches.dpdk.org/api/series/16861/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16861", "date": "2021-05-06T14:25:04", "name": "net/ena: update ENA PMD to v2.3.0", "version": 3, "mbox": "http://patches.dpdk.org/series/16861/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/93010/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/93010/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9B60FA0524;\n\tThu, 6 May 2021 16:26:26 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0C13A41128;\n\tThu, 6 May 2021 16:25:51 +0200 (CEST)", "from mail-lf1-f51.google.com (mail-lf1-f51.google.com\n [209.85.167.51]) by mails.dpdk.org (Postfix) with ESMTP id 9C53F4111D\n for <dev@dpdk.org>; Thu, 6 May 2021 16:25:49 +0200 (CEST)", "by mail-lf1-f51.google.com with SMTP id h4so8125237lfv.0\n for <dev@dpdk.org>; Thu, 06 May 2021 07:25:49 -0700 (PDT)", "from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl.\n [89.79.189.199])\n by smtp.gmail.com with ESMTPSA id b40sm892908ljr.101.2021.05.06.07.25.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 06 May 2021 07:25:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=2BdPDoLJORRt243MxZJPI0gvo+5S3HZcl0Ng69/Ukg0=;\n b=XVf/Qi3FLHyxgxx6kjopiy46eX9ATCBf8bpk0qFsu77eomiF+7ead4zaJjphlB5Y2/\n gSe90PXjqNhylacMI3hfKBC9Tz9m+MlrQ8772r9nTqMI+Ykd0B+8822d/2MQZC6dweYA\n G/t3JONGiExsGn+4UNqUBeWKNa4kCQAifrzkuTsMHnqKIxtAfW7lgoE7z9fuwzkq9PmS\n vxfVqJt6xfbkJ0t022DAf3rxNZEyZhX4XA+09hUA5lhmYdMSTowSCZAUh9k6RcOtBj1X\n JNann4H6/rRqi2FPHJyYl7bEt54/VLKHOfh7N4nZlLGxmZXCIK7QD43WKSnEmbIJ21U0\n Arvg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=2BdPDoLJORRt243MxZJPI0gvo+5S3HZcl0Ng69/Ukg0=;\n b=K4sV4dHjvsZ5N799CpPMOdYh7I4pvMJAVdrf9Td/qR+y0bSewnTLpPGWrdbGSFyfjd\n CpVeK3vwJdp35DPGgQ9MAKdcf/Oi9bVUku9QzAAb+NrvL4LAJzHS3dsT3t4LCay9bY0Q\n ohiAJZ0e3rq96cj4PTdBefsC9364Kw88dYqMC5bV7YFtPnUtV+zFxWxJolY4lhInclJb\n CwbjnXkH+n/KxLAKDzT59PuukZLAcicOqp5mRq1Jf//GOB3sLri4GXkqVT9Hclx/bmWu\n 9JEeGJHiN4rdcURR1ovHQ4CUv9Pyg4v3i/iNi5npmWJhC1OyJjzHwX27fiHVhf48ICKU\n NuAA==", "X-Gm-Message-State": "AOAM533SuWQGGEk6RwCWA1Nd7KPzLi+R6/0zORphUpoxoiBkbZ+RxGch\n dqAY6SICsly58brzwtqTKAqVSfYvT+TJVVOt", "X-Google-Smtp-Source": "\n ABdhPJw0PZIHjYwDkx63hzBjOP1W80jEq7wPoqgjQJIlWaGMcGE37W+BRBVAAGZsll8Tq0uOyF0FEA==", "X-Received": "by 2002:a19:c712:: with SMTP id x18mr3060424lff.589.1620311148881;\n Thu, 06 May 2021 07:25:48 -0700 (PDT)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com,\n upstream@semihalf.com, Michal Krawczyk <mk@semihalf.com>", "Date": "Thu, 6 May 2021 16:25:09 +0200", "Message-Id": "<20210506142526.28245-6-mk@semihalf.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210506142526.28245-1-mk@semihalf.com>", "References": "<20210505073348.6394-1-mk@semihalf.com>\n <20210506142526.28245-1-mk@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 05/22] net/ena/base: fix issues from the\n static code scan", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To silence error messages from the static code analysis, make the type\nconversions explicit where they're intended.\n\nAlso fix the type for the DMA width value.\n\nFixes: 99ecfbf845b3 (\"ena: import communication layer\")\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Igor Chauskin <igorch@amazon.com>\nReviewed-by: Guy Tzalik <gtzalik@amazon.com>\n---\n drivers/net/ena/base/ena_com.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c\nindex 9dc9f280c4..0cdeb1a2d9 100644\n--- a/drivers/net/ena/base/ena_com.c\n+++ b/drivers/net/ena/base/ena_com.c\n@@ -1382,7 +1382,7 @@ int ena_com_execute_admin_command(struct ena_com_admin_queue *admin_queue,\n \t\t\t\t \"Failed to submit command [%ld]\\n\",\n \t\t\t\t PTR_ERR(comp_ctx));\n \n-\t\treturn PTR_ERR(comp_ctx);\n+\t\treturn (int)PTR_ERR(comp_ctx);\n \t}\n \n \tret = ena_com_wait_and_process_admin_cq(comp_ctx, admin_queue);\n@@ -1602,7 +1602,7 @@ int ena_com_set_aenq_config(struct ena_com_dev *ena_dev, u32 groups_flag)\n int ena_com_get_dma_width(struct ena_com_dev *ena_dev)\n {\n \tu32 caps = ena_com_reg_bar_read32(ena_dev, ENA_REGS_CAPS_OFF);\n-\tint width;\n+\tu32 width;\n \n \tif (unlikely(caps == ENA_MMIO_READ_TIMEOUT)) {\n \t\tena_trc_err(ena_dev, \"Reg read timeout occurred\\n\");\n@@ -2280,7 +2280,7 @@ int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, int mtu)\n \tcmd.aq_common_descriptor.opcode = ENA_ADMIN_SET_FEATURE;\n \tcmd.aq_common_descriptor.flags = 0;\n \tcmd.feat_common.feature_id = ENA_ADMIN_MTU;\n-\tcmd.u.mtu.mtu = mtu;\n+\tcmd.u.mtu.mtu = (u32)mtu;\n \n \tret = ena_com_execute_admin_command(admin_queue,\n \t\t\t\t\t (struct ena_admin_aq_entry *)&cmd,\n@@ -2691,7 +2691,7 @@ int ena_com_indirect_table_set(struct ena_com_dev *ena_dev)\n \t\treturn ret;\n \t}\n \n-\tcmd.control_buffer.length = (1ULL << rss->tbl_log_size) *\n+\tcmd.control_buffer.length = (u32)(1ULL << rss->tbl_log_size) *\n \t\tsizeof(struct ena_admin_rss_ind_table_entry);\n \n \tret = ena_com_execute_admin_command(admin_queue,\n@@ -2713,7 +2713,7 @@ int ena_com_indirect_table_get(struct ena_com_dev *ena_dev, u32 *ind_tbl)\n \tu32 tbl_size;\n \tint i, rc;\n \n-\ttbl_size = (1ULL << rss->tbl_log_size) *\n+\ttbl_size = (u32)(1ULL << rss->tbl_log_size) *\n \t\tsizeof(struct ena_admin_rss_ind_table_entry);\n \n \trc = ena_com_get_feature_ex(ena_dev, &get_resp,\n", "prefixes": [ "v3", "05/22" ] }