Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9298/?format=api
{ "id": 9298, "url": "http://patches.dpdk.org/api/patches/9298/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1449150340-21984-4-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1449150340-21984-4-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1449150340-21984-4-git-send-email-thomas.monjalon@6wind.com", "date": "2015-12-03T13:45:30", "name": "[dpdk-dev,v3,03/13] mk: move installation procedure in install rule", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "79cfa17818cc151524e3ae81f7c833a861c48e89", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1449150340-21984-4-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/9298/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/9298/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0BE8C8E80;\n\tThu, 3 Dec 2015 14:47:04 +0100 (CET)", "from mail-wm0-f48.google.com (mail-wm0-f48.google.com\n\t[74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 3CF018E74\n\tfor <dev@dpdk.org>; Thu, 3 Dec 2015 14:47:01 +0100 (CET)", "by wmuu63 with SMTP id u63so21790077wmu.0\n\tfor <dev@dpdk.org>; Thu, 03 Dec 2015 05:47:01 -0800 (PST)", "from XPS13.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tk133sm8063912wmg.18.2015.12.03.05.46.59\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tThu, 03 Dec 2015 05:47:00 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=o6+ApiaVN09IIu9CeLM7pMjcOFqaS7EqXJyt4JQuXC0=;\n\tb=16PzTGdFT3L61RImQRtscNPOZSLZxnJBRNRxE1RUDzbjEiQCX6jXQgVZrzlatGv2qr\n\tdtczTT5RM3wPGFA5YgHDUacnhDkXLDKl7bSLT+K0k44CqY4cs8Ga4AIUrFGirwnrRT4R\n\t/74yipXZmZpGwmnbEgsAj5YPj9xtdI1MIJ5++DHQKGOKQW+6rlBeSOYt0ZK3Zzh72AaM\n\tYHhsawzyiM4YgQqTTe8PqiD/rsNB0F00T2XJBaHCpqAv4sVhkCqRTUiCuOghW+/C2NmC\n\t9c1veaRsTeZBYHcDx+9PnoIXxOq8cHaSg9NIhsSBfDhPSczlsU/kE2H7oT5UNt1zz94c\n\thHqQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=o6+ApiaVN09IIu9CeLM7pMjcOFqaS7EqXJyt4JQuXC0=;\n\tb=MI+rCcqb0YlYAfYtxkdPw8bZSGQn4EEZ54cr4jTY+UVLBi3Gj3wpQQLUoi2rcQIhOz\n\teZKN4tJrHtSn3Qz2AqLwNjEdlxsgT5IKyJlljt6syTm5PnXgSykdxsAZNOB1dcWgYc1X\n\t81r4mnrwhGz7w4SvLAMWCHkBh5dFD7zIM38IkFn78WAbhInf/SMgpu3M40kjJMMORI+e\n\t1LMfQrlHMUXh2oqmtSuAz/3Oq9rpp3i4CcrM0QhK9fjkqRPtqH0nHnUSqJbKXZYx3V+j\n\tQxAADZ7qXmxr2KkgrF5iAb2WA0aFsdu4YdKih/lGu5zUCsVfdUT4/l6UYvjvwgoKKvTM\n\tzdZg==", "X-Gm-Message-State": "ALoCoQl2g9SIKOuNlTN1zTvCF8DIjKd9204QgZwnrQ4Vhy3O8OFQuMOWesVVaoJkJQlnp7Fg3OUT", "X-Received": "by 10.28.4.212 with SMTP id 203mr53040176wme.89.1449150421077;\n\tThu, 03 Dec 2015 05:47:01 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Thu, 3 Dec 2015 14:45:30 +0100", "Message-Id": "<1449150340-21984-4-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.2", "In-Reply-To": "<1449150340-21984-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1449118929-19962-1-git-send-email-thomas.monjalon@6wind.com>\n\t<1449150340-21984-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH v3 03/13] mk: move installation procedure in\n\tinstall rule", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The real installation was called \"binary install\" and was done\nafter the build when DESTDIR was specified.\nRemove this limitation and move the code in install rule only.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\nAcked-by: Panu Matilainen <pmatilai@redhat.com>\n---\n mk/rte.sdkbuild.mk | 16 ----------------\n mk/rte.sdkinstall.mk | 21 ++++++++++++++++++---\n mk/rte.sdkroot.mk | 1 +\n 3 files changed, 19 insertions(+), 19 deletions(-)", "diff": "diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk\nindex 38ec7bd..85f603c 100644\n--- a/mk/rte.sdkbuild.mk\n+++ b/mk/rte.sdkbuild.mk\n@@ -29,8 +29,6 @@\n # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n \n-# If DESTDIR variable is given, install binary dpdk\n-\n #\n # include rte.vars.mk if config file exists\n #\n@@ -61,20 +59,6 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))\n .PHONY: build\n build: $(ROOTDIRS-y)\n \t@echo \"Build complete [$(RTE_TARGET)]\"\n-ifneq ($(DESTDIR),)\n-\t$(Q)mkdir -p $(DESTDIR)\n-\t$(Q)tar -C $(RTE_SDK) -cf - mk scripts/*.sh | tar -C $(DESTDIR) -x \\\n-\t --keep-newer-files --warning=no-ignore-newer -f -\n-\t$(Q)mkdir -p $(DESTDIR)/`basename $(RTE_OUTPUT)`\n-\t$(Q)tar -C $(RTE_OUTPUT) -chf - \\\n-\t --exclude app --exclude hostapp --exclude build \\\n-\t --exclude Makefile --exclude .depdirs . | \\\n-\t tar -C $(DESTDIR)/`basename $(RTE_OUTPUT)` -x --keep-newer-files \\\n-\t --warning=no-ignore-newer -f -\n-\t$(Q)install -D $(RTE_OUTPUT)/app/testpmd \\\n-\t $(DESTDIR)/`basename $(RTE_OUTPUT)`/app/testpmd\n-\t@echo Installation in $(DESTDIR) complete\n-endif\n \n .PHONY: clean\n clean: $(CLEANDIRS)\ndiff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk\nindex 0b80104..c5d0881 100644\n--- a/mk/rte.sdkinstall.mk\n+++ b/mk/rte.sdkinstall.mk\n@@ -36,9 +36,8 @@\n O ?= .\n RTE_OUTPUT := $O/$T\n \n-.PHONY: install\n-install:\n-\t@echo ================== Installing $T\n+.PHONY: pre_install\n+pre_install:\n \t$(Q)if [ ! -f $(RTE_OUTPUT)/.config ]; then \\\n \t\t$(MAKE) config O=$(RTE_OUTPUT); \\\n \telif cmp -s $(RTE_OUTPUT)/.config.orig $(RTE_OUTPUT)/.config; then \\\n@@ -55,3 +54,19 @@ install:\n \t\techo \"Using local configuration\"; \\\n \tfi\n \t$(Q)$(MAKE) all O=$(RTE_OUTPUT)\n+\n+.PHONY: install\n+install:\n+\t@echo ================== Installing $(DESTDIR)\n+\t$(Q)mkdir -p $(DESTDIR)\n+\t$(Q)tar -C $(RTE_SDK) -cf - mk scripts/*.sh | tar -C $(DESTDIR) -x \\\n+\t --keep-newer-files --warning=no-ignore-newer -f -\n+\t$(Q)mkdir -p $(DESTDIR)/$T\n+\t$(Q)tar -C $(RTE_OUTPUT) -chf - \\\n+\t --exclude app --exclude hostapp --exclude build \\\n+\t --exclude Makefile --exclude .depdirs . | \\\n+\t tar -C $(DESTDIR)/$T -x --keep-newer-files \\\n+\t --warning=no-ignore-newer -f -\n+\t$(Q)install -D $(RTE_OUTPUT)/app/testpmd \\\n+\t $(DESTDIR)/$T/app/testpmd\n+\t@echo Installation in $(DESTDIR) complete\ndiff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk\nindex 9fdecf4..533afe9 100644\n--- a/mk/rte.sdkroot.mk\n+++ b/mk/rte.sdkroot.mk\n@@ -95,6 +95,7 @@ test fast_test ring_test mempool_test perf_test coverage:\n \n .PHONY: install\n install:\n+\t$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkinstall.mk pre_install\n \t$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkinstall.mk $@\n \n .PHONY: doc help\n", "prefixes": [ "dpdk-dev", "v3", "03/13" ] }