Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9269/?format=api
{ "id": 9269, "url": "http://patches.dpdk.org/api/patches/9269/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1449118929-19962-4-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1449118929-19962-4-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1449118929-19962-4-git-send-email-thomas.monjalon@6wind.com", "date": "2015-12-03T05:02:00", "name": "[dpdk-dev,v2,03/12] mk: move installation procedure in install rule", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1a34c9272ead13507116a4d1b3004c3896260e90", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1449118929-19962-4-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/9269/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/9269/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B2AD18E7A;\n\tThu, 3 Dec 2015 06:03:31 +0100 (CET)", "from mail-wm0-f45.google.com (mail-wm0-f45.google.com\n\t[74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 776458E64\n\tfor <dev@dpdk.org>; Thu, 3 Dec 2015 06:03:29 +0100 (CET)", "by wmuu63 with SMTP id u63so5940470wmu.0\n\tfor <dev@dpdk.org>; Wed, 02 Dec 2015 21:03:29 -0800 (PST)", "from XPS13.ibrowse.com ([93.158.46.55])\n\tby smtp.gmail.com with ESMTPSA id\n\tgl4sm5720379wjd.17.2015.12.02.21.03.28\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tWed, 02 Dec 2015 21:03:28 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=843SDobx6xieu5rW3AlG0mT3khh/dhvaKmASkfu/VRA=;\n\tb=pixUy+HDTr8tfmkc3KxaKqoHtS7gKvcxumwsin0Id9ilkMzey5JP4fBVG2APZQ0Fac\n\tpV7V+x13n5gV6astPBed8vlEdBNEOJSZvbtJ0r1pIrMJ0cJ9pAvW0mRykf1UaBerXh87\n\tzU5H69TqByOf0H1xEewwa8NHiU0cMitaru50JLOaErhlcbVGZd45QMf21xLlfWfR2Wth\n\tHADrpSXVvlOPtkgKGiq2IoF/ccuVQaIf2DnrTmAsTMa87WaRzdQE12UIxwx2bZXnJFkf\n\tLCK8+p+zBB8BXddzuOb1qEiG5SjUynKBEB0FqT9BBsRrqTdXyxf7u2oInXK2iK6BAGgs\n\tqUBg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=843SDobx6xieu5rW3AlG0mT3khh/dhvaKmASkfu/VRA=;\n\tb=Uqm94fC4AjQ580tKFl2FRfcKIHEIU5p9p2uKVeh7FdYeeQUcUtrhxCZfXz1lk+MZVf\n\tsqQsQpeCP+yFb7RerinSlznUwhQ18MfQ03+mog/YGg0SgedDidHp530eFOFEiVr/qTcu\n\t3ZnTdQIGXgufHw85BsqBny7bKgncfNDWxh5qpbtBmLxTkaBuKclSDaeizCsO3mf756v6\n\tcwlHw9T2VHDU1+mvjpR7CKdfeIIYzPRbPhqi9bGIJ/ilcqRyYx2HnhMK75FU8WWGSI5i\n\teKM62H15bwr1RlJqRns3ZsIYOnWZoX/bZl6Klpym0bxw9AKjPI59sZ3kkmPsY8WZQAWF\n\tNkyA==", "X-Gm-Message-State": "ALoCoQnsJZIBI0An1i/OFMxCDQKdTbO4D09YCjbUSK14tpfW+BhYStwUrY9q3NjpprOEkq9J8G0I", "X-Received": "by 10.28.16.133 with SMTP id 127mr49962405wmq.24.1449119009339; \n\tWed, 02 Dec 2015 21:03:29 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Thu, 3 Dec 2015 06:02:00 +0100", "Message-Id": "<1449118929-19962-4-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.2", "In-Reply-To": "<1449118929-19962-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com>\n\t<1449118929-19962-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 03/12] mk: move installation procedure in\n\tinstall rule", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The real installation was called \"binary install\" and was done\nafter the build when DESTDIR was specified.\nRemove this limitation and move the code in install rule only.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n mk/rte.sdkbuild.mk | 16 ----------------\n mk/rte.sdkinstall.mk | 21 ++++++++++++++++++---\n 2 files changed, 18 insertions(+), 19 deletions(-)", "diff": "diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk\nindex 38ec7bd..85f603c 100644\n--- a/mk/rte.sdkbuild.mk\n+++ b/mk/rte.sdkbuild.mk\n@@ -29,8 +29,6 @@\n # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n \n-# If DESTDIR variable is given, install binary dpdk\n-\n #\n # include rte.vars.mk if config file exists\n #\n@@ -61,20 +59,6 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))\n .PHONY: build\n build: $(ROOTDIRS-y)\n \t@echo \"Build complete [$(RTE_TARGET)]\"\n-ifneq ($(DESTDIR),)\n-\t$(Q)mkdir -p $(DESTDIR)\n-\t$(Q)tar -C $(RTE_SDK) -cf - mk scripts/*.sh | tar -C $(DESTDIR) -x \\\n-\t --keep-newer-files --warning=no-ignore-newer -f -\n-\t$(Q)mkdir -p $(DESTDIR)/`basename $(RTE_OUTPUT)`\n-\t$(Q)tar -C $(RTE_OUTPUT) -chf - \\\n-\t --exclude app --exclude hostapp --exclude build \\\n-\t --exclude Makefile --exclude .depdirs . | \\\n-\t tar -C $(DESTDIR)/`basename $(RTE_OUTPUT)` -x --keep-newer-files \\\n-\t --warning=no-ignore-newer -f -\n-\t$(Q)install -D $(RTE_OUTPUT)/app/testpmd \\\n-\t $(DESTDIR)/`basename $(RTE_OUTPUT)`/app/testpmd\n-\t@echo Installation in $(DESTDIR) complete\n-endif\n \n .PHONY: clean\n clean: $(CLEANDIRS)\ndiff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk\nindex 3e6e8ca..54ea501 100644\n--- a/mk/rte.sdkinstall.mk\n+++ b/mk/rte.sdkinstall.mk\n@@ -36,9 +36,8 @@\n O ?= .\n BUILD_DIR := $O/$T\n \n-.PHONY: install\n-install:\n-\t@echo ================== Installing $T\n+.PHONY: pre_install\n+pre_install:\n \t$(Q)if [ ! -f $(BUILD_DIR)/.config ]; then \\\n \t\t$(MAKE) config T=$T O=$(BUILD_DIR); \\\n \telif cmp -s $(BUILD_DIR)/.config.orig $(BUILD_DIR)/.config; then \\\n@@ -55,3 +54,19 @@ install:\n \t\techo \"Using local configuration\"; \\\n \tfi\n \t$(Q)$(MAKE) all O=$(BUILD_DIR)\n+\n+.PHONY: install\n+install: pre_install\n+\t@echo ================== Installing $(DESTDIR)\n+\t$(Q)mkdir -p $(DESTDIR)\n+\t$(Q)tar -C $(RTE_SDK) -cf - mk scripts/*.sh | tar -C $(DESTDIR) -x \\\n+\t --keep-newer-files --warning=no-ignore-newer -f -\n+\t$(Q)mkdir -p $(DESTDIR)/$T\n+\t$(Q)tar -C $(BUILD_DIR) -chf - \\\n+\t --exclude app --exclude hostapp --exclude build \\\n+\t --exclude Makefile --exclude .depdirs . | \\\n+\t tar -C $(DESTDIR)/$T -x --keep-newer-files \\\n+\t --warning=no-ignore-newer -f -\n+\t$(Q)install -D $(BUILD_DIR)/app/testpmd \\\n+\t $(DESTDIR)/$T/app/testpmd\n+\t@echo Installation in $(DESTDIR) complete\n", "prefixes": [ "dpdk-dev", "v2", "03/12" ] }