Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92460/?format=api
{ "id": 92460, "url": "http://patches.dpdk.org/api/patches/92460/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1619764130-57208-2-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1619764130-57208-2-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1619764130-57208-2-git-send-email-humin29@huawei.com", "date": "2021-04-30T06:28:45", "name": "[v3,1/6] net/hns3: delete some unused capabilities", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "18eb62f54246db7762588fb5b0ed9e2f671ea569", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1619764130-57208-2-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16768, "url": "http://patches.dpdk.org/api/series/16768/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16768", "date": "2021-04-30T06:28:46", "name": "optimization and bugfix for hns3 PMD", "version": 3, "mbox": "http://patches.dpdk.org/series/16768/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92460/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92460/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 550EEA0546;\n\tFri, 30 Apr 2021 08:28:59 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5CC5A41121;\n\tFri, 30 Apr 2021 08:28:50 +0200 (CEST)", "from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by mails.dpdk.org (Postfix) with ESMTP id D8E7540395\n for <dev@dpdk.org>; Fri, 30 Apr 2021 08:28:46 +0200 (CEST)", "from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58])\n by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FWj7B4jplzBtDL\n for <dev@dpdk.org>; Fri, 30 Apr 2021 14:26:14 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id\n 14.3.498.0; Fri, 30 Apr 2021 14:28:43 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Fri, 30 Apr 2021 14:28:45 +0800", "Message-ID": "<1619764130-57208-2-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1619764130-57208-1-git-send-email-humin29@huawei.com>", "References": "<1619408092-54050-1-git-send-email-humin29@huawei.com>\n <1619764130-57208-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v3 1/6] net/hns3: delete some unused capabilities", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nThis patch deletes some unused capabilities, include:\n1. Delete some unused firmware capabilities definition, which are:\nUDP_GSO, ATR, INT_QL, SIMPLE_BD, TX_PUSH, FEC and PAUSE.\n2. Delete some unused driver capabilities definition, which are:\nUDP_GSO, TX_PUSH.\n3. Also redefine HNS3_DEV_SUPPORT_* as enum type, and change some of\nthe values. Note: the HNS3_DEV_SUPPORT_* values is used only inside\nthe driver, so it's safe to change the values.\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_cmd.c | 11 -----------\n drivers/net/hns3/hns3_cmd.h | 17 +++++++----------\n drivers/net/hns3/hns3_ethdev.h | 29 +++++++++++------------------\n 3 files changed, 18 insertions(+), 39 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_cmd.c b/drivers/net/hns3/hns3_cmd.c\nindex 5beb3d9..8ebe5e5 100644\n--- a/drivers/net/hns3/hns3_cmd.c\n+++ b/drivers/net/hns3/hns3_cmd.c\n@@ -419,21 +419,14 @@ hns3_get_caps_name(uint32_t caps_id)\n \t\tenum HNS3_CAPS_BITS caps;\n \t\tconst char *name;\n \t} dev_caps[] = {\n-\t\t{ HNS3_CAPS_UDP_GSO_B, \"udp_gso\" },\n-\t\t{ HNS3_CAPS_ATR_B, \"atr\" },\n \t\t{ HNS3_CAPS_FD_QUEUE_REGION_B, \"fd_queue_region\" },\n \t\t{ HNS3_CAPS_PTP_B, \"ptp\" },\n-\t\t{ HNS3_CAPS_INT_QL_B, \"int_ql\" },\n-\t\t{ HNS3_CAPS_SIMPLE_BD_B, \"simple_bd\" },\n-\t\t{ HNS3_CAPS_TX_PUSH_B, \"tx_push\" },\n \t\t{ HNS3_CAPS_PHY_IMP_B, \"phy_imp\" },\n \t\t{ HNS3_CAPS_TQP_TXRX_INDEP_B, \"tqp_txrx_indep\" },\n \t\t{ HNS3_CAPS_HW_PAD_B, \"hw_pad\" },\n \t\t{ HNS3_CAPS_STASH_B, \"stash\" },\n \t\t{ HNS3_CAPS_UDP_TUNNEL_CSUM_B, \"udp_tunnel_csum\" },\n \t\t{ HNS3_CAPS_RAS_IMP_B, \"ras_imp\" },\n-\t\t{ HNS3_CAPS_FEC_B, \"fec\" },\n-\t\t{ HNS3_CAPS_PAUSE_B, \"pause\" },\n \t\t{ HNS3_CAPS_RXD_ADV_LAYOUT_B, \"rxd_adv_layout\" }\n \t};\n \tuint32_t i;\n@@ -480,8 +473,6 @@ hns3_parse_capability(struct hns3_hw *hw,\n {\n \tuint32_t caps = rte_le_to_cpu_32(cmd->caps[0]);\n \n-\tif (hns3_get_bit(caps, HNS3_CAPS_UDP_GSO_B))\n-\t\thns3_set_bit(hw->capability, HNS3_DEV_SUPPORT_UDP_GSO_B, 1);\n \tif (hns3_get_bit(caps, HNS3_CAPS_FD_QUEUE_REGION_B))\n \t\thns3_set_bit(hw->capability, HNS3_DEV_SUPPORT_FD_QUEUE_REGION_B,\n \t\t\t 1);\n@@ -498,8 +489,6 @@ hns3_parse_capability(struct hns3_hw *hw,\n \t\t\thns3_warn(hw, \"ignore PTP capability due to lack of \"\n \t\t\t\t \"rxd advanced layout capability.\");\n \t}\n-\tif (hns3_get_bit(caps, HNS3_CAPS_TX_PUSH_B))\n-\t\thns3_set_bit(hw->capability, HNS3_DEV_SUPPORT_TX_PUSH_B, 1);\n \tif (hns3_get_bit(caps, HNS3_CAPS_PHY_IMP_B))\n \t\thns3_set_bit(hw->capability, HNS3_DEV_SUPPORT_COPPER_B, 1);\n \tif (hns3_get_bit(caps, HNS3_CAPS_TQP_TXRX_INDEP_B))\ndiff --git a/drivers/net/hns3/hns3_cmd.h b/drivers/net/hns3/hns3_cmd.h\nindex bf1772d..944e3d6 100644\n--- a/drivers/net/hns3/hns3_cmd.h\n+++ b/drivers/net/hns3/hns3_cmd.h\n@@ -306,22 +306,19 @@ struct hns3_rx_priv_buff_cmd {\n #define HNS3_FW_VERSION_BYTE0_M\t\tGENMASK(7, 0)\n \n enum HNS3_CAPS_BITS {\n-\tHNS3_CAPS_UDP_GSO_B,\n-\tHNS3_CAPS_ATR_B,\n-\tHNS3_CAPS_FD_QUEUE_REGION_B,\n+\t/*\n+\t * The following capability index definitions must be the same as those\n+\t * of the firmware.\n+\t */\n+\tHNS3_CAPS_FD_QUEUE_REGION_B = 2,\n \tHNS3_CAPS_PTP_B,\n-\tHNS3_CAPS_INT_QL_B,\n-\tHNS3_CAPS_SIMPLE_BD_B,\n-\tHNS3_CAPS_TX_PUSH_B,\n-\tHNS3_CAPS_PHY_IMP_B,\n+\tHNS3_CAPS_PHY_IMP_B = 7,\n \tHNS3_CAPS_TQP_TXRX_INDEP_B,\n \tHNS3_CAPS_HW_PAD_B,\n \tHNS3_CAPS_STASH_B,\n \tHNS3_CAPS_UDP_TUNNEL_CSUM_B,\n \tHNS3_CAPS_RAS_IMP_B,\n-\tHNS3_CAPS_FEC_B,\n-\tHNS3_CAPS_PAUSE_B,\n-\tHNS3_CAPS_RXD_ADV_LAYOUT_B,\n+\tHNS3_CAPS_RXD_ADV_LAYOUT_B = 15,\n };\n \n enum HNS3_API_CAP_BITS {\ndiff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h\nindex b2dacb9..608fd0c 100644\n--- a/drivers/net/hns3/hns3_ethdev.h\n+++ b/drivers/net/hns3/hns3_ethdev.h\n@@ -858,17 +858,17 @@ enum {\n \n #define HNS3_DEVARG_DEV_CAPS_MASK\t\"dev_caps_mask\"\n \n-#define HNS3_DEV_SUPPORT_DCB_B\t\t\t0x0\n-#define HNS3_DEV_SUPPORT_COPPER_B\t\t0x1\n-#define HNS3_DEV_SUPPORT_UDP_GSO_B\t\t0x2\n-#define HNS3_DEV_SUPPORT_FD_QUEUE_REGION_B\t0x3\n-#define HNS3_DEV_SUPPORT_PTP_B\t\t\t0x4\n-#define HNS3_DEV_SUPPORT_TX_PUSH_B\t\t0x5\n-#define HNS3_DEV_SUPPORT_INDEP_TXRX_B\t\t0x6\n-#define HNS3_DEV_SUPPORT_STASH_B\t\t0x7\n-#define HNS3_DEV_SUPPORT_RXD_ADV_LAYOUT_B\t0x9\n-#define HNS3_DEV_SUPPORT_OUTER_UDP_CKSUM_B\t0xA\n-#define HNS3_DEV_SUPPORT_RAS_IMP_B\t\t0xB\n+enum {\n+\tHNS3_DEV_SUPPORT_DCB_B,\n+\tHNS3_DEV_SUPPORT_COPPER_B,\n+\tHNS3_DEV_SUPPORT_FD_QUEUE_REGION_B,\n+\tHNS3_DEV_SUPPORT_PTP_B,\n+\tHNS3_DEV_SUPPORT_INDEP_TXRX_B,\n+\tHNS3_DEV_SUPPORT_STASH_B,\n+\tHNS3_DEV_SUPPORT_RXD_ADV_LAYOUT_B,\n+\tHNS3_DEV_SUPPORT_OUTER_UDP_CKSUM_B,\n+\tHNS3_DEV_SUPPORT_RAS_IMP_B,\n+};\n \n #define hns3_dev_dcb_supported(hw) \\\n \thns3_get_bit((hw)->capability, HNS3_DEV_SUPPORT_DCB_B)\n@@ -877,10 +877,6 @@ enum {\n #define hns3_dev_copper_supported(hw) \\\n \thns3_get_bit((hw)->capability, HNS3_DEV_SUPPORT_COPPER_B)\n \n-/* Support UDP GSO offload */\n-#define hns3_dev_udp_gso_supported(hw) \\\n-\thns3_get_bit((hw)->capability, HNS3_DEV_SUPPORT_UDP_GSO_B)\n-\n /* Support the queue region action rule of flow directory */\n #define hns3_dev_fd_queue_region_supported(hw) \\\n \thns3_get_bit((hw)->capability, HNS3_DEV_SUPPORT_FD_QUEUE_REGION_B)\n@@ -889,9 +885,6 @@ enum {\n #define hns3_dev_ptp_supported(hw) \\\n \thns3_get_bit((hw)->capability, HNS3_DEV_SUPPORT_PTP_B)\n \n-#define hns3_dev_tx_push_supported(hw) \\\n-\thns3_get_bit((hw)->capability, HNS3_DEV_SUPPORT_TX_PUSH_B)\n-\n /* Support to Independently enable/disable/reset Tx or Rx queues */\n #define hns3_dev_indep_txrx_supported(hw) \\\n \thns3_get_bit((hw)->capability, HNS3_DEV_SUPPORT_INDEP_TXRX_B)\n", "prefixes": [ "v3", "1/6" ] }