Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92315/?format=api
{ "id": 92315, "url": "http://patches.dpdk.org/api/patches/92315/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1619599019-46246-3-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1619599019-46246-3-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1619599019-46246-3-git-send-email-humin29@huawei.com", "date": "2021-04-28T08:36:59", "name": "[v2,2/2] app/testpmd: fix link speed for a specified port", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1e64413c242223206da8188a2248262e3cce5a65", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1619599019-46246-3-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16713, "url": "http://patches.dpdk.org/api/series/16713/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16713", "date": "2021-04-28T08:36:59", "name": "fixes for link speed", "version": 2, "mbox": "http://patches.dpdk.org/series/16713/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92315/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92315/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E36CCA0A0E;\n\tWed, 28 Apr 2021 10:36:59 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A98AA4014E;\n\tWed, 28 Apr 2021 10:36:59 +0200 (CEST)", "from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32])\n by mails.dpdk.org (Postfix) with ESMTP id 3480E40147\n for <dev@dpdk.org>; Wed, 28 Apr 2021 10:36:57 +0200 (CEST)", "from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FVX4Y5wZYzlYM5\n for <dev@dpdk.org>; Wed, 28 Apr 2021 16:34:53 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id\n 14.3.498.0; Wed, 28 Apr 2021 16:36:50 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <xiaoyun.li@intel.com>", "Date": "Wed, 28 Apr 2021 16:36:59 +0800", "Message-ID": "<1619599019-46246-3-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1619599019-46246-1-git-send-email-humin29@huawei.com>", "References": "<1618813303-32945-1-git-send-email-humin29@huawei.com>\n <1619599019-46246-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v2 2/2] app/testpmd: fix link speed for a\n specified port", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nWhen we use the following cmd to modify the link speed of specified\nport: \"port config <port_id> speed xxx duplex xxx\", we have to stop\nall ports. It's not necessary.\n\nFixes: 82113036e4e5 (\"ethdev: redesign link speed config\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n app/test-pmd/cmdline.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex ddbc629..6d80d98 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -1649,13 +1649,13 @@ cmd_config_speed_specific_parsed(void *parsed_result,\n \tuint32_t link_speed;\n \tint ret;\n \n-\tif (!all_ports_stopped()) {\n-\t\tprintf(\"Please stop all ports first\\n\");\n+\tif (port_id_is_invalid(res->id, ENABLED_WARN))\n \t\treturn;\n-\t}\n \n-\tif (port_id_is_invalid(res->id, ENABLED_WARN))\n+\tif (!port_is_stopped(res->id)) {\n+\t\tprintf(\"Please stop port %d first\\n\", res->id);\n \t\treturn;\n+\t}\n \n \tif (parse_and_check_speed_duplex(res->value1, res->value2,\n \t\t\t&link_speed) < 0)\n", "prefixes": [ "v2", "2/2" ] }