Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92302/?format=api
{ "id": 92302, "url": "http://patches.dpdk.org/api/patches/92302/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1619592046-22269-6-git-send-email-lihuisong@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1619592046-22269-6-git-send-email-lihuisong@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1619592046-22269-6-git-send-email-lihuisong@huawei.com", "date": "2021-04-28T06:40:44", "name": "[V4,5/7] app/testpmd: move position of verifying DCB test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "18a6d032d5621327861a814ee9650acb00d34023", "submitter": { "id": 2085, "url": "http://patches.dpdk.org/api/people/2085/?format=api", "name": "lihuisong (C)", "email": "lihuisong@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1619592046-22269-6-git-send-email-lihuisong@huawei.com/mbox/", "series": [ { "id": 16709, "url": "http://patches.dpdk.org/api/series/16709/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16709", "date": "2021-04-28T06:40:39", "name": "modifications about DCB forwarding configuration", "version": 4, "mbox": "http://patches.dpdk.org/series/16709/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92302/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92302/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AA894A0A0E;\n\tWed, 28 Apr 2021 08:41:12 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0DE3F41293;\n\tWed, 28 Apr 2021 08:40:52 +0200 (CEST)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id BE18A410EB\n for <dev@dpdk.org>; Wed, 28 Apr 2021 08:40:45 +0200 (CEST)", "from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FVTTC74DTzPtwc\n for <dev@dpdk.org>; Wed, 28 Apr 2021 14:37:35 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id\n 14.3.498.0; Wed, 28 Apr 2021 14:40:41 +0800" ], "From": "Huisong Li <lihuisong@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <xiaoyun.li@intel.com>", "Date": "Wed, 28 Apr 2021 14:40:44 +0800", "Message-ID": "<1619592046-22269-6-git-send-email-lihuisong@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1619592046-22269-1-git-send-email-lihuisong@huawei.com>", "References": "<1614939741-63927-1-git-send-email-oulijun@huawei.com>\n <1619592046-22269-1-git-send-email-lihuisong@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH V4 5/7] app/testpmd: move position of verifying\n DCB test", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, the check for doing DCB test is assigned to\nstart_packet_forwarding(), which will be called when\nrun \"start\" cmd. But fwd_config_setup() is used in many\nscenarios, such as, \"port config all rxq\".\n\nThis patch moves the check from start_packet_forwarding()\nto fwd_config_setup().\n\nFixes: 7741e4cf16c0 (\"app/testpmd: VMDq and DCB updates\")\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\n app/test-pmd/config.c | 23 +++++++++++++++++++++--\n app/test-pmd/testpmd.c | 19 -------------------\n 2 files changed, 21 insertions(+), 21 deletions(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex bbf039d..fc057e5 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -3199,6 +3199,10 @@ icmp_echo_config_setup(void)\n void\n fwd_config_setup(void)\n {\n+\tstruct rte_port *port;\n+\tportid_t pt_id;\n+\tunsigned int i;\n+\n \tcur_fwd_config.fwd_eng = cur_fwd_eng;\n \tif (strcmp(cur_fwd_eng->fwd_mode_name, \"icmpecho\") == 0) {\n \t\ticmp_echo_config_setup();\n@@ -3206,9 +3210,24 @@ fwd_config_setup(void)\n \t}\n \n \tif ((nb_rxq > 1) && (nb_txq > 1)){\n-\t\tif (dcb_config)\n+\t\tif (dcb_config) {\n+\t\t\tfor (i = 0; i < nb_fwd_ports; i++) {\n+\t\t\t\tpt_id = fwd_ports_ids[i];\n+\t\t\t\tport = &ports[pt_id];\n+\t\t\t\tif (!port->dcb_flag) {\n+\t\t\t\t\tprintf(\"In DCB mode, all forwarding ports must \"\n+\t\t\t\t\t\t\"be configured in this mode.\\n\");\n+\t\t\t\t\treturn;\n+\t\t\t\t}\n+\t\t\t}\n+\t\t\tif (nb_fwd_lcores == 1) {\n+\t\t\t\tprintf(\"In DCB mode,the nb forwarding cores \"\n+\t\t\t\t\t\"should be larger than 1.\\n\");\n+\t\t\t\treturn;\n+\t\t\t}\n+\n \t\t\tdcb_fwd_config_setup();\n-\t\telse\n+\t\t} else\n \t\t\trss_fwd_config_setup();\n \t}\n \telse\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex a076b1d..abcbdaa 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2138,9 +2138,7 @@ start_packet_forwarding(int with_tx_first)\n {\n \tport_fwd_begin_t port_fwd_begin;\n \tport_fwd_end_t port_fwd_end;\n-\tstruct rte_port *port;\n \tunsigned int i;\n-\tportid_t pt_id;\n \n \tif (strcmp(cur_fwd_eng->fwd_mode_name, \"rxonly\") == 0 && !nb_rxq)\n \t\trte_exit(EXIT_FAILURE, \"rxq are 0, cannot use rxonly fwd mode\\n\");\n@@ -2163,23 +2161,6 @@ start_packet_forwarding(int with_tx_first)\n \t\tprintf(\"Packet forwarding already started\\n\");\n \t\treturn;\n \t}\n-\n-\tif (dcb_config) {\n-\t\tfor (i = 0; i < nb_fwd_ports; i++) {\n-\t\t\tpt_id = fwd_ports_ids[i];\n-\t\t\tport = &ports[pt_id];\n-\t\t\tif (!port->dcb_flag) {\n-\t\t\t\tprintf(\"In DCB mode, all forwarding ports must \"\n- \"be configured in this mode.\\n\");\n-\t\t\t\treturn;\n-\t\t\t}\n-\t\t}\n-\t\tif (nb_fwd_lcores == 1) {\n-\t\t\tprintf(\"In DCB mode,the nb forwarding cores \"\n- \"should be larger than 1.\\n\");\n-\t\t\treturn;\n-\t\t}\n-\t}\n \ttest_done = 0;\n \n \tfwd_config_setup();\n", "prefixes": [ "V4", "5/7" ] }