Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 92223,
    "url": "http://patches.dpdk.org/api/patches/92223/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1619489325-31820-1-git-send-email-humin29@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1619489325-31820-1-git-send-email-humin29@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1619489325-31820-1-git-send-email-humin29@huawei.com",
    "date": "2021-04-27T02:08:45",
    "name": "[v2] net/kni: fix rewritten return value",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "9a253cbacc69f5656670248e516087f32c4dbe7e",
    "submitter": {
        "id": 1944,
        "url": "http://patches.dpdk.org/api/people/1944/?format=api",
        "name": "humin (Q)",
        "email": "humin29@huawei.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1619489325-31820-1-git-send-email-humin29@huawei.com/mbox/",
    "series": [
        {
            "id": 16686,
            "url": "http://patches.dpdk.org/api/series/16686/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16686",
            "date": "2021-04-27T02:08:45",
            "name": "[v2] net/kni: fix rewritten return value",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/16686/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/92223/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/92223/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 804FDA0548;\n\tTue, 27 Apr 2021 04:08:43 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F0B0840143;\n\tTue, 27 Apr 2021 04:08:42 +0200 (CEST)",
            "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by mails.dpdk.org (Postfix) with ESMTP id A53F94003E\n for <dev@dpdk.org>; Tue, 27 Apr 2021 04:08:41 +0200 (CEST)",
            "from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FTlVX3Sv3z17RV8\n for <dev@dpdk.org>; Tue, 27 Apr 2021 10:06:12 +0800 (CST)",
            "from localhost.localdomain (10.69.192.56) by\n DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id\n 14.3.498.0; Tue, 27 Apr 2021 10:08:34 +0800"
        ],
        "From": "\"Min Hu (Connor)\" <humin29@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<ferruh.yigit@intel.com>",
        "Date": "Tue, 27 Apr 2021 10:08:45 +0800",
        "Message-ID": "<1619489325-31820-1-git-send-email-humin29@huawei.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1619063789-60922-3-git-send-email-humin29@huawei.com>",
        "References": "<1619063789-60922-3-git-send-email-humin29@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.69.192.56]",
        "X-CFilter-Loop": "Reflected",
        "Subject": "[dpdk-dev] [PATCH v2] net/kni: fix rewritten return value",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Return value of function 'eth_kni_dev_stop' passed to 'ret' is\nrewritten later, and this is unreasonable.\n\nThis patch fixes it.\n\nFixes: 62024eb82756 (\"ethdev: change stop operation callback to return int\")\nCc: stable@dpdk.org\n\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\nv2:\n* just log but not return.\n---\n drivers/net/kni/rte_eth_kni.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c\nindex 9ce74e5..00f9e1b 100644\n--- a/drivers/net/kni/rte_eth_kni.c\n+++ b/drivers/net/kni/rte_eth_kni.c\n@@ -211,6 +211,9 @@ eth_kni_close(struct rte_eth_dev *eth_dev)\n \t\treturn 0;\n \n \tret = eth_kni_dev_stop(eth_dev);\n+\tif (ret)\n+\t\tPMD_LOG(WARNING, \"Not able to stop kni for %s\",\n+\t\t\teth_dev->data->name);\n \n \t/* mac_addrs must not be freed alone because part of dev_private */\n \teth_dev->data->mac_addrs = NULL;\n",
    "prefixes": [
        "v2"
    ]
}