Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92159/?format=api
{ "id": 92159, "url": "http://patches.dpdk.org/api/patches/92159/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210426095259.225354-8-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210426095259.225354-8-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210426095259.225354-8-bruce.richardson@intel.com", "date": "2021-04-26T09:52:54", "name": "[v2,07/12] raw/ioat: allow perform operations function to return error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1a67c5def4b7045ca630a0297cb7677233c9ac3f", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210426095259.225354-8-bruce.richardson@intel.com/mbox/", "series": [ { "id": 16669, "url": "http://patches.dpdk.org/api/series/16669/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16669", "date": "2021-04-26T09:52:48", "name": "ioat driver updates", "version": 2, "mbox": "http://patches.dpdk.org/series/16669/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92159/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92159/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7E753A0548;\n\tMon, 26 Apr 2021 11:54:00 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8341B411D0;\n\tMon, 26 Apr 2021 11:53:27 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 25A9D411B2\n for <dev@dpdk.org>; Mon, 26 Apr 2021 11:53:20 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Apr 2021 02:53:19 -0700", "from silpixa00399126.ir.intel.com ([10.237.223.81])\n by orsmga008.jf.intel.com with ESMTP; 26 Apr 2021 02:53:17 -0700" ], "IronPort-SDR": [ "\n vEua89YeOxqJ0wiRWqWprcmZ3BUJrjNGKATM1VoCCI2R9mVIcyz7E5RXY7SWq5SpAf7UqhPCLZ\n BVVS+eb7SmUA==", "\n zU9znVpLU8cIJGki6uLDWMoxbpa1kgRGxFMu2HChcD9ijtuHRmYasg0NnIOTyw5TAJV3YW29O1\n GQlHSI/ATEEw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9965\"; a=\"183442906\"", "E=Sophos;i=\"5.82,252,1613462400\"; d=\"scan'208\";a=\"183442906\"", "E=Sophos;i=\"5.82,252,1613462400\"; d=\"scan'208\";a=\"429336930\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "kevin.laatz@intel.com,\n\tjiayu.hu@intel.com", "Date": "Mon, 26 Apr 2021 10:52:54 +0100", "Message-Id": "<20210426095259.225354-8-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210426095259.225354-1-bruce.richardson@intel.com>", "References": "<20210318182042.43658-2-bruce.richardson@intel.com>\n <20210426095259.225354-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 07/12] raw/ioat: allow perform operations\n function to return error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kevin Laatz <kevin.laatz@intel.com>\n\nChange the return type for the rte_ioat_perform_ops() function from void to\nint to allow the possibility of returning an error code in future, should\nit be necessary.\n\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\n---\n drivers/raw/ioat/rte_ioat_rawdev.h | 4 +++-\n drivers/raw/ioat/rte_ioat_rawdev_fns.h | 11 +++++++----\n 2 files changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/raw/ioat/rte_ioat_rawdev.h b/drivers/raw/ioat/rte_ioat_rawdev.h\nindex f9e8425a7f..e5a22a0799 100644\n--- a/drivers/raw/ioat/rte_ioat_rawdev.h\n+++ b/drivers/raw/ioat/rte_ioat_rawdev.h\n@@ -124,8 +124,10 @@ rte_ioat_fence(int dev_id);\n *\n * @param dev_id\n * The rawdev device id of the ioat instance\n+ * @return\n+ * 0 on success. Non-zero return on error.\n */\n-static inline void\n+static inline int\n __rte_experimental\n rte_ioat_perform_ops(int dev_id);\n \ndiff --git a/drivers/raw/ioat/rte_ioat_rawdev_fns.h b/drivers/raw/ioat/rte_ioat_rawdev_fns.h\nindex e96edc9053..477c1b7b41 100644\n--- a/drivers/raw/ioat/rte_ioat_rawdev_fns.h\n+++ b/drivers/raw/ioat/rte_ioat_rawdev_fns.h\n@@ -291,7 +291,7 @@ __ioat_fence(int dev_id)\n /*\n * Trigger hardware to begin performing enqueued operations\n */\n-static __rte_always_inline void\n+static __rte_always_inline int\n __ioat_perform_ops(int dev_id)\n {\n \tstruct rte_ioat_rawdev *ioat =\n@@ -301,6 +301,8 @@ __ioat_perform_ops(int dev_id)\n \trte_compiler_barrier();\n \t*ioat->doorbell = ioat->next_write;\n \tioat->xstats.started = ioat->xstats.enqueued;\n+\n+\treturn 0;\n }\n \n /**\n@@ -462,7 +464,7 @@ __idxd_movdir64b(volatile void *dst, const void *src)\n \t\t\t: \"a\" (dst), \"d\" (src));\n }\n \n-static __rte_always_inline void\n+static __rte_always_inline int\n __idxd_perform_ops(int dev_id)\n {\n \tstruct rte_idxd_rawdev *idxd =\n@@ -470,7 +472,7 @@ __idxd_perform_ops(int dev_id)\n \tstruct rte_idxd_desc_batch *b = &idxd->batch_ring[idxd->next_batch];\n \n \tif (b->submitted || b->op_count == 0)\n-\t\treturn;\n+\t\treturn 0;\n \tb->hdl_end = idxd->next_free_hdl;\n \tb->comp.status = 0;\n \tb->submitted = 1;\n@@ -480,6 +482,7 @@ __idxd_perform_ops(int dev_id)\n \tif (++idxd->next_batch == idxd->batch_ring_sz)\n \t\tidxd->next_batch = 0;\n \tidxd->xstats.started = idxd->xstats.enqueued;\n+\treturn 0;\n }\n \n static __rte_always_inline int\n@@ -558,7 +561,7 @@ rte_ioat_fence(int dev_id)\n \t\treturn __ioat_fence(dev_id);\n }\n \n-static inline void\n+static inline int\n rte_ioat_perform_ops(int dev_id)\n {\n \tenum rte_ioat_dev_type *type =\n", "prefixes": [ "v2", "07/12" ] }