Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92125/?format=api
{ "id": 92125, "url": "http://patches.dpdk.org/api/patches/92125/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1619352389-42322-3-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1619352389-42322-3-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1619352389-42322-3-git-send-email-humin29@huawei.com", "date": "2021-04-25T12:06:29", "name": "[2/2] net/hns3: fix link speed when port is down", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6746d4da9bca3143e88277655995a7a012a2f403", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1619352389-42322-3-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16654, "url": "http://patches.dpdk.org/api/series/16654/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16654", "date": "2021-04-25T12:06:29", "name": "bugfix for link for hns3 PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/16654/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92125/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92125/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6B395A0548;\n\tSun, 25 Apr 2021 14:06:24 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D514241139;\n\tSun, 25 Apr 2021 14:06:23 +0200 (CEST)", "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by mails.dpdk.org (Postfix) with ESMTP id 578534110A\n for <dev@dpdk.org>; Sun, 25 Apr 2021 14:06:21 +0200 (CEST)", "from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FSmrM2h5DzpZmx\n for <dev@dpdk.org>; Sun, 25 Apr 2021 20:03:15 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id\n 14.3.498.0; Sun, 25 Apr 2021 20:06:19 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Sun, 25 Apr 2021 20:06:29 +0800", "Message-ID": "<1619352389-42322-3-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1619352389-42322-1-git-send-email-humin29@huawei.com>", "References": "<1619352389-42322-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 2/2] net/hns3: fix link speed when port is down", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nWhen the port is link down state, it is meaningless to display the\nport link speed. It should be an undefined state.\n\nFixes: 59fad0f32135 (\"net/hns3: support link update operation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 1496bb0..5f7b4ab 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -2867,16 +2867,18 @@ hns3_setup_linkstatus(struct rte_eth_dev *eth_dev,\n \tcase ETH_SPEED_NUM_50G:\n \tcase ETH_SPEED_NUM_100G:\n \tcase ETH_SPEED_NUM_200G:\n-\t\tnew_link->link_speed = mac->link_speed;\n+\t\tif (mac->link_status)\n+\t\t\tnew_link->link_speed = mac->link_speed;\n \t\tbreak;\n \tdefault:\n \t\tif (mac->link_status)\n \t\t\tnew_link->link_speed = ETH_SPEED_NUM_UNKNOWN;\n-\t\telse\n-\t\t\tnew_link->link_speed = ETH_SPEED_NUM_NONE;\n \t\tbreak;\n \t}\n \n+\tif (!mac->link_status)\n+\t\tnew_link->link_speed = ETH_SPEED_NUM_NONE;\n+\n \tnew_link->link_duplex = mac->link_duplex;\n \tnew_link->link_status = mac->link_status ? ETH_LINK_UP : ETH_LINK_DOWN;\n \tnew_link->link_autoneg = mac->link_autoneg;\n", "prefixes": [ "2/2" ] }