Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92122/?format=api
{ "id": 92122, "url": "http://patches.dpdk.org/api/patches/92122/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210425080347.20376-3-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210425080347.20376-3-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210425080347.20376-3-jiawenwu@trustnetic.com", "date": "2021-04-25T08:03:45", "name": "[2/4] net/txgbe: fix VF MTU limit setting", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0d26871551866d0ecfccbc12af8b0824246ade21", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210425080347.20376-3-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 16651, "url": "http://patches.dpdk.org/api/series/16651/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16651", "date": "2021-04-25T08:03:43", "name": "Fixes for txgbe", "version": 1, "mbox": "http://patches.dpdk.org/series/16651/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92122/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92122/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D4EE1A0548;\n\tSun, 25 Apr 2021 10:04:27 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 99DD241174;\n\tSun, 25 Apr 2021 10:04:08 +0200 (CEST)", "from smtpbgau2.qq.com (smtpbgau2.qq.com [54.206.34.216])\n by mails.dpdk.org (Postfix) with ESMTP id E04B141164\n for <dev@dpdk.org>; Sun, 25 Apr 2021 10:04:03 +0200 (CEST)", "from jiawenwu.trustnetic.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Sun, 25 Apr 2021 16:03:53 +0800 (CST)" ], "X-QQ-mid": "bizesmtp50t1619337833t34hq8w8", "X-QQ-SSF": "01400000002000D0E000B00A0000000", "X-QQ-FEAT": "O9RHVi+JMbIAYLB2iBF9zisaV+xvvYSw6w124N9wYeiLNnh3bcTgB6SsnWkfa\n 0thH5te3S0cMC1WWevbuxaC+8sjE8tF9v4gOwVsSB8QGjIMHcr3k4NzWVIYNvFv6SPH8FBr\n E+gWKuW6dwrT1iOuT9M5q0lR9M71drnJMdOUkjF7nHgtkvP11SzRCoVm1TJaXLlZqogGall\n YhmZ4oQEz2sIcfCXzrNx+EH3UzUBEP5AzGgoihhnsKBbLerIr9y+rivADAVBLsBXs0jxUEw\n s6aQaS9Bk38hdsPuqTlYHqF1qcFn2Yw3gTIWqLAOYuGEHTDXD4vSUcDQEauRTt/xq+6qXCg\n CDjfvv5FwRYifI4xUQ=", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>,\n\tstable@dpdk.org", "Date": "Sun, 25 Apr 2021 16:03:45 +0800", "Message-Id": "<20210425080347.20376-3-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20210425080347.20376-1-jiawenwu@trustnetic.com>", "References": "<20210425080347.20376-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign7", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH 2/4] net/txgbe: fix VF MTU limit setting", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix to set MTU bigger than mbuf size when device is stopped, scattered\nrx may be enabled in next starting, exempt from setting in EAL parameters.\n\nFixes: a2beaa4a769e (\"net/txgbe: support VF MTU update\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_ethdev_vf.c | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/txgbe/txgbe_ethdev_vf.c b/drivers/net/txgbe/txgbe_ethdev_vf.c\nindex 3a5123733e..5597968e18 100644\n--- a/drivers/net/txgbe/txgbe_ethdev_vf.c\n+++ b/drivers/net/txgbe/txgbe_ethdev_vf.c\n@@ -1115,7 +1115,7 @@ txgbevf_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)\n {\n \tstruct txgbe_hw *hw;\n \tuint32_t max_frame = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;\n-\tstruct rte_eth_rxmode *rx_conf = &dev->data->dev_conf.rxmode;\n+\tstruct rte_eth_dev_data *dev_data = dev->data;\n \n \thw = TXGBE_DEV_HW(dev);\n \n@@ -1123,13 +1123,15 @@ txgbevf_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)\n \t\t\tmax_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)\n \t\treturn -EINVAL;\n \n-\t/* refuse mtu that requires the support of scattered packets when this\n-\t * feature has not been enabled before.\n+\t/* If device is started, refuse mtu that requires the support of\n+\t * scattered packets when this feature has not been enabled before.\n \t */\n-\tif (!(rx_conf->offloads & DEV_RX_OFFLOAD_SCATTER) &&\n+\tif (dev_data->dev_started && !dev_data->scattered_rx &&\n \t (max_frame + 2 * TXGBE_VLAN_TAG_SIZE >\n-\t dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM))\n+\t dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM)) {\n+\t\tPMD_INIT_LOG(ERR, \"Stop port first.\");\n \t\treturn -EINVAL;\n+\t}\n \n \t/*\n \t * When supported by the underlying PF driver, use the TXGBE_VF_SET_MTU\n", "prefixes": [ "2/4" ] }