Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92120/?format=api
{ "id": 92120, "url": "http://patches.dpdk.org/api/patches/92120/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210425080347.20376-2-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210425080347.20376-2-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210425080347.20376-2-jiawenwu@trustnetic.com", "date": "2021-04-25T08:03:44", "name": "[1/4] net/txgbe: fix RSS in double VALN", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f5607a4a8e9526a2377403773fcc0755041b5827", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210425080347.20376-2-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 16651, "url": "http://patches.dpdk.org/api/series/16651/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16651", "date": "2021-04-25T08:03:43", "name": "Fixes for txgbe", "version": 1, "mbox": "http://patches.dpdk.org/series/16651/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92120/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92120/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E7C09A0548;\n\tSun, 25 Apr 2021 10:04:12 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A358341166;\n\tSun, 25 Apr 2021 10:04:04 +0200 (CEST)", "from smtpproxy21.qq.com (smtpbg702.qq.com [203.205.195.102])\n by mails.dpdk.org (Postfix) with ESMTP id 7DB2B4115E\n for <dev@dpdk.org>; Sun, 25 Apr 2021 10:04:00 +0200 (CEST)", "from jiawenwu.trustnetic.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Sun, 25 Apr 2021 16:03:51 +0800 (CST)" ], "X-QQ-mid": "bizesmtp50t1619337832t77g6hfh", "X-QQ-SSF": "01400000002000D0E000B00A0000000", "X-QQ-FEAT": "YYU12otdbFnlaYwKZKbwNSV+C+uEC57nGouAbdqECyAQE98S1BR2VfzrxrF2z\n mFsFX/ArYBQLhRHZpFHeh5wSbq44jG4wXgjCwpfVP2D8A3GgHmo0kUUjC/LNBsGGIDa6kXk\n 9UzKa8xdUbyf+Afm/o51LK2Qe8fpNL8DnljhOXjZcqzFrWtUqUDDZBw/6lIJdCqnBVFGTjK\n 6oeXw8bECsG1tMI1+Q6ylEpgpFsNnzdkdYoNkpsP1vqEiUVaMO+0T8L3VL2cY+qjTz5+76f\n Pvm3WRkyBNsdQZk/n/WlyBGGNvqLhqNu9YREBXxj403rOG4DS1cw2ofe1kL4DjY+a8P1IeR\n kWhfzVVJECYR1/exUE=", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>,\n\tstable@dpdk.org", "Date": "Sun, 25 Apr 2021 16:03:44 +0800", "Message-Id": "<20210425080347.20376-2-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20210425080347.20376-1-jiawenwu@trustnetic.com>", "References": "<20210425080347.20376-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign5", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH 1/4] net/txgbe: fix RSS in double VALN", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Regard QINQ as one case of extend VLAN, and always enable QINQ mode when\ndouble VLAN is set, to avoid RSS does not work for QINQ packets.\n\nFixes: 220b0e49bc47 (\"net/txgbe: support VLAN\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_ethdev.c | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex 97796f040b..87c041c2ec 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -1217,17 +1217,12 @@ static void\n txgbe_vlan_hw_extend_enable(struct rte_eth_dev *dev)\n {\n \tstruct txgbe_hw *hw = TXGBE_DEV_HW(dev);\n-\tstruct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;\n-\tstruct rte_eth_txmode *txmode = &dev->data->dev_conf.txmode;\n \tuint32_t ctrl;\n \n \tPMD_INIT_FUNC_TRACE();\n \n \tctrl = rd32(hw, TXGBE_PORTCTL);\n-\tctrl |= TXGBE_PORTCTL_VLANEXT;\n-\tif (rxmode->offloads & DEV_RX_OFFLOAD_QINQ_STRIP ||\n-\t txmode->offloads & DEV_TX_OFFLOAD_QINQ_INSERT)\n-\t\tctrl |= TXGBE_PORTCTL_QINQ;\n+\tctrl |= TXGBE_PORTCTL_VLANEXT | TXGBE_PORTCTL_QINQ;\n \twr32(hw, TXGBE_PORTCTL, ctrl);\n }\n \n@@ -1287,8 +1282,9 @@ txgbe_vlan_offload_config(struct rte_eth_dev *dev, int mask)\n \t\t\ttxgbe_vlan_hw_filter_disable(dev);\n \t}\n \n-\tif (mask & ETH_VLAN_EXTEND_MASK) {\n-\t\tif (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND)\n+\tif (mask & (ETH_VLAN_EXTEND_MASK | ETH_QINQ_STRIP_MASK)) {\n+\t\tif (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND ||\n+\t\t\trxmode->offloads & DEV_RX_OFFLOAD_QINQ_STRIP)\n \t\t\ttxgbe_vlan_hw_extend_enable(dev);\n \t\telse\n \t\t\ttxgbe_vlan_hw_extend_disable(dev);\n", "prefixes": [ "1/4" ] }