Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92115/?format=api
{ "id": 92115, "url": "http://patches.dpdk.org/api/patches/92115/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210425055653.1509261-3-ruifeng.wang@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210425055653.1509261-3-ruifeng.wang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210425055653.1509261-3-ruifeng.wang@arm.com", "date": "2021-04-25T05:56:53", "name": "[v3,2/2] ring: use wfe to wait for ring tail update on aarch64", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8d36ab53b3354beaf4424c40085801367598a68c", "submitter": { "id": 1198, "url": "http://patches.dpdk.org/api/people/1198/?format=api", "name": "Ruifeng Wang", "email": "ruifeng.wang@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210425055653.1509261-3-ruifeng.wang@arm.com/mbox/", "series": [ { "id": 16648, "url": "http://patches.dpdk.org/api/series/16648/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16648", "date": "2021-04-25T05:56:52", "name": "[v3,1/2] spinlock: use wfe to reduce contention on aarch64", "version": 3, "mbox": "http://patches.dpdk.org/series/16648/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92115/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92115/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D9FE5A0548;\n\tSun, 25 Apr 2021 07:57:48 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CAA574114E;\n\tSun, 25 Apr 2021 07:57:48 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id DF7124113E\n for <dev@dpdk.org>; Sun, 25 Apr 2021 07:57:47 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 717071FB;\n Sat, 24 Apr 2021 22:57:47 -0700 (PDT)", "from net-arm-n1amp-01.shanghai.arm.com\n (net-arm-n1amp-01.shanghai.arm.com [10.169.210.102])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 17BAD3F774;\n Sat, 24 Apr 2021 22:57:43 -0700 (PDT)" ], "From": "Ruifeng Wang <ruifeng.wang@arm.com>", "To": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>", "Cc": "dev@dpdk.org, david.marchand@redhat.com, thomas@monjalon.net,\n jerinj@marvell.com, nd@arm.com, ruifeng.wang@arm.com,\n Gavin Hu <gavin.hu@arm.com>, Steve Capper <steve.capper@arm.com>,\n Ola Liljedahl <ola.liljedahl@arm.com>", "Date": "Sun, 25 Apr 2021 05:56:53 +0000", "Message-Id": "<20210425055653.1509261-3-ruifeng.wang@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210425055653.1509261-1-ruifeng.wang@arm.com>", "References": "<20200424070741.16619-1-gavin.hu@arm.com>\n <20210425055653.1509261-1-ruifeng.wang@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 2/2] ring: use wfe to wait for ring tail\n update on aarch64", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Instead of polling for tail to be updated, use wfe instruction.\n\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Steve Capper <steve.capper@arm.com>\nReviewed-by: Ola Liljedahl <ola.liljedahl@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/ring/rte_ring_c11_pvt.h | 4 ++--\n lib/ring/rte_ring_generic_pvt.h | 3 +--\n 2 files changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/ring/rte_ring_c11_pvt.h b/lib/ring/rte_ring_c11_pvt.h\nindex 759192f4c4..37e0b2afd6 100644\n--- a/lib/ring/rte_ring_c11_pvt.h\n+++ b/lib/ring/rte_ring_c11_pvt.h\n@@ -2,6 +2,7 @@\n *\n * Copyright (c) 2017,2018 HXT-semitech Corporation.\n * Copyright (c) 2007-2009 Kip Macy kmacy@freebsd.org\n+ * Copyright (c) 2021 Arm Limited\n * All rights reserved.\n * Derived from FreeBSD's bufring.h\n * Used as BSD-3 Licensed with permission from Kip Macy.\n@@ -21,8 +22,7 @@ __rte_ring_update_tail(struct rte_ring_headtail *ht, uint32_t old_val,\n \t * we need to wait for them to complete\n \t */\n \tif (!single)\n-\t\twhile (unlikely(ht->tail != old_val))\n-\t\t\trte_pause();\n+\t\trte_wait_until_equal_32(&ht->tail, old_val, __ATOMIC_RELAXED);\n \n \t__atomic_store_n(&ht->tail, new_val, __ATOMIC_RELEASE);\n }\ndiff --git a/lib/ring/rte_ring_generic_pvt.h b/lib/ring/rte_ring_generic_pvt.h\nindex 532deb5e7a..c95ad7e12c 100644\n--- a/lib/ring/rte_ring_generic_pvt.h\n+++ b/lib/ring/rte_ring_generic_pvt.h\n@@ -23,8 +23,7 @@ __rte_ring_update_tail(struct rte_ring_headtail *ht, uint32_t old_val,\n \t * we need to wait for them to complete\n \t */\n \tif (!single)\n-\t\twhile (unlikely(ht->tail != old_val))\n-\t\t\trte_pause();\n+\t\trte_wait_until_equal_32(&ht->tail, old_val, __ATOMIC_RELAXED);\n \n \tht->tail = new_val;\n }\n", "prefixes": [ "v3", "2/2" ] }