Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92094/?format=api
{ "id": 92094, "url": "http://patches.dpdk.org/api/patches/92094/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210423210444.197230-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210423210444.197230-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20210423210444.197230-1-stephen@networkplumber.org", "date": "2021-04-23T21:04:44", "name": "net/bnxt: use bnxt_ prefix on global function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0b5e00b320f63e880b44c8be178b358bbc1213c2", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210423210444.197230-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 16640, "url": "http://patches.dpdk.org/api/series/16640/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16640", "date": "2021-04-23T21:04:44", "name": "net/bnxt: use bnxt_ prefix on global function", "version": 1, "mbox": "http://patches.dpdk.org/series/16640/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92094/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92094/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 02AA2A0548;\n\tFri, 23 Apr 2021 23:04:49 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CF385410E7;\n\tFri, 23 Apr 2021 23:04:49 +0200 (CEST)", "from mail-pj1-f50.google.com (mail-pj1-f50.google.com\n [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id CCFF5410E5\n for <dev@dpdk.org>; Fri, 23 Apr 2021 23:04:48 +0200 (CEST)", "by mail-pj1-f50.google.com with SMTP id lr7so7591584pjb.2\n for <dev@dpdk.org>; Fri, 23 Apr 2021 14:04:48 -0700 (PDT)", "from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44])\n by smtp.gmail.com with ESMTPSA id h18sm5563910pgj.51.2021.04.23.14.04.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 23 Apr 2021 14:04:46 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=jlV+5TxHk5f5zdJKEO2Yu7IxsfPBaKLdcKor2T7ytUs=;\n b=Y9ECPZVFGgWmtRzBdfFXX59/c6MmiyUVuNUjxGtY7h9kaY6sNplq7E5jtdp8xH1d0q\n QGxItcxvAL8abvdJlKrWOEJTTEce8ODiKyvI65sZmLgPK342B1dgAa3DM4z+LrlgVZCx\n jRQPrB8l7qWM80bc1knOz0zW+8SWSjLyQgnj1s9yYM9I1903rcUDWgAxk+cWKaLViVj8\n trA4Rv9oOc7OLDQyvo+vFteCZdRDS56XX7HQzpnkmFgAvwOtFbWFeQ2WtwcZl08CXElP\n WqTocIZ4Dj8FmYu3FG36l0W2vWah4/Rn2nNss7sSYsYk995iloHeodFL20i7I9D+/VUi\n 9LbA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=jlV+5TxHk5f5zdJKEO2Yu7IxsfPBaKLdcKor2T7ytUs=;\n b=o1m4LzY66TmW07Zg2ucb5eyGQ6sIEzW+3HRMTFVF4jUrfX9ekvLc330nwe55P7vs+i\n 1W8WGZYpgicGgzyPnVy9jn8TbwOO/qbcD4b0lSSIFryXBsNmnul3vJQC7sP/G/RaBp6Z\n 1YvsSpv3TerEECpDCYUpoWTcE0y9azm4pOeRco8IxbEIUBEGv3RKkdW9PA9yifNMe/Il\n xxLOQxzhoTrdJ5hJHf4Lu2vxGkg14WMrki8MBYLulEyW0c0mDiEtM+RuWIKZYQY6O5fo\n owO/Hfvlnx8W2Kzme6nuHqw3Hx70QRaFdWWMdPMWrOztkvnDtdgHMvyEMr5q9PsIZw03\n KFpA==", "X-Gm-Message-State": "AOAM530rh2LrVVWfg6VSsHqocRubo9h041CdDNlDFc8wYOJ4sAPpWYKG\n eeCKgMFqrdairii4KkcG9GOxBFt3/ILTyQ==", "X-Google-Smtp-Source": "\n ABdhPJzpf6/JmUotyqM6wBuCV4T+1/cgxQM8q5JG6EJxalCokPHBeIGxbCvX0gWnUQdMu1LWjFZuZA==", "X-Received": "by 2002:a17:90a:1610:: with SMTP id\n n16mr6523110pja.190.1619211887398;\n Fri, 23 Apr 2021 14:04:47 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "ajit.khaparde@broadcom.com, Stephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 23 Apr 2021 14:04:44 -0700", "Message-Id": "<20210423210444.197230-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/bnxt: use bnxt_ prefix on global function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When statically linked the function prandom_bytes is exposed\nand might conflict with something in application. All driver\nfunctions should use same prefix.\n\nFixes: 9738793f28ec (\"net/bnxt: add VNIC functions and structs\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/bnxt/bnxt_flow.c | 4 ++--\n drivers/net/bnxt/bnxt_vnic.c | 4 ++--\n drivers/net/bnxt/bnxt_vnic.h | 2 +-\n 3 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex e3906b47791b..844bf1520f50 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -1404,8 +1404,8 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\t\t\t/* If hash key has not been specified,\n \t\t\t\t * use random hash key.\n \t\t\t\t */\n-\t\t\t\tprandom_bytes(vnic->rss_hash_key,\n-\t\t\t\t\t HW_HASH_KEY_SIZE);\n+\t\t\t\tbnxt_prandom_bytes(vnic->rss_hash_key,\n+\t\t\t\t\t\t HW_HASH_KEY_SIZE);\n \t\t\t} else {\n \t\t\t\tif (rss->key_len > HW_HASH_KEY_SIZE)\n \t\t\t\t\tmemcpy(vnic->rss_hash_key,\ndiff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c\nindex 14ad33b4e86c..de5c14566deb 100644\n--- a/drivers/net/bnxt/bnxt_vnic.c\n+++ b/drivers/net/bnxt/bnxt_vnic.c\n@@ -16,7 +16,7 @@\n * VNIC Functions\n */\n \n-void prandom_bytes(void *dest_ptr, size_t len)\n+void bnxt_prandom_bytes(void *dest_ptr, size_t len)\n {\n \tchar *dest = (char *)dest_ptr;\n \tuint64_t rb;\n@@ -172,7 +172,7 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp)\n \t\t\t\tHW_HASH_KEY_SIZE);\n \t\tvnic->mc_list_dma_addr = vnic->rss_hash_key_dma_addr +\n \t\t\t\tHW_HASH_KEY_SIZE;\n-\t\tprandom_bytes(vnic->rss_hash_key, HW_HASH_KEY_SIZE);\n+\t\tbnxt_prandom_bytes(vnic->rss_hash_key, HW_HASH_KEY_SIZE);\n \t}\n \n \treturn 0;\ndiff --git a/drivers/net/bnxt/bnxt_vnic.h b/drivers/net/bnxt/bnxt_vnic.h\nindex 00a664c8b839..37b452f28170 100644\n--- a/drivers/net/bnxt/bnxt_vnic.h\n+++ b/drivers/net/bnxt/bnxt_vnic.h\n@@ -68,7 +68,7 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp);\n void bnxt_free_vnic_mem(struct bnxt *bp);\n int bnxt_alloc_vnic_mem(struct bnxt *bp);\n int bnxt_vnic_grp_alloc(struct bnxt *bp, struct bnxt_vnic_info *vnic);\n-void prandom_bytes(void *dest_ptr, size_t len);\n+void bnxt_prandom_bytes(void *dest_ptr, size_t len);\n uint16_t bnxt_rte_to_hwrm_hash_types(uint64_t rte_type);\n int bnxt_rte_to_hwrm_hash_level(struct bnxt *bp, uint64_t hash_f, uint32_t lvl);\n uint64_t bnxt_hwrm_to_rte_rss_level(struct bnxt *bp, uint32_t mode);\n", "prefixes": [] }