Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92061/?format=api
{ "id": 92061, "url": "http://patches.dpdk.org/api/patches/92061/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1619165562-50959-1-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1619165562-50959-1-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1619165562-50959-1-git-send-email-humin29@huawei.com", "date": "2021-04-23T08:12:42", "name": "kni: check code of allmulticast mode switch", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "086ab6bddf551a9a9f1d849fb92ebb441622a911", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1619165562-50959-1-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16624, "url": "http://patches.dpdk.org/api/series/16624/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16624", "date": "2021-04-23T08:12:42", "name": "kni: check code of allmulticast mode switch", "version": 1, "mbox": "http://patches.dpdk.org/series/16624/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92061/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92061/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7D24CA0548;\n\tFri, 23 Apr 2021 10:13:07 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 63C9D4067E;\n\tFri, 23 Apr 2021 10:13:07 +0200 (CEST)", "from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32])\n by mails.dpdk.org (Postfix) with ESMTP id CDE754014F\n for <dev@dpdk.org>; Fri, 23 Apr 2021 10:13:05 +0200 (CEST)", "from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58])\n by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FRRnM6qXTzlZHC;\n Fri, 23 Apr 2021 16:11:03 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id\n 14.3.498.0; Fri, 23 Apr 2021 16:12:30 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <thomas@monjalon.net>", "Date": "Fri, 23 Apr 2021 16:12:42 +0800", "Message-ID": "<1619165562-50959-1-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH] kni: check code of allmulticast mode switch", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nSome drivers may return errcode when switch allmulticast mode, so it's\nnecessary to check the return code.\n\nFixes: b34801d1aa2e (\"kni: support allmulticast mode set\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n lib/kni/rte_kni.c | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c\nindex 9dae6a8..aa9b5b7 100644\n--- a/lib/kni/rte_kni.c\n+++ b/lib/kni/rte_kni.c\n@@ -514,6 +514,8 @@ kni_config_promiscusity(uint16_t port_id, uint8_t to_on)\n static int\n kni_config_allmulticast(uint16_t port_id, uint8_t to_on)\n {\n+\tint ret;\n+\n \tif (!rte_eth_dev_is_valid_port(port_id)) {\n \t\tRTE_LOG(ERR, KNI, \"Invalid port id %d\\n\", port_id);\n \t\treturn -EINVAL;\n@@ -523,11 +525,16 @@ kni_config_allmulticast(uint16_t port_id, uint8_t to_on)\n \t\tport_id, to_on);\n \n \tif (to_on)\n-\t\trte_eth_allmulticast_enable(port_id);\n+\t\tret = rte_eth_allmulticast_enable(port_id);\n \telse\n-\t\trte_eth_allmulticast_disable(port_id);\n+\t\tret = rte_eth_allmulticast_disable(port_id);\n+\tif (ret != 0)\n+\t\tRTE_LOG(ERR, KNI,\n+\t\t\t\"Failed to %s allmulticast mode for port %u: %s\\n\",\n+\t\t\tto_on ? \"enable\" : \"disable\", port_id,\n+\t\t\trte_strerror(-ret));\n \n-\treturn 0;\n+\treturn ret;\n }\n \n int\n", "prefixes": [] }