Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92015/?format=api
{ "id": 92015, "url": "http://patches.dpdk.org/api/patches/92015/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1619090834-14643-2-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1619090834-14643-2-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1619090834-14643-2-git-send-email-humin29@huawei.com", "date": "2021-04-22T11:27:13", "name": "[1/2] net/tap: fix log loss when state fails to be restored", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "fb10c9165f85292c5c055da601d316b43156379c", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1619090834-14643-2-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16606, "url": "http://patches.dpdk.org/api/series/16606/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16606", "date": "2021-04-22T11:27:12", "name": "bugfix for tap device", "version": 1, "mbox": "http://patches.dpdk.org/series/16606/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/92015/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/92015/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 82100A09E4;\n\tThu, 22 Apr 2021 13:27:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 86C3641D2B;\n\tThu, 22 Apr 2021 13:27:12 +0200 (CEST)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id 59421406A3\n for <dev@dpdk.org>; Thu, 22 Apr 2021 13:27:08 +0200 (CEST)", "from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FQw6W4ZtnzPtFw\n for <dev@dpdk.org>; Thu, 22 Apr 2021 19:24:03 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id\n 14.3.498.0; Thu, 22 Apr 2021 19:27:01 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <keith.wiles@intel.com>", "Date": "Thu, 22 Apr 2021 19:27:13 +0800", "Message-ID": "<1619090834-14643-2-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1619090834-14643-1-git-send-email-humin29@huawei.com>", "References": "<1619090834-14643-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 1/2] net/tap: fix log loss when state fails to be\n restored", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengchang Tang <tangchengchang@huawei.com>\n\nAfter restoring the remote states, the return value of ioctl() is not\nchecked. Therefore, users cannot know whether the remote state is\nrestored successfully.\n\nThis patch add log for restoring failure.\n\nFixes: 4810d3af8343 (\"net/tap: restore state of remote device when closing\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengchang Tang <tangchengchang@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/tap/rte_eth_tap.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 68baa18..6007c78 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -1101,6 +1101,7 @@ tap_dev_close(struct rte_eth_dev *dev)\n \tstruct pmd_internals *internals = dev->data->dev_private;\n \tstruct pmd_process_private *process_private = dev->process_private;\n \tstruct rx_queue *rxq;\n+\tint ret;\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n \t\trte_free(dev->process_private);\n@@ -1133,8 +1134,11 @@ tap_dev_close(struct rte_eth_dev *dev)\n \n \tif (internals->remote_if_index) {\n \t\t/* Restore initial remote state */\n-\t\tioctl(internals->ioctl_sock, SIOCSIFFLAGS,\n+\t\tret = ioctl(internals->ioctl_sock, SIOCSIFFLAGS,\n \t\t\t\t&internals->remote_initial_flags);\n+\t\tif (ret)\n+\t\t\tTAP_LOG(ERR, \"restore remote state failed: %d\", ret);\n+\n \t}\n \n \trte_mempool_free(internals->gso_ctx_mp);\n", "prefixes": [ "1/2" ] }