Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91982/?format=api
{ "id": 91982, "url": "http://patches.dpdk.org/api/patches/91982/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1619056552-43937-3-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1619056552-43937-3-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1619056552-43937-3-git-send-email-humin29@huawei.com", "date": "2021-04-22T01:55:50", "name": "[2/4] net/hns3: fix PF miss link status notify message", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f935ccac709536d20c57d4612353367b3c770cfa", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1619056552-43937-3-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16583, "url": "http://patches.dpdk.org/api/series/16583/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16583", "date": "2021-04-22T01:55:49", "name": "bugfix for hns3 PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/16583/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/91982/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/91982/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 290F5A0547;\n\tThu, 22 Apr 2021 03:55:51 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0017341C28;\n\tThu, 22 Apr 2021 03:55:46 +0200 (CEST)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id 0345941C11\n for <dev@dpdk.org>; Thu, 22 Apr 2021 03:55:44 +0200 (CEST)", "from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FQgRF0CgVzPt8f\n for <dev@dpdk.org>; Thu, 22 Apr 2021 09:52:41 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id\n 14.3.498.0; Thu, 22 Apr 2021 09:55:41 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Thu, 22 Apr 2021 09:55:50 +0800", "Message-ID": "<1619056552-43937-3-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1619056552-43937-1-git-send-email-humin29@huawei.com>", "References": "<1619056552-43937-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 2/4] net/hns3: fix PF miss link status notify\n message", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nThe opcode of the link status notification message reported by the\nfirmware is zero, it will be filtered out because driver treats it as\nalready processed message. As a result, the PF can't update the link\nstatus in a timely manner.\n\nBecause only VF can set opcode to zero when process mailbox message,\nso we add a judgment to make sure the PF messages will not filter out.\n\nFixes: dbbbad23e380 (\"net/hns3: fix VF handling LSC event in secondary process\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_mbx.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c\nindex 3b35c02..ba04ac9 100644\n--- a/drivers/net/hns3/hns3_mbx.c\n+++ b/drivers/net/hns3/hns3_mbx.c\n@@ -438,16 +438,19 @@ hns3_handle_mbx_msg_out_intr(struct hns3_hw *hw)\n void\n hns3_dev_handle_mbx_msg(struct hns3_hw *hw)\n {\n+\tstruct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);\n \tstruct hns3_cmq_ring *crq = &hw->cmq.crq;\n \tstruct hns3_mbx_pf_to_vf_cmd *req;\n \tstruct hns3_cmd_desc *desc;\n+\tbool handle_out;\n \tuint8_t opcode;\n \tuint16_t flag;\n \n \trte_spinlock_lock(&hw->cmq.crq.lock);\n \n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY ||\n-\t !rte_thread_is_intr()) {\n+\thandle_out = (rte_eal_process_type() != RTE_PROC_PRIMARY ||\n+\t\t !rte_thread_is_intr()) && hns->is_vf;\n+\tif (handle_out) {\n \t\t/*\n \t\t * Currently, any threads in the primary and secondary processes\n \t\t * could send mailbox sync request, so it will need to process\n@@ -491,7 +494,8 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)\n \t\t\tcontinue;\n \t\t}\n \n-\t\tif (desc->opcode == 0) {\n+\t\thandle_out = hns->is_vf && desc->opcode == 0;\n+\t\tif (handle_out) {\n \t\t\t/* Message already processed by other thread */\n \t\t\tcrq->desc[crq->next_to_use].flag = 0;\n \t\t\thns3_mbx_ring_ptr_move_crq(crq);\n", "prefixes": [ "2/4" ] }