Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91895/?format=api
{ "id": 91895, "url": "http://patches.dpdk.org/api/patches/91895/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210421020830.4989-1-murphyx.yang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210421020830.4989-1-murphyx.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210421020830.4989-1-murphyx.yang@intel.com", "date": "2021-04-21T02:08:30", "name": "[v2] net/i40e: fix FDIR issue for common PCTYPEs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "45e1aa3882386628e04616507752a6d893d874b7", "submitter": { "id": 1986, "url": "http://patches.dpdk.org/api/people/1986/?format=api", "name": "Murphy Yang", "email": "murphyx.yang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210421020830.4989-1-murphyx.yang@intel.com/mbox/", "series": [ { "id": 16530, "url": "http://patches.dpdk.org/api/series/16530/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16530", "date": "2021-04-21T02:08:30", "name": "[v2] net/i40e: fix FDIR issue for common PCTYPEs", "version": 2, "mbox": "http://patches.dpdk.org/series/16530/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/91895/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/91895/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 51773A0547;\n\tWed, 21 Apr 2021 04:17:24 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CE70E418AA;\n\tWed, 21 Apr 2021 04:17:23 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 4D70041385\n for <dev@dpdk.org>; Wed, 21 Apr 2021 04:17:22 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Apr 2021 19:17:21 -0700", "from unknown (HELO intel-npg-odc-srv02.cd.intel.com)\n ([10.240.178.186])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Apr 2021 19:17:18 -0700" ], "IronPort-SDR": [ "\n rGXzMUHY99uREKdB9TXN4/jzaFwhr7rkJhJG6IXbZHUwN9AaPrF5bu2vlxFClhOG0peOQGYCQr\n WxEJSMb4JNvg==", "\n tojVDdP5jg83UPLmEyoo3Bdp5GkqDNI4g3mGjabOaYSBksBddJH/FsKJfwJP+SxqdvOQTnh2qW\n L2hHnsmDm8Wg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,9960\"; a=\"256939529\"", "E=Sophos;i=\"5.82,238,1613462400\"; d=\"scan'208\";a=\"256939529\"", "E=Sophos;i=\"5.82,238,1613462400\"; d=\"scan'208\";a=\"427332327\"" ], "From": "Murphy Yang <murphyx.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "qiming.yang@intel.com, jia.guo@intel.com, beilei.xing@intel.com,\n stevex.yang@intel.com, robinx.zhang@intel.com,\n Murphy Yang <murphyx.yang@intel.com>", "Date": "Wed, 21 Apr 2021 02:08:30 +0000", "Message-Id": "<20210421020830.4989-1-murphyx.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210416021955.9790-1-murphyx.yang@intel.com>", "References": "<20210416021955.9790-1-murphyx.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/i40e: fix FDIR issue for common PCTYPEs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, FDIR doesn't work for all common PCTYPEs, the root cause is\nthat input set is not configured.\n\nFixes: 4a072ad43442 (\"net/i40e: fix flow director config after flow validate\")\nSigned-off-by: Murphy Yang <murphyx.yang@intel.com>\n---\nv2:\n- tune the code and modify commit message\n drivers/net/i40e/i40e_fdir.c | 13 +++++++++----\n 1 file changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c\nindex da089baa4d..6b81e09db5 100644\n--- a/drivers/net/i40e/i40e_fdir.c\n+++ b/drivers/net/i40e/i40e_fdir.c\n@@ -1607,8 +1607,10 @@ i40e_flow_set_fdir_inset(struct i40e_pf *pf,\n \n \t/* Check if the configuration is conflicted */\n \tif (pf->fdir.inset_flag[pctype] &&\n-\t memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t)))\n-\t\treturn -1;\n+\t memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t))) {\n+\t\tPMD_DRV_LOG(ERR, \"Conflict with the first rule's input set.\");\n+\t\treturn -EINVAL;\n+\t}\n \n \tif (pf->fdir.inset_flag[pctype] &&\n \t !memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t)))\n@@ -1762,18 +1764,21 @@ i40e_flow_add_del_fdir_filter(struct rte_eth_dev *dev,\n \ti40e_fdir_filter_convert(filter, &check_filter);\n \n \tif (add) {\n-\t\tif (filter->input.flow_ext.is_flex_flow) {\n+\t\t/* configure the input set for common PCTYPEs*/\n+\t\tif (!filter->input.flow_ext.customized_pctype) {\n \t\t\tret = i40e_flow_set_fdir_inset(pf, pctype,\n \t\t\t\t\tfilter->input.flow_ext.input_set);\n \t\t\tif (ret == -1) {\n \t\t\t\tPMD_DRV_LOG(ERR, \"Conflict with the\"\n-\t\t\t\t\t \" first rule's input set.\");\n+\t\t\t\t\t\t \" first rule's input set.\");\n \t\t\t\treturn -EINVAL;\n \t\t\t} else if (ret == -EINVAL) {\n \t\t\t\tPMD_DRV_LOG(ERR, \"Invalid pattern mask.\");\n \t\t\t\treturn -EINVAL;\n \t\t\t}\n+\t\t}\n \n+\t\tif (filter->input.flow_ext.is_flex_flow) {\n \t\t\tfor (i = 0; i < filter->input.flow_ext.raw_id; i++) {\n \t\t\t\tlayer_idx = filter->input.flow_ext.layer_idx;\n \t\t\t\tfield_idx = layer_idx * I40E_MAX_FLXPLD_FIED + i;\n", "prefixes": [ "v2" ] }