Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91877/?format=api
{ "id": 91877, "url": "http://patches.dpdk.org/api/patches/91877/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210420130915.166692-1-ktraynor@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210420130915.166692-1-ktraynor@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210420130915.166692-1-ktraynor@redhat.com", "date": "2021-04-20T13:09:14", "name": "[1/2] app/test: fix clang 12 warning", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4e1bd93734ba5c5b4935b9ef07f047d1d709a662", "submitter": { "id": 598, "url": "http://patches.dpdk.org/api/people/598/?format=api", "name": "Kevin Traynor", "email": "ktraynor@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210420130915.166692-1-ktraynor@redhat.com/mbox/", "series": [ { "id": 16522, "url": "http://patches.dpdk.org/api/series/16522/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16522", "date": "2021-04-20T13:09:14", "name": "[1/2] app/test: fix clang 12 warning", "version": 1, "mbox": "http://patches.dpdk.org/series/16522/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/91877/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/91877/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 23BA0A0548;\n\tTue, 20 Apr 2021 15:09:44 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 061AB41749;\n\tTue, 20 Apr 2021 15:09:44 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id 8D0A741735\n for <dev@dpdk.org>; Tue, 20 Apr 2021 15:09:42 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-265-pQv8hqCBMp62lHiSvvMYZw-1; Tue, 20 Apr 2021 09:09:39 -0400", "from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com\n [10.5.11.12])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0E59779EC1;\n Tue, 20 Apr 2021 13:09:38 +0000 (UTC)", "from rh.Home (ovpn-112-162.ams2.redhat.com [10.36.112.162])\n by smtp.corp.redhat.com (Postfix) with ESMTP id DF54B610F1;\n Tue, 20 Apr 2021 13:09:36 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1618924181;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=KTf81cF2JQhSMMLFKxgp5p6uE6J6Q9i7n0JFQV5QtkQ=;\n b=fH0mlVfEabyLZ9CV0FYToEgovJsmMeCd8JPpF3K+iVf2tf8GEca4fsI6kXRXO8sUhyTFWJ\n CDRVjyUI6lUZZzQ8fru1+bPQyEgastum3dOX0L3N1BIjiehxUwTUvZeGCSOlhYKIE6tx5i\n Haj5qMHdnqnZJs72AOs8qrxbunetPDQ=", "X-MC-Unique": "pQv8hqCBMp62lHiSvvMYZw-1", "From": "Kevin Traynor <ktraynor@redhat.com>", "To": "dev@dpdk.org", "Cc": "Kevin Traynor <ktraynor@redhat.com>, Olivier Matz <olivier.matz@6wind.com>", "Date": "Tue, 20 Apr 2021 14:09:14 +0100", "Message-Id": "<20210420130915.166692-1-ktraynor@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 1/2] app/test: fix clang 12 warning", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "clang 12 gives a warning about string size. In this case it looks like\nit was unintentional to concatenate the strings. Separate with a comma.\n\n$ clang --version\nclang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)\n\n[2557/2719]\nCompiling C object app/test/dpdk-test.p/test_cmdline_ipaddr.c.o\n../app/test/test_cmdline_ipaddr.c:259:3: warning:\nsuspicious concatenation of string literals in an array initialization;\ndid you mean to separate the elements with a comma?\n[-Wstring-concatenation]\n\"random invalid text\",\n^\n../app/test/test_cmdline_ipaddr.c:258:3: note:\nplace parentheses around the string literal to silence warning\n\"1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234\"\n^\n\nSigned-off-by: Kevin Traynor <ktraynor@redhat.com>\n---\n app/test/test_cmdline_ipaddr.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/app/test/test_cmdline_ipaddr.c b/app/test/test_cmdline_ipaddr.c\nindex b3f50d80d2..2a1ee120fc 100644\n--- a/app/test/test_cmdline_ipaddr.c\n+++ b/app/test/test_cmdline_ipaddr.c\n@@ -256,5 +256,5 @@ const char * ipaddr_invalid_strs[] = {\n \n \t\t/* too long */\n-\t\t\"1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234\"\n+\t\t\"1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234\",\n \t\t\"random invalid text\",\n \t\t\"\",\n", "prefixes": [ "1/2" ] }