Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91755/?format=api
{ "id": 91755, "url": "http://patches.dpdk.org/api/patches/91755/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1618839289-33224-4-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618839289-33224-4-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618839289-33224-4-git-send-email-humin29@huawei.com", "date": "2021-04-19T13:34:42", "name": "[03/10] bus/dpaa: fix management command init calling", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "ae852507b032be3b9e9f480deb719a643f8831ba", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1618839289-33224-4-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16492, "url": "http://patches.dpdk.org/api/series/16492/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16492", "date": "2021-04-19T13:34:39", "name": "fixes for clean code", "version": 1, "mbox": "http://patches.dpdk.org/series/16492/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/91755/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/91755/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 53033A0524;\n\tMon, 19 Apr 2021 15:34:56 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D4933412F4;\n\tMon, 19 Apr 2021 15:34:51 +0200 (CEST)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id B1BE0412E6\n for <dev@dpdk.org>; Mon, 19 Apr 2021 15:34:49 +0200 (CEST)", "from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FP7622g50zqTg4;\n Mon, 19 Apr 2021 21:32:26 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id\n 14.3.498.0; Mon, 19 Apr 2021 21:34:38 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <cristian.dumitrescu@intel.com>,\n <jerinj@marvell.com>, <jianjay.zhou@huawei.com>, <jia.guo@intel.com>,\n <g.singh@nxp.com>, <andrew.rybchenko@oktetlabs.ru>, <hemant.agrawal@nxp.com>,\n <orika@nvidia.com>", "Date": "Mon, 19 Apr 2021 21:34:42 +0800", "Message-ID": "<1618839289-33224-4-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1618839289-33224-1-git-send-email-humin29@huawei.com>", "References": "<1618839289-33224-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 03/10] bus/dpaa: fix management command init\n calling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "'bm_mc_init' only return 0, but the function whicl calls int\ncheck the negative ret, and this is redundant.\n\nThis patch fixed it by not checking the return value.\n\nFixes: f38f61e982f8 (\"bus/dpaa: add BMAN hardware interfaces\")\nCc: stable@dpdk.org\n\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/bus/dpaa/base/qbman/bman.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/bus/dpaa/base/qbman/bman.c b/drivers/bus/dpaa/base/qbman/bman.c\nindex 8a62907..e1ba2a8 100644\n--- a/drivers/bus/dpaa/base/qbman/bman.c\n+++ b/drivers/bus/dpaa/base/qbman/bman.c\n@@ -70,10 +70,8 @@ struct bman_portal *bman_create_portal(struct bman_portal *portal,\n \t\tpr_err(\"Bman RCR initialisation failed\\n\");\n \t\treturn NULL;\n \t}\n-\tif (bm_mc_init(p)) {\n-\t\tpr_err(\"Bman MC initialisation failed\\n\");\n-\t\tgoto fail_mc;\n-\t}\n+\t(void)bm_mc_init(p);\n+\n \tportal->pools = kmalloc(2 * sizeof(*pools), GFP_KERNEL);\n \tif (!portal->pools)\n \t\tgoto fail_pools;\n", "prefixes": [ "03/10" ] }