Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91710/?format=api
{ "id": 91710, "url": "http://patches.dpdk.org/api/patches/91710/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1618653299-40380-6-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618653299-40380-6-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618653299-40380-6-git-send-email-humin29@huawei.com", "date": "2021-04-17T09:54:57", "name": "[5/7] net/hns3: fix the check for VMDq mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "75760cfa9a674334aa54476e20f8524b80a02d2e", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1618653299-40380-6-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16463, "url": "http://patches.dpdk.org/api/series/16463/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16463", "date": "2021-04-17T09:54:52", "name": "features and bugfix for hns3 PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/16463/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/91710/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/91710/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 17D3AA0562;\n\tSat, 17 Apr 2021 11:55:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 71E2B161EF7;\n\tSat, 17 Apr 2021 11:54:58 +0200 (CEST)", "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by mails.dpdk.org (Postfix) with ESMTP id C03A340143\n for <dev@dpdk.org>; Sat, 17 Apr 2021 11:54:51 +0200 (CEST)", "from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FMpK90Byxz17R8P\n for <dev@dpdk.org>; Sat, 17 Apr 2021 17:52:29 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id\n 14.3.498.0; Sat, 17 Apr 2021 17:54:45 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Sat, 17 Apr 2021 17:54:57 +0800", "Message-ID": "<1618653299-40380-6-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1618653299-40380-1-git-send-email-humin29@huawei.com>", "References": "<1618653299-40380-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 5/7] net/hns3: fix the check for VMDq mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nHNS3 PF driver only supports RSS, DCB or NONE multiple queues mode.\nCurrently, driver doesn't verify the VMDq multi-queue mode completely.\nThis patch fixes the verification for VMDq mode.\n\nFixes: 62e3ccc2b94c (\"net/hns3: support flow control\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 28 ++++++++++++----------------\n 1 file changed, 12 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex b705a72..c276c6b 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -2224,23 +2224,16 @@ hns3_check_mq_mode(struct rte_eth_dev *dev)\n \tint max_tc = 0;\n \tint i;\n \n-\tdcb_rx_conf = &dev->data->dev_conf.rx_adv_conf.dcb_rx_conf;\n-\tdcb_tx_conf = &dev->data->dev_conf.tx_adv_conf.dcb_tx_conf;\n-\n-\tif (rx_mq_mode == ETH_MQ_RX_VMDQ_DCB_RSS) {\n-\t\thns3_err(hw, \"ETH_MQ_RX_VMDQ_DCB_RSS is not supported. \"\n-\t\t\t \"rx_mq_mode = %d\", rx_mq_mode);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tif (rx_mq_mode == ETH_MQ_RX_VMDQ_DCB ||\n-\t tx_mq_mode == ETH_MQ_TX_VMDQ_DCB) {\n-\t\thns3_err(hw, \"ETH_MQ_RX_VMDQ_DCB and ETH_MQ_TX_VMDQ_DCB \"\n-\t\t\t \"is not supported. rx_mq_mode = %d, tx_mq_mode = %d\",\n+\tif ((rx_mq_mode & ETH_MQ_RX_VMDQ_FLAG) ||\n+\t (tx_mq_mode == ETH_MQ_TX_VMDQ_DCB ||\n+\t tx_mq_mode == ETH_MQ_TX_VMDQ_ONLY)) {\n+\t\thns3_err(hw, \"VMDQ is not supported, rx_mq_mode = %d, tx_mq_mode = %d.\",\n \t\t\t rx_mq_mode, tx_mq_mode);\n-\t\treturn -EINVAL;\n+\t\treturn -EOPNOTSUPP;\n \t}\n \n+\tdcb_rx_conf = &dev->data->dev_conf.rx_adv_conf.dcb_rx_conf;\n+\tdcb_tx_conf = &dev->data->dev_conf.tx_adv_conf.dcb_tx_conf;\n \tif (rx_mq_mode & ETH_MQ_RX_DCB_FLAG) {\n \t\tif (dcb_rx_conf->nb_tcs > pf->tc_max) {\n \t\t\thns3_err(hw, \"nb_tcs(%u) > max_tc(%u) driver supported.\",\n@@ -2299,8 +2292,7 @@ hns3_check_dcb_cfg(struct rte_eth_dev *dev)\n \t\treturn -EOPNOTSUPP;\n \t}\n \n-\t/* Check multiple queue mode */\n-\treturn hns3_check_mq_mode(dev);\n+\treturn 0;\n }\n \n static int\n@@ -2473,6 +2465,10 @@ hns3_dev_configure(struct rte_eth_dev *dev)\n \t}\n \n \thw->adapter_state = HNS3_NIC_CONFIGURING;\n+\tret = hns3_check_mq_mode(dev);\n+\tif (ret)\n+\t\tgoto cfg_err;\n+\n \tif ((uint32_t)mq_mode & ETH_MQ_RX_DCB_FLAG) {\n \t\tret = hns3_check_dcb_cfg(dev);\n \t\tif (ret)\n", "prefixes": [ "5/7" ] }