Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91476/?format=api
{ "id": 91476, "url": "http://patches.dpdk.org/api/patches/91476/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210414220651.28691-2-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210414220651.28691-2-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210414220651.28691-2-dmitry.kozliuk@gmail.com", "date": "2021-04-14T22:06:48", "name": "[v10,1/4] eal/windows: hide asprintf() shim", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7c10a17a0ccb96c99981820e05288a4ada707e40", "submitter": { "id": 1581, "url": "http://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210414220651.28691-2-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 16380, "url": "http://patches.dpdk.org/api/series/16380/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16380", "date": "2021-04-14T22:06:47", "name": "eal/windows: do not expose POSIX symbols", "version": 10, "mbox": "http://patches.dpdk.org/series/16380/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/91476/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/91476/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 47E8DA0A02;\n\tThu, 15 Apr 2021 00:07:07 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 12B0C161D70;\n\tThu, 15 Apr 2021 00:07:06 +0200 (CEST)", "from mail-lf1-f48.google.com (mail-lf1-f48.google.com\n [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 8850E40685\n for <dev@dpdk.org>; Thu, 15 Apr 2021 00:07:01 +0200 (CEST)", "by mail-lf1-f48.google.com with SMTP id x19so5342138lfa.2\n for <dev@dpdk.org>; Wed, 14 Apr 2021 15:07:01 -0700 (PDT)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id m28sm271489lfo.278.2021.04.14.15.06.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 14 Apr 2021 15:06:59 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=cQFDOb309YnT7nxvUJfm9vl/Al/wDVZLeqExIlgjCXY=;\n b=K0BmtpXuq+/sSFbCYrObrCPKTlb3RlJrKOa5tZUjo4U9pQ3mXFvN5I0Xu06rLzMHck\n o5PqFEeKJ2kLEv+LYVi2xSSuK4aqdL1PcaDQxxjG7rNBYQZkVoZLBnkoNaOzUPb8oMXO\n Rfsgn2v7e+Ypq1r45r8uiWvvlOO9585UbungEDNdbuctPww33J1Ff5TTkDufiSl1vaN8\n bAuniKlVZpXu+1mi7vrMm2FtWhwC98sGjAE9ftGtU4CgYxpIx8VOZIKiKfV6jFvsfSV3\n r3RgPxdq/5dS3n/kguOCnQ0HaxuOe/xBpkSHT4CG20XFjyImA/wHMaM8AShK+gPcP/JT\n xv0A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=cQFDOb309YnT7nxvUJfm9vl/Al/wDVZLeqExIlgjCXY=;\n b=pR1OvAf2y1foAomollD2mtccPMCDN/FhoSQscKRHDxpdtf+MiYEZf+gTcytHppR7GI\n qviKBaK+Cj2JXSqhOX4i/XsbpXTvPyCZIAKVRa6DJCGqfxzELVGdD9RxRB0oJUZMo3Q6\n 1Ysnd2b4XTkBZutN1JsZv5moWnbX2Vyq9r72GSyomDgXr+pUDwgM/6zzZT69Rh1JYQBy\n 9D/UDfQtBh3gJMPjHFMNhLXILr4/WCRNrLaFDDL+RLxy2ci1+HIMKKzlh74bSyIngavt\n INTLfmgoyklCVmipLom81upggvIwMBoliestKv2zHrHtEZWkZjmYP14wHRKwxIruC612\n djWA==", "X-Gm-Message-State": "AOAM531zflPx/jWX/U2wRQ0RchMi9obDbss03MRN2X7JpOFf3SlJ6WGk\n txmKMSWue6n7i2szLnqJMc2p/ZQNvXOwFHOr", "X-Google-Smtp-Source": "\n ABdhPJyo/2d3I5U+Va6pZZxB3c2Mk6rTT9p0Ey5Td4tyo2NhIBdb2mGaYet9JArg/vJPp1UunZtzGw==", "X-Received": "by 2002:a05:6512:ba6:: with SMTP id\n b38mr235128lfv.128.1618438020766;\n Wed, 14 Apr 2021 15:07:00 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Khoa To <khot@microsoft.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Date": "Thu, 15 Apr 2021 01:06:48 +0300", "Message-Id": "<20210414220651.28691-2-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.29.3", "In-Reply-To": "<20210414220651.28691-1-dmitry.kozliuk@gmail.com>", "References": "<20210410224732.20234-1-dmitry.kozliuk@gmail.com>\n <20210414220651.28691-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v10 1/4] eal/windows: hide asprintf() shim", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Make asprintf(3) implementation for Windows private to EAL, so that it's\nhidden from external consumers. It is not exposed to internal consumers\neither, because they don't need asprintf() and also because callers from\nother modules would have no reliable way to free allocated memory.\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\nAcked-by: Khoa To <khot@microsoft.com>\n---\n lib/librte_eal/common/eal_private.h | 11 +++++++++\n lib/librte_eal/windows/eal.c | 30 +++++++++++++++++++++++++\n lib/librte_eal/windows/include/rte_os.h | 30 -------------------------\n 3 files changed, 41 insertions(+), 30 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h\nindex e3512111d9..64cf4e81c8 100644\n--- a/lib/librte_eal/common/eal_private.h\n+++ b/lib/librte_eal/common/eal_private.h\n@@ -716,4 +716,15 @@ void __rte_thread_init(unsigned int lcore_id, rte_cpuset_t *cpuset);\n */\n void __rte_thread_uninit(void);\n \n+/**\n+ * asprintf(3) replacement for Windows.\n+ */\n+#ifdef RTE_EXEC_ENV_WINDOWS\n+__rte_format_printf(2, 3)\n+int eal_asprintf(char **buffer, const char *format, ...);\n+\n+#define asprintf(buffer, format, ...) \\\n+\t\teal_asprintf(buffer, format, ##__VA_ARGS__)\n+#endif\n+\n #endif /* _EAL_PRIVATE_H_ */\ndiff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c\nindex 41be20d89f..28c787c0b0 100644\n--- a/lib/librte_eal/windows/eal.c\n+++ b/lib/librte_eal/windows/eal.c\n@@ -2,6 +2,8 @@\n * Copyright(c) 2019 Intel Corporation\n */\n \n+#include <stdarg.h>\n+\n #include <fcntl.h>\n #include <io.h>\n #include <share.h>\n@@ -416,6 +418,34 @@ rte_eal_init(int argc, char **argv)\n \treturn fctret;\n }\n \n+/* Don't use MinGW asprintf() to have identical code with all toolchains. */\n+int\n+eal_asprintf(char **buffer, const char *format, ...)\n+{\n+\tint size, ret;\n+\tva_list arg;\n+\n+\tva_start(arg, format);\n+\tsize = vsnprintf(NULL, 0, format, arg);\n+\tva_end(arg);\n+\tif (size < 0)\n+\t\treturn -1;\n+\tsize++;\n+\n+\t*buffer = malloc(size);\n+\tif (*buffer == NULL)\n+\t\treturn -1;\n+\n+\tva_start(arg, format);\n+\tret = vsnprintf(*buffer, size, format, arg);\n+\tva_end(arg);\n+\tif (ret != size - 1) {\n+\t\tfree(*buffer);\n+\t\treturn -1;\n+\t}\n+\treturn ret;\n+}\n+\n int\n rte_vfio_container_dma_map(__rte_unused int container_fd,\n \t\t\t__rte_unused uint64_t vaddr,\ndiff --git a/lib/librte_eal/windows/include/rte_os.h b/lib/librte_eal/windows/include/rte_os.h\nindex f0512f20a6..1afe49f35e 100644\n--- a/lib/librte_eal/windows/include/rte_os.h\n+++ b/lib/librte_eal/windows/include/rte_os.h\n@@ -10,7 +10,6 @@\n * which is not supported natively or named differently in Windows.\n */\n \n-#include <stdarg.h>\n #include <stdio.h>\n #include <stdlib.h>\n #include <string.h>\n@@ -71,34 +70,6 @@ extern \"C\" {\n typedef long long ssize_t;\n \n #ifndef RTE_TOOLCHAIN_GCC\n-\n-static inline int\n-asprintf(char **buffer, const char *format, ...)\n-{\n-\tint size, ret;\n-\tva_list arg;\n-\n-\tva_start(arg, format);\n-\tsize = vsnprintf(NULL, 0, format, arg);\n-\tva_end(arg);\n-\tif (size < 0)\n-\t\treturn -1;\n-\tsize++;\n-\n-\t*buffer = (char *)malloc(size);\n-\tif (*buffer == NULL)\n-\t\treturn -1;\n-\n-\tva_start(arg, format);\n-\tret = vsnprintf(*buffer, size, format, arg);\n-\tva_end(arg);\n-\tif (ret != size - 1) {\n-\t\tfree(*buffer);\n-\t\treturn -1;\n-\t}\n-\treturn ret;\n-}\n-\n static inline const char *\n eal_strerror(int code)\n {\n@@ -111,7 +82,6 @@ eal_strerror(int code)\n #ifndef strerror\n #define strerror eal_strerror\n #endif\n-\n #endif /* RTE_TOOLCHAIN_GCC */\n \n #ifdef __cplusplus\n", "prefixes": [ "v10", "1/4" ] }