Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/91037/?format=api
{ "id": 91037, "url": "http://patches.dpdk.org/api/patches/91037/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1618064637-16413-6-git-send-email-xuemingl@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618064637-16413-6-git-send-email-xuemingl@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618064637-16413-6-git-send-email-xuemingl@nvidia.com", "date": "2021-04-10T14:23:57", "name": "[v4,5/5] devargs: parse global device syntax", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "086e54bc288c9e3d95483215147548017e7849ef", "submitter": { "id": 1904, "url": "http://patches.dpdk.org/api/people/1904/?format=api", "name": "Xueming Li", "email": "xuemingl@nvidia.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1618064637-16413-6-git-send-email-xuemingl@nvidia.com/mbox/", "series": [ { "id": 16267, "url": "http://patches.dpdk.org/api/series/16267/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16267", "date": "2021-04-10T14:23:52", "name": "eal: enable global device syntax by default", "version": 4, "mbox": "http://patches.dpdk.org/series/16267/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/91037/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/91037/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0814DA0546;\n\tSat, 10 Apr 2021 16:24:44 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 53EF91412D5;\n\tSat, 10 Apr 2021 16:24:35 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id 531A51412D7\n for <dev@dpdk.org>; Sat, 10 Apr 2021 16:24:34 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n xuemingl@nvidia.com) with SMTP; 10 Apr 2021 17:24:32 +0300", "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 13AEO6E3018265;\n Sat, 10 Apr 2021 17:24:32 +0300" ], "From": "Xueming Li <xuemingl@nvidia.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Gaetan Rivet <gaetanr@nvidia.com>", "Cc": "dev@dpdk.org, xuemingl@nvidia.com, Asaf Penso <asafp@nvidia.com>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Date": "Sat, 10 Apr 2021 14:23:57 +0000", "Message-Id": "<1618064637-16413-6-git-send-email-xuemingl@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": [ "<1618064637-16413-1-git-send-email-xuemingl@nvidia.com>", "<1608304614-13908-2-git-send-email-xuemingl@nvidia.com>" ], "References": [ "<1618064637-16413-1-git-send-email-xuemingl@nvidia.com>", "<1608304614-13908-2-git-send-email-xuemingl@nvidia.com>" ], "Subject": "[dpdk-dev] [PATCH v4 5/5] devargs: parse global device syntax", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When parsing a devargs, try to parse using the global device syntax\nfirst. Fallback on legacy syntax on error.\n\nExample of new global device syntax:\n -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,dv_flow_en=1\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\nReviewed-by: Gaetan Rivet <grive@u256.net>\n---\n doc/guides/rel_notes/release_21_05.rst | 6 ++++++\n lib/librte_eal/common/eal_common_devargs.c | 16 ++++++++++++----\n lib/librte_eal/include/rte_devargs.h | 4 ++++\n lib/librte_ethdev/rte_ethdev.c | 1 -\n 4 files changed, 22 insertions(+), 5 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst\nindex 374d6d98ea..ff1459a4d1 100644\n--- a/doc/guides/rel_notes/release_21_05.rst\n+++ b/doc/guides/rel_notes/release_21_05.rst\n@@ -131,6 +131,12 @@ New Features\n * Added command to display Rx queue used descriptor count.\n ``show port (port_id) rxq (queue_id) desc used count``\n \n+* **Enabled new devargs parser.**\n+\n+ * Unified devargs storage buffer usage.\n+ * Added new bus driver api to allow bus driver contribute to devargs parsing.\n+ * Try new devargs syntax parser first, fallback to legacy syntax parser.\n+\n \n Removed Items\n -------------\ndiff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex 3a62521e05..069d8f8499 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -125,7 +125,6 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t\tlayers[i].str = s;\n \t\tlayers[i].kvlist = rte_kvargs_parse_delim(s, NULL, \"/\");\n \t\tif (layers[i].kvlist == NULL) {\n-\t\t\tRTE_LOG(ERR, EAL, \"Could not parse %s\\n\", s);\n \t\t\tret = -EINVAL;\n \t\t\tgoto get_out;\n \t\t}\n@@ -143,7 +142,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t\tkv = &layers[i].kvlist->pairs[0];\n \t\tif (kv->key == NULL)\n \t\t\tcontinue;\n-\t\tif (strcmp(kv->key, \"bus\") == 0) {\n+\t\tif (strcmp(kv->key, RTE_DEVARGS_KEY_BUS) == 0) {\n \t\t\tbus = rte_bus_find_by_name(kv->value);\n \t\t\tif (bus == NULL) {\n \t\t\t\tRTE_LOG(ERR, EAL, \"Could not find bus \\\"%s\\\"\\n\",\n@@ -151,7 +150,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t\t\t\tret = -EFAULT;\n \t\t\t\tgoto get_out;\n \t\t\t}\n-\t\t} else if (strcmp(kv->key, \"class\") == 0) {\n+\t\t} else if (strcmp(kv->key, RTE_DEVARGS_KEY_CLASS) == 0) {\n \t\t\tcls = rte_class_find_by_name(kv->value);\n \t\t\tif (cls == NULL) {\n \t\t\t\tRTE_LOG(ERR, EAL, \"Could not find class \\\"%s\\\"\\n\",\n@@ -159,7 +158,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t\t\t\tret = -EFAULT;\n \t\t\t\tgoto get_out;\n \t\t\t}\n-\t\t} else if (strcmp(kv->key, \"driver\") == 0) {\n+\t\t} else if (strcmp(kv->key, RTE_DEVARGS_KEY_DRIVER) == 0) {\n \t\t\t/* Ignore */\n \t\t\tcontinue;\n \t\t}\n@@ -224,6 +223,15 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)\n \tif (da == NULL)\n \t\treturn -EINVAL;\n \n+\t/* First parse according global device syntax. */\n+\tif (rte_devargs_layers_parse(da, dev) == 0) {\n+\t\tif (da->bus != NULL || da->cls != NULL)\n+\t\t\treturn 0;\n+\t\trte_devargs_reset(da);\n+\t}\n+\n+\t/* Otherwise fallback to legacy syntax: */\n+\n \t/* Retrieve eventual bus info */\n \tdo {\n \t\tdevname = dev;\ndiff --git a/lib/librte_eal/include/rte_devargs.h b/lib/librte_eal/include/rte_devargs.h\nindex 134b44a887..39e34ea02e 100644\n--- a/lib/librte_eal/include/rte_devargs.h\n+++ b/lib/librte_eal/include/rte_devargs.h\n@@ -25,6 +25,10 @@ extern \"C\" {\n #include <rte_compat.h>\n #include <rte_bus.h>\n \n+#define RTE_DEVARGS_KEY_BUS \"bus\"\n+#define RTE_DEVARGS_KEY_CLASS \"class\"\n+#define RTE_DEVARGS_KEY_DRIVER \"driver\"\n+\n /**\n * Type of generic device\n */\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex e11a95558f..9e9b136438 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -207,7 +207,6 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter, const char *devargs_str)\n \t * - 0000:08:00.0,representor=[1-3]\n \t * - pci:0000:06:00.0,representor=[0,5]\n \t * - class=eth,mac=00:11:22:33:44:55\n-\t * A new syntax is in development (not yet supported):\n \t * - bus=X,paramX=x/class=Y,paramY=y/driver=Z,paramZ=z\n \t */\n \n", "prefixes": [ "v4", "5/5" ] }