List comments

GET /api/patches/91/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 225,
        "web_url": "http://patches.dpdk.org/comment/225/",
        "msgid": "<1794712.d8vW817aRs@xps13>",
        "date": "2014-07-24T07:56:32",
        "subject": "Re: [dpdk-dev] [PATCH 2/5] ethdev: add new ops of\n\t'check_command_supported' and 'rx_classification_filter_ctl'",
        "submitter": {
            "id": 1,
            "url": "http://patches.dpdk.org/api/people/1/",
            "name": "Thomas Monjalon",
            "email": "thomas.monjalon@6wind.com"
        },
        "content": "2014-07-24 14:42, Helin Zhang:\n> Two ops of 'check_command_supported' and 'rx_classification_filter_ctl'\n> are added.\n> * 'check_command_supported' is for capability discovery. In anothoer\n>   word, it is to check if specific feature/command is supported by\n>   the specific port.\n\nThis generic service is really needed to add NIC-specific functions.\nI'd suggest to name it \"is_supported\".\n\n> * 'rx_classification_filter_ctl' is for receive classifcation filter\n>   configuring. e.g. hash function configuration, flow director\n>   configuration. It is a common API where a lot of commands can\n>   be implemented for different sub features.\n\nNot sure about this one. You are hiding specific API in an opaque structure.\nBy the way, it should be in another patch.\n\n> +/**\n> + * Check if the command is supported by an Ethernet device.\n> + *\n> + * @param port_id\n> + *   The port identifier of the Ethernet device.\n> + * @param cmd\n> + *   The command.\n> + *\n> + * @return\n> + *   - (> 0) The command is supported.\n> + *   - (0) The command is not supported.\n> + *   - (-ENOTSUP) if hardware doesn't support.\n> + *   - (-ENODEV) if <port_id> is invalid.\n> + */\n> +int rte_eth_dev_check_command_supported(uint8_t port_id, uint32_t cmd);\n\nWhat are the possible commands?\nYou should define enum/constants here.",
        "headers": {
            "Return-Path": "<thomas.monjalon@6wind.com>",
            "References": "<1406184149-11531-1-git-send-email-helin.zhang@intel.com>\n\t<1406184149-11531-3-git-send-email-helin.zhang@intel.com>",
            "X-Mailman-Version": "2.1.15",
            "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "X-List-Received-Date": "Thu, 24 Jul 2014 07:55:15 -0000",
            "User-Agent": "KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; )",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-BeenThere": "dev@dpdk.org",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "To": "Helin Zhang <helin.zhang@intel.com>",
            "MIME-Version": "1.0",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=8bBRI3EBxsUZ7F4aKFh5LUyMpNx7JnnFXR87ivafXNI=;\n\tb=OOxETZSQHaQNakORPfR9QG7PSZK4ru/qxx7z16CbZaMfyZB3lvKGvyXyeadgryDJjm\n\taKDUoBv/baX9Xfcozf2GPSkUQIsyCDNWXg8SprtkWu5K2Qv/MMq1GJO+3cEHuhC3hFYA\n\tuITPSDvcwEdMrUwb/A+eoi54UVqvDsBtQlITuPVa/tJvHnA8xWu8glUTm5YyJRbURjAi\n\tgovRdFTGKJNG+fVr795aG3X2xGBdngNG1e0TjVeHu99qVqwOX0+9YCrcYN5T/kScHMGz\n\t/Hz/Cq+uZjGWRznYFf3YFyT2BzFlQSdWfJ14TWJaATanNmoq2RBZ5ZdHBSiU4nonLNoj\n\tSfmA==",
            "Received": [
                "from mail-wi0-f180.google.com (mail-wi0-f180.google.com\n\t[209.85.212.180]) by dpdk.org (Postfix) with ESMTP id A0F9F5930\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 09:55:15 +0200 (CEST)",
                "by mail-wi0-f180.google.com with SMTP id n3so3491225wiv.7\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 00:56:42 -0700 (PDT)",
                "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tex4sm19862501wic.2.2014.07.24.00.56.40 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 24 Jul 2014 00:56:41 -0700 (PDT)"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 2/5] ethdev: add new ops of\n\t'check_command_supported' and 'rx_classification_filter_ctl'",
            "X-Received": "by 10.180.183.167 with SMTP id en7mr33124276wic.6.1406188602530; \n\tThu, 24 Jul 2014 00:56:42 -0700 (PDT)",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Message-ID": "<1794712.d8vW817aRs@xps13>",
            "Precedence": "list",
            "X-Gm-Message-State": "ALoCoQkZ8lgUt2/WIgVncSqnGLUH9uhYwsNlSqF8NVdfXJkUnaPxBk/QEmEAGC3mwVvTVZ7GqwGd",
            "Date": "Thu, 24 Jul 2014 09:56:32 +0200",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "dev@dpdk.org",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "In-Reply-To": "<1406184149-11531-3-git-send-email-helin.zhang@intel.com>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "Content-Transfer-Encoding": "7Bit",
            "Organization": "6WIND"
        }
    },
    {
        "id": 233,
        "web_url": "http://patches.dpdk.org/comment/233/",
        "msgid": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A762859@SHSMSX104.ccr.corp.intel.com>",
        "date": "2014-07-24T08:49:04",
        "subject": "Re: [dpdk-dev] [PATCH 2/5] ethdev: add new ops of\n\t'check_command_supported' and 'rx_classification_filter_ctl'",
        "submitter": {
            "id": 14,
            "url": "http://patches.dpdk.org/api/people/14/",
            "name": "Helin Zhang",
            "email": "helin.zhang@intel.com"
        },
        "content": "> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Thursday, July 24, 2014 3:57 PM\n> To: Zhang, Helin\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH 2/5] ethdev: add new ops of\n> 'check_command_supported' and 'rx_classification_filter_ctl'\n> \n> 2014-07-24 14:42, Helin Zhang:\n> > Two ops of 'check_command_supported' and 'rx_classification_filter_ctl'\n> > are added.\n> > * 'check_command_supported' is for capability discovery. In anothoer\n> >   word, it is to check if specific feature/command is supported by\n> >   the specific port.\n> \n> This generic service is really needed to add NIC-specific functions.\n> I'd suggest to name it \"is_supported\".\n> \nI tried to name it as the same style of rte_cpu_check_supported().\nAs you indicated, 'is_commmand_supported' might be a better name.\n\n> > * 'rx_classification_filter_ctl' is for receive classifcation filter\n> >   configuring. e.g. hash function configuration, flow director\n> >   configuration. It is a common API where a lot of commands can\n> >   be implemented for different sub features.\n> \n> Not sure about this one. You are hiding specific API in an opaque structure.\n> By the way, it should be in another patch.\n> \nWe want to implement several common API for NIC specific features, to avoid creating quite a lot of ops in 'struct eth_dev_ops'.\nThe idea came from ioctl.\n\n> > +/**\n> > + * Check if the command is supported by an Ethernet device.\n> > + *\n> > + * @param port_id\n> > + *   The port identifier of the Ethernet device.\n> > + * @param cmd\n> > + *   The command.\n> > + *\n> > + * @return\n> > + *   - (> 0) The command is supported.\n> > + *   - (0) The command is not supported.\n> > + *   - (-ENOTSUP) if hardware doesn't support.\n> > + *   - (-ENODEV) if <port_id> is invalid.\n> > + */\n> > +int rte_eth_dev_check_command_supported(uint8_t port_id, uint32_t\n> cmd);\n> \n> What are the possible commands?\n> You should define enum/constants here.\n> \nThe idea came from ioctl(). Enum could be a choice. The commands was defined in rte_eth_features.h. Comments should be added here for telling that.\n\n> --\n> Thomas",
        "headers": {
            "Return-Path": "<helin.zhang@intel.com>",
            "References": "<1406184149-11531-1-git-send-email-helin.zhang@intel.com>\n\t<1406184149-11531-3-git-send-email-helin.zhang@intel.com>\n\t<1794712.d8vW817aRs@xps13>",
            "X-Mailman-Version": "2.1.15",
            "X-IronPort-AV": "E=Sophos;i=\"5.01,722,1400050800\"; d=\"scan'208\";a=\"548283655\"",
            "From": "\"Zhang, Helin\" <helin.zhang@intel.com>",
            "x-originating-ip": "[10.239.127.40]",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Thread-Index": "AQHPpxTpD7BvbobRU0iF6EBVBYBd5Zuu50Ug",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "Thread-Topic": "[dpdk-dev] [PATCH 2/5] ethdev: add new ops of\n\t'check_command_supported' and 'rx_classification_filter_ctl'",
            "Accept-Language": "en-US",
            "X-List-Received-Date": "Thu, 24 Jul 2014 08:47:42 -0000",
            "Received": [
                "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 4313F5930\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 10:47:42 +0200 (CEST)",
                "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP; 24 Jul 2014 01:43:27 -0700",
                "from fmsmsx105.amr.corp.intel.com ([10.19.9.36])\n\tby orsmga001.jf.intel.com with ESMTP; 24 Jul 2014 01:49:07 -0700",
                "from fmsmsx120.amr.corp.intel.com (10.19.9.29) by\n\tFMSMSX105.amr.corp.intel.com (10.19.9.36) with Microsoft SMTP Server\n\t(TLS) id 14.3.123.3; Thu, 24 Jul 2014 01:49:07 -0700",
                "from shsmsx102.ccr.corp.intel.com (10.239.4.154) by\n\tfmsmsx120.amr.corp.intel.com (10.19.9.29) with Microsoft SMTP Server\n\t(TLS) id 14.3.123.3; Thu, 24 Jul 2014 01:49:07 -0700",
                "from shsmsx104.ccr.corp.intel.com ([169.254.5.204]) by\n\tshsmsx102.ccr.corp.intel.com ([169.254.2.120]) with mapi id\n\t14.03.0123.003; Thu, 24 Jul 2014 16:49:05 +0800"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH 2/5] ethdev: add new ops of\n\t'check_command_supported' and 'rx_classification_filter_ctl'",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Content-Language": "en-US",
            "Message-ID": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A762859@SHSMSX104.ccr.corp.intel.com>",
            "X-MS-Has-Attach": "",
            "X-BeenThere": "dev@dpdk.org",
            "Date": "Thu, 24 Jul 2014 08:49:04 +0000",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-ExtLoop1": "1",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "Precedence": "list",
            "In-Reply-To": "<1794712.d8vW817aRs@xps13>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "Content-Transfer-Encoding": "quoted-printable",
            "To": "Thomas Monjalon <thomas.monjalon@6wind.com>",
            "X-MS-TNEF-Correlator": ""
        }
    }
]