Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90996/?format=api
http://patches.dpdk.org/api/patches/90996/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1618017080-50053-8-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618017080-50053-8-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618017080-50053-8-git-send-email-humin29@huawei.com", "date": "2021-04-10T01:11:20", "name": "[v2,7/7] net/hns3: fix configure FEC when concurrent with reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8cce3bc73e42997ee715ad583126122db03986ec", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1618017080-50053-8-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16255, "url": "http://patches.dpdk.org/api/series/16255/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16255", "date": "2021-04-10T01:11:13", "name": "Bugfix for hns3 PMD", "version": 2, "mbox": "http://patches.dpdk.org/series/16255/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/90996/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/90996/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 15187A0547;\n\tSat, 10 Apr 2021 03:11:45 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AAB6D141169;\n\tSat, 10 Apr 2021 03:11:17 +0200 (CEST)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id 6391C14113A\n for <dev@dpdk.org>; Sat, 10 Apr 2021 03:11:10 +0200 (CEST)", "from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FHH1X0WndzNvTN\n for <dev@dpdk.org>; Sat, 10 Apr 2021 09:08:16 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id\n 14.3.498.0; Sat, 10 Apr 2021 09:11:01 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Sat, 10 Apr 2021 09:11:20 +0800", "Message-ID": "<1618017080-50053-8-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1618017080-50053-1-git-send-email-humin29@huawei.com>", "References": "<1617963365-41299-1-git-send-email-humin29@huawei.com>\n <1618017080-50053-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v2 7/7] net/hns3: fix configure FEC when\n concurrent with reset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengchang Tang <tangchengchang@huawei.com>\n\nCurrently, after the reset is complete, the PMD restores the FEC according\nto the FEC configuration reserved in the driver. If there is a concurrency\nbetween the FEC setup operation and the restore operation after a reset,\nthe FEC status of the last hardware may be unknown.\n\nThis patch adds the step of obtaining the lock when setting the FEC to\navoid concurrency between restore operation and setting operation.\n\nFixes: 9bf2ea8dbc65 (\"net/hns3: support FEC\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengchang Tang <tangchengchang@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex edace55..c359efc 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -6411,11 +6411,16 @@ hns3_fec_set(struct rte_eth_dev *dev, uint32_t mode)\n \t\treturn -EINVAL;\n \t}\n \n+\trte_spinlock_lock(&hw->lock);\n \tret = hns3_set_fec_hw(hw, mode);\n-\tif (ret)\n+\tif (ret) {\n+\t\trte_spinlock_unlock(&hw->lock);\n \t\treturn ret;\n+\t}\n \n \tpf->fec_mode = mode;\n+\trte_spinlock_unlock(&hw->lock);\n+\n \treturn 0;\n }\n \n", "prefixes": [ "v2", "7/7" ] }{ "id": 90996, "url": "