Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90995/?format=api
{ "id": 90995, "url": "http://patches.dpdk.org/api/patches/90995/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1618017080-50053-2-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618017080-50053-2-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618017080-50053-2-git-send-email-humin29@huawei.com", "date": "2021-04-10T01:11:14", "name": "[v2,1/7] net/hns3: remove variables of selecting Rx/Tx function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ab5ae8074c5db7a7c829ba5fa0fff4b5c0c4530f", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1618017080-50053-2-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16255, "url": "http://patches.dpdk.org/api/series/16255/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16255", "date": "2021-04-10T01:11:13", "name": "Bugfix for hns3 PMD", "version": 2, "mbox": "http://patches.dpdk.org/series/16255/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/90995/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/90995/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DE7CFA0547;\n\tSat, 10 Apr 2021 03:11:39 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 78FD9141163;\n\tSat, 10 Apr 2021 03:11:16 +0200 (CEST)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id 1504140688\n for <dev@dpdk.org>; Sat, 10 Apr 2021 03:11:10 +0200 (CEST)", "from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FHH1X1gv2zNvVt\n for <dev@dpdk.org>; Sat, 10 Apr 2021 09:08:16 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id\n 14.3.498.0; Sat, 10 Apr 2021 09:10:59 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Sat, 10 Apr 2021 09:11:14 +0800", "Message-ID": "<1618017080-50053-2-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1618017080-50053-1-git-send-email-humin29@huawei.com>", "References": "<1617963365-41299-1-git-send-email-humin29@huawei.com>\n <1618017080-50053-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v2 1/7] net/hns3: remove variables of selecting\n Rx/Tx function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nCurrently, there are four control variables (rx_simple_allowed,\nrx_vec_allowed, tx_simple_allowed and tx_vec_allowed) which are used\nto impact the selection of Rx/Tx burst function.\n\nThe purpose of the design is to provide a way to control the selection\nof Rx/Tx burst function by modifying it's values, but these variables\nhave no entry to modify unless make intrusive modifications.\n\nNow we already support runtime config to select Rx/Tx function, these\nvariables could be removed.\n\nFixes: a124f9e9591b (\"net/hns3: add runtime config to select IO burst function\")\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 5 -----\n drivers/net/hns3/hns3_ethdev.h | 5 -----\n drivers/net/hns3/hns3_ethdev_vf.c | 5 -----\n drivers/net/hns3/hns3_rxtx.c | 11 ++++-------\n 4 files changed, 4 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 6192705..19e2eca 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -2512,11 +2512,6 @@ hns3_dev_configure(struct rte_eth_dev *dev)\n \tif (ret)\n \t\tgoto cfg_err;\n \n-\thns->rx_simple_allowed = true;\n-\thns->rx_vec_allowed = true;\n-\thns->tx_simple_allowed = true;\n-\thns->tx_vec_allowed = true;\n-\n \thns3_init_rx_ptype_tble(dev);\n \thw->adapter_state = HNS3_NIC_CONFIGURED;\n \ndiff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h\nindex 4efa403..225a173 100644\n--- a/drivers/net/hns3/hns3_ethdev.h\n+++ b/drivers/net/hns3/hns3_ethdev.h\n@@ -777,11 +777,6 @@ struct hns3_adapter {\n \t\tstruct hns3_vf vf;\n \t};\n \n-\tbool rx_simple_allowed;\n-\tbool rx_vec_allowed;\n-\tbool tx_simple_allowed;\n-\tbool tx_vec_allowed;\n-\n \tuint32_t rx_func_hint;\n \tuint32_t tx_func_hint;\n \ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 5f8a460..2043b54 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -854,11 +854,6 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)\n \tif (ret)\n \t\tgoto cfg_err;\n \n-\thns->rx_simple_allowed = true;\n-\thns->rx_vec_allowed = true;\n-\thns->tx_simple_allowed = true;\n-\thns->tx_vec_allowed = true;\n-\n \thns3_init_rx_ptype_tble(dev);\n \n \thw->adapter_state = HNS3_NIC_CONFIGURED;\ndiff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex ebf7c82..7300f67 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -2805,10 +2805,9 @@ hns3_get_rx_function(struct rte_eth_dev *dev)\n \tuint64_t offloads = dev->data->dev_conf.rxmode.offloads;\n \tbool vec_allowed, sve_allowed, simple_allowed;\n \n-\tvec_allowed = hns->rx_vec_allowed &&\n-\t\t hns3_rx_check_vec_support(dev) == 0;\n+\tvec_allowed = hns3_rx_check_vec_support(dev) == 0;\n \tsve_allowed = vec_allowed && hns3_check_sve_support();\n-\tsimple_allowed = hns->rx_simple_allowed && !dev->data->scattered_rx &&\n+\tsimple_allowed = !dev->data->scattered_rx &&\n \t\t\t (offloads & DEV_RX_OFFLOAD_TCP_LRO) == 0;\n \n \tif (hns->rx_func_hint == HNS3_IO_FUNC_HINT_VEC && vec_allowed)\n@@ -4195,11 +4194,9 @@ hns3_get_tx_function(struct rte_eth_dev *dev, eth_tx_prep_t *prep)\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tbool vec_allowed, sve_allowed, simple_allowed;\n \n-\tvec_allowed = hns->tx_vec_allowed &&\n-\t\t hns3_tx_check_vec_support(dev) == 0;\n+\tvec_allowed = hns3_tx_check_vec_support(dev) == 0;\n \tsve_allowed = vec_allowed && hns3_check_sve_support();\n-\tsimple_allowed = hns->tx_simple_allowed &&\n-\t\t\t hns3_tx_check_simple_support(dev);\n+\tsimple_allowed = hns3_tx_check_simple_support(dev);\n \n \t*prep = NULL;\n \n", "prefixes": [ "v2", "1/7" ] }