Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90993/?format=api
{ "id": 90993, "url": "http://patches.dpdk.org/api/patches/90993/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1618017080-50053-7-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1618017080-50053-7-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1618017080-50053-7-git-send-email-humin29@huawei.com", "date": "2021-04-10T01:11:19", "name": "[v2,6/7] net/hns3: fix queue state when concurrent with reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "02c24aeb00aab119cbf5cf0e8ca39c932748520c", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1618017080-50053-7-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16255, "url": "http://patches.dpdk.org/api/series/16255/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16255", "date": "2021-04-10T01:11:13", "name": "Bugfix for hns3 PMD", "version": 2, "mbox": "http://patches.dpdk.org/series/16255/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/90993/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/90993/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E44DDA0547;\n\tSat, 10 Apr 2021 03:11:27 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AFC3014114D;\n\tSat, 10 Apr 2021 03:11:13 +0200 (CEST)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id 0110540688\n for <dev@dpdk.org>; Sat, 10 Apr 2021 03:11:08 +0200 (CEST)", "from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FHH1X1K4LzNvVR\n for <dev@dpdk.org>; Sat, 10 Apr 2021 09:08:16 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id\n 14.3.498.0; Sat, 10 Apr 2021 09:11:00 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Sat, 10 Apr 2021 09:11:19 +0800", "Message-ID": "<1618017080-50053-7-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1618017080-50053-1-git-send-email-humin29@huawei.com>", "References": "<1617963365-41299-1-git-send-email-humin29@huawei.com>\n <1618017080-50053-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v2 6/7] net/hns3: fix queue state when concurrent\n with reset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengchang Tang <tangchengchang@huawei.com>\n\nAt the end of the reset, the state of queues need to be restored according\nto the states saved in the driver. If the start and stop operations of the\nqueues are concurrent at this time, it may cause the final status to be\nuncertain.\n\nThis patch requires queues to acquire the hw lock before starting and\nstopping. If the device is being restored due to reset at this time, it\nwill block until the reset is completed.\n\nFixes: fa29fe45a7b4 (\"net/hns3: support queue start and stop\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengchang Tang <tangchengchang@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_rxtx.c | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex be93618..b45afcd 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -4270,10 +4270,12 @@ hns3_dev_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \tif (!hns3_dev_indep_txrx_supported(hw))\n \t\treturn -ENOTSUP;\n \n+\trte_spinlock_lock(&hw->lock);\n \tret = hns3_reset_queue(hw, rx_queue_id, HNS3_RING_TYPE_RX);\n \tif (ret) {\n \t\thns3_err(hw, \"fail to reset Rx queue %u, ret = %d.\",\n \t\t\t rx_queue_id, ret);\n+\t\trte_spinlock_unlock(&hw->lock);\n \t\treturn ret;\n \t}\n \n@@ -4281,11 +4283,13 @@ hns3_dev_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \tif (ret) {\n \t\thns3_err(hw, \"fail to init Rx queue %u, ret = %d.\",\n \t\t\t rx_queue_id, ret);\n+\t\trte_spinlock_unlock(&hw->lock);\n \t\treturn ret;\n \t}\n \n \thns3_enable_rxq(rxq, true);\n \tdev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;\n+\trte_spinlock_unlock(&hw->lock);\n \n \treturn ret;\n }\n@@ -4312,12 +4316,14 @@ hns3_dev_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \tif (!hns3_dev_indep_txrx_supported(hw))\n \t\treturn -ENOTSUP;\n \n+\trte_spinlock_lock(&hw->lock);\n \thns3_enable_rxq(rxq, false);\n \n \thns3_rx_queue_release_mbufs(rxq);\n \n \thns3_reset_sw_rxq(rxq);\n \tdev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;\n+\trte_spinlock_unlock(&hw->lock);\n \n \treturn 0;\n }\n@@ -4332,16 +4338,19 @@ hns3_dev_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)\n \tif (!hns3_dev_indep_txrx_supported(hw))\n \t\treturn -ENOTSUP;\n \n+\trte_spinlock_lock(&hw->lock);\n \tret = hns3_reset_queue(hw, tx_queue_id, HNS3_RING_TYPE_TX);\n \tif (ret) {\n \t\thns3_err(hw, \"fail to reset Tx queue %u, ret = %d.\",\n \t\t\t tx_queue_id, ret);\n+\t\trte_spinlock_unlock(&hw->lock);\n \t\treturn ret;\n \t}\n \n \thns3_init_txq(txq);\n \thns3_enable_txq(txq, true);\n \tdev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;\n+\trte_spinlock_unlock(&hw->lock);\n \n \treturn ret;\n }\n@@ -4355,6 +4364,7 @@ hns3_dev_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)\n \tif (!hns3_dev_indep_txrx_supported(hw))\n \t\treturn -ENOTSUP;\n \n+\trte_spinlock_lock(&hw->lock);\n \thns3_enable_txq(txq, false);\n \thns3_tx_queue_release_mbufs(txq);\n \t/*\n@@ -4366,6 +4376,7 @@ hns3_dev_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)\n \t */\n \thns3_init_txq(txq);\n \tdev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;\n+\trte_spinlock_unlock(&hw->lock);\n \n \treturn 0;\n }\n", "prefixes": [ "v2", "6/7" ] }