Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90905/?format=api
{ "id": 90905, "url": "http://patches.dpdk.org/api/patches/90905/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210408204849.9543-14-shirik@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210408204849.9543-14-shirik@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210408204849.9543-14-shirik@nvidia.com", "date": "2021-04-08T20:48:38", "name": "[13/24] common/mlx5: support general obj CREDENTIAL create", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fe43f3f008fb4430d1920a51c0e6ec8df52a3ff3", "submitter": { "id": 1894, "url": "http://patches.dpdk.org/api/people/1894/?format=api", "name": "Shiri Kuzin", "email": "shirik@nvidia.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210408204849.9543-14-shirik@nvidia.com/mbox/", "series": [ { "id": 16215, "url": "http://patches.dpdk.org/api/series/16215/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16215", "date": "2021-04-08T20:48:25", "name": "drivers: introduce mlx5 crypto PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/16215/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/90905/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/90905/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 65E07A0C46;\n\tThu, 8 Apr 2021 22:50:27 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DFD43141221;\n\tThu, 8 Apr 2021 22:49:49 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id E47B6141214\n for <dev@dpdk.org>; Thu, 8 Apr 2021 22:49:45 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n shirik@nvidia.com) with SMTP; 8 Apr 2021 23:49:45 +0300", "from nvidia.com (c-236-0-60-063.mtl.labs.mlnx [10.236.0.63])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 138KnAJW028067;\n Thu, 8 Apr 2021 23:49:44 +0300" ], "From": "Shiri Kuzin <shirik@nvidia.com>", "To": "dev@dpdk.org", "Cc": "matan@nvidia.com, gakhil@marvell.com, suanmingm@nvidia.com,\n Dekel Peled <dekelp@nvidia.com>", "Date": "Thu, 8 Apr 2021 23:48:38 +0300", "Message-Id": "<20210408204849.9543-14-shirik@nvidia.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20210408204849.9543-1-shirik@nvidia.com>", "References": "<1615447568-260965-1-git-send-email-matan@nvidia.com>\n <20210408204849.9543-1-shirik@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 13/24] common/mlx5: support general obj\n CREDENTIAL create", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dekel Peled <dekelp@nvidia.com>\n\nCREDENTIAL object is used for any crypto operation in wrapped mode.\n\nThis patch add support of CREDENTIAL object create operation.\nAdd reading of CREDENTIAL support capability.\nAdd function to create general object type CREDENTIAL, using DevX API.\n\nSigned-off-by: Dekel Peled <dekelp@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/common/mlx5/mlx5_devx_cmds.c | 53 +++++++++++++++++++++++++++-\n drivers/common/mlx5/mlx5_devx_cmds.h | 17 +++++++--\n drivers/common/mlx5/mlx5_prm.h | 23 ++++++++++++\n drivers/common/mlx5/version.map | 1 +\n 4 files changed, 91 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c\nindex 1b1227eb16..c43e320f87 100644\n--- a/drivers/common/mlx5/mlx5_devx_cmds.c\n+++ b/drivers/common/mlx5/mlx5_devx_cmds.c\n@@ -734,6 +734,8 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,\n \t\t MLX5_GENERAL_OBJ_TYPES_CAP_DEK);\n \tattr->import_kek = !!(general_obj_types_supported &\n \t\t\t MLX5_GENERAL_OBJ_TYPES_CAP_IMPORT_KEK);\n+\tattr->credential = !!(general_obj_types_supported &\n+\t\t\t MLX5_GENERAL_OBJ_TYPES_CAP_CREDENTIAL);\n \tattr->crypto_login = !!(general_obj_types_supported &\n \t\t\t\tMLX5_GENERAL_OBJ_TYPES_CAP_CRYPTO_LOGIN);\n \t/* Add reading of other GENERAL_OBJ_TYPES_CAP bits above this line. */\n@@ -2407,6 +2409,55 @@ mlx5_devx_cmd_create_import_kek_obj(void *ctx,\n \treturn import_kek_obj;\n }\n \n+/**\n+ * Create general object of type CREDENTIAL using DevX API.\n+ *\n+ * @param[in] ctx\n+ * Context returned from mlx5 open_device() glue function.\n+ * @param [in] attr\n+ * Pointer to CREDENTIAL attributes structure.\n+ *\n+ * @return\n+ * The DevX object created, NULL otherwise and rte_errno is set.\n+ */\n+struct mlx5_devx_obj *\n+mlx5_devx_cmd_create_credential_obj(void *ctx,\n+\t\t\t\t struct mlx5_devx_credential_attr *attr)\n+{\n+\tuint32_t in[MLX5_ST_SZ_DW(create_credential_in)] = {0};\n+\tuint32_t out[MLX5_ST_SZ_DW(general_obj_out_cmd_hdr)] = {0};\n+\tstruct mlx5_devx_obj *credential_obj = NULL;\n+\tvoid *ptr = NULL, *credential_addr = NULL;\n+\n+\tcredential_obj = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*credential_obj),\n+\t\t\t\t 0, SOCKET_ID_ANY);\n+\tif (credential_obj == NULL) {\n+\t\tDRV_LOG(ERR, \"Failed to allocate CREDENTIAL object data\");\n+\t\trte_errno = ENOMEM;\n+\t\treturn NULL;\n+\t}\n+\tptr = MLX5_ADDR_OF(create_credential_in, in, hdr);\n+\tMLX5_SET(general_obj_in_cmd_hdr, ptr, opcode,\n+\t\t MLX5_CMD_OP_CREATE_GENERAL_OBJECT);\n+\tMLX5_SET(general_obj_in_cmd_hdr, ptr, obj_type,\n+\t\t MLX5_GENERAL_OBJ_TYPE_CREDENTIAL);\n+\tptr = MLX5_ADDR_OF(create_credential_in, in, credential);\n+\tMLX5_SET(credential, ptr, credential_role, attr->credential_role);\n+\tcredential_addr = MLX5_ADDR_OF(credential, ptr, credential);\n+\tmemcpy(credential_addr, (void *)(attr->credential),\n+\t MLX5_CRYPTO_CREDENTIAL_SIZE);\n+\tcredential_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in),\n+\t\t\t\t\t\t\t out, sizeof(out));\n+\tif (credential_obj->obj == NULL) {\n+\t\trte_errno = errno;\n+\t\tDRV_LOG(ERR, \"Failed to create CREDENTIAL object using DevX.\");\n+\t\tmlx5_free(credential_obj);\n+\t\treturn NULL;\n+\t}\n+\tcredential_obj->id = MLX5_GET(general_obj_out_cmd_hdr, out, obj_id);\n+\treturn credential_obj;\n+}\n+\n /**\n * Create general object of type CRYPTO_LOGIN using DevX API.\n *\n@@ -2446,7 +2497,7 @@ mlx5_devx_cmd_create_crypto_login_obj(void *ctx,\n \t\t attr->session_import_kek_ptr);\n \tcredential_addr = MLX5_ADDR_OF(crypto_login, ptr, credential);\n \tmemcpy(credential_addr, (void *)(attr->credential),\n-\t MLX5_CRYPTO_LOGIN_CREDENTIAL_SIZE);\n+\t MLX5_CRYPTO_CREDENTIAL_SIZE);\n \tcrypto_login_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in),\n \t\t\t\t\t\t\t out, sizeof(out));\n \tif (crypto_login_obj->obj == NULL) {\ndiff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h\nindex b723aee126..1c952495bf 100644\n--- a/drivers/common/mlx5/mlx5_devx_cmds.h\n+++ b/drivers/common/mlx5/mlx5_devx_cmds.h\n@@ -133,6 +133,7 @@ struct mlx5_hca_attr {\n \tuint32_t aes_xts:1; /* AES-XTS crypto is supported. */\n \tuint32_t dek:1; /* General obj type DEK is supported. */\n \tuint32_t import_kek:1; /* General obj type IMPORT_KEK supported. */\n+\tuint32_t credential:1; /* General obj type CREDENTIAL supported. */\n \tuint32_t crypto_login:1; /* General obj type CRYPTO_LOGIN supported. */\n \tuint32_t regexp_num_of_engines;\n \tuint32_t log_max_ft_sampler_num:8;\n@@ -447,13 +448,20 @@ struct mlx5_devx_import_kek_attr {\n \tuint8_t key[MLX5_CRYPTO_KEY_MAX_SIZE];\n };\n \n-#define MLX5_CRYPTO_LOGIN_CREDENTIAL_SIZE\t48\n+#define MLX5_CRYPTO_CREDENTIAL_SIZE\t48\n+\n+struct mlx5_devx_credential_attr {\n+\tuint64_t modify_field_select;\n+\tuint32_t state:8;\n+\tuint32_t credential_role:8;\n+\tuint8_t credential[MLX5_CRYPTO_CREDENTIAL_SIZE];\n+};\n \n struct mlx5_devx_crypto_login_attr {\n \tuint64_t modify_field_select;\n \tuint32_t credential_pointer:24;\n \tuint32_t session_import_kek_ptr:24;\n-\tuint8_t credential[MLX5_CRYPTO_LOGIN_CREDENTIAL_SIZE];\n+\tuint8_t credential[MLX5_CRYPTO_CREDENTIAL_SIZE];\n };\n \n /* mlx5_devx_cmds.c */\n@@ -599,6 +607,11 @@ struct mlx5_devx_obj *\n mlx5_devx_cmd_create_import_kek_obj(void *ctx,\n \t\t\t\t struct mlx5_devx_import_kek_attr *attr);\n \n+__rte_internal\n+struct mlx5_devx_obj *\n+mlx5_devx_cmd_create_credential_obj(void *ctx,\n+\t\t\t\t struct mlx5_devx_credential_attr *attr);\n+\n __rte_internal\n struct mlx5_devx_obj *\n mlx5_devx_cmd_create_crypto_login_obj(void *ctx,\ndiff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h\nindex 736badb6df..69d6de8cbd 100644\n--- a/drivers/common/mlx5/mlx5_prm.h\n+++ b/drivers/common/mlx5/mlx5_prm.h\n@@ -1185,6 +1185,8 @@ enum {\n \t\t\t(1ULL << MLX5_GENERAL_OBJ_TYPE_DEK)\n #define MLX5_GENERAL_OBJ_TYPES_CAP_IMPORT_KEK \\\n \t\t\t(1ULL << MLX5_GENERAL_OBJ_TYPE_IMPORT_KEK)\n+#define MLX5_GENERAL_OBJ_TYPES_CAP_CREDENTIAL \\\n+\t\t\t(1ULL << MLX5_GENERAL_OBJ_TYPE_CREDENTIAL)\n #define MLX5_GENERAL_OBJ_TYPES_CAP_CRYPTO_LOGIN \\\n \t\t\t(1ULL << MLX5_GENERAL_OBJ_TYPE_CRYPTO_LOGIN)\n \n@@ -2471,6 +2473,7 @@ enum {\n \tMLX5_GENERAL_OBJ_TYPE_VIRTQ = 0x000d,\n \tMLX5_GENERAL_OBJ_TYPE_VIRTIO_Q_COUNTERS = 0x001c,\n \tMLX5_GENERAL_OBJ_TYPE_IMPORT_KEK = 0x001d,\n+\tMLX5_GENERAL_OBJ_TYPE_CREDENTIAL = 0x001e,\n \tMLX5_GENERAL_OBJ_TYPE_CRYPTO_LOGIN = 0x001f,\n \tMLX5_GENERAL_OBJ_TYPE_FLEX_PARSE_GRAPH = 0x0022,\n \tMLX5_GENERAL_OBJ_TYPE_FLOW_HIT_ASO = 0x0025,\n@@ -2581,6 +2584,26 @@ struct mlx5_ifc_create_import_kek_in_bits {\n \tstruct mlx5_ifc_import_kek_bits import_kek;\n };\n \n+enum {\n+\tMLX5_CREDENTIAL_ROLE_OFFICER = 0x0,\n+\tMLX5_CREDENTIAL_ROLE_USER = 0x1,\n+};\n+\n+struct mlx5_ifc_credential_bits {\n+\tu8 modify_field_select[0x40];\n+\tu8 state[0x8];\n+\tu8 reserved_at_48[0x10];\n+\tu8 credential_role[0x8];\n+\tu8 reserved_at_60[0x1a0];\n+\tu8 credential[0x180];\n+\tu8 reserved_at_380[0x480];\n+};\n+\n+struct mlx5_ifc_create_credential_in_bits {\n+\tstruct mlx5_ifc_general_obj_in_cmd_hdr_bits hdr;\n+\tstruct mlx5_ifc_credential_bits credential;\n+};\n+\n struct mlx5_ifc_crypto_login_bits {\n \tu8 modify_field_select[0x40];\n \tu8 reserved_at_40[0x48];\ndiff --git a/drivers/common/mlx5/version.map b/drivers/common/mlx5/version.map\nindex 045c0fc6fe..e1f0b324a0 100644\n--- a/drivers/common/mlx5/version.map\n+++ b/drivers/common/mlx5/version.map\n@@ -26,6 +26,7 @@ INTERNAL {\n \tmlx5_devx_cmd_create_geneve_tlv_option;\n mlx5_devx_cmd_create_dek_obj;\n mlx5_devx_cmd_create_import_kek_obj;\n+ mlx5_devx_cmd_create_credential_obj;\n mlx5_devx_cmd_create_crypto_login_obj;\n \tmlx5_devx_cmd_destroy;\n \tmlx5_devx_cmd_flow_counter_alloc;\n", "prefixes": [ "13/24" ] }