Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90854/?format=api
{ "id": 90854, "url": "http://patches.dpdk.org/api/patches/90854/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210408085151.54996-2-wei.huang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210408085151.54996-2-wei.huang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210408085151.54996-2-wei.huang@intel.com", "date": "2021-04-08T08:51:51", "name": "[v2,1/1] raw/ifpga/base: check size before assigning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "946fbedd671d51ad3ed6ec21974ca9e4f7d10165", "submitter": { "id": 2033, "url": "http://patches.dpdk.org/api/people/2033/?format=api", "name": "Wei Huang", "email": "wei.huang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210408085151.54996-2-wei.huang@intel.com/mbox/", "series": [ { "id": 16195, "url": "http://patches.dpdk.org/api/series/16195/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16195", "date": "2021-04-08T08:51:50", "name": "Fix coverity issues reported in DPDK-26381", "version": 2, "mbox": "http://patches.dpdk.org/series/16195/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/90854/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/90854/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E77AA0579;\n\tThu, 8 Apr 2021 10:57:45 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D8A0714118C;\n\tThu, 8 Apr 2021 10:57:42 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 9ED6F141184;\n Thu, 8 Apr 2021 10:57:40 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2021 01:57:40 -0700", "from unknown (HELO localhost.localdomain.sh.intel.com)\n ([10.238.175.107])\n by orsmga001.jf.intel.com with ESMTP; 08 Apr 2021 01:57:38 -0700" ], "IronPort-SDR": [ "\n LC6zvSr64zqf66MPEFKSF/NcPRxqeX35GXqdXOXYUbc3cwx/WD/daOqyg+7T0uPWrwB5bnr3cC\n Rl4yqIeNRztg==", "\n SdB/6zol2vTl4VP14MjwPclTa9Xr60QGgFrRBMYwPMCoybLxs0AdO8VlWOrkkBanbSWEUlzKna\n 2cqkN5gtTmEw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9947\"; a=\"173575038\"", "E=Sophos;i=\"5.82,205,1613462400\"; d=\"scan'208\";a=\"173575038\"", "E=Sophos;i=\"5.82,205,1613462400\"; d=\"scan'208\";a=\"458739858\"" ], "X-ExtLoop1": "1", "From": "Wei Huang <wei.huang@intel.com>", "To": "dev@dpdk.org,\n\trosen.xu@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "stable@dpdk.org, tianfei.zhang@intel.com, ferruh.yigit@intel.com,\n Wei Huang <wei.huang@intel.com>", "Date": "Thu, 8 Apr 2021 04:51:51 -0400", "Message-Id": "<20210408085151.54996-2-wei.huang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20210408085151.54996-1-wei.huang@intel.com>", "References": "<20210408085151.54996-1-wei.huang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/1] raw/ifpga/base: check size before\n assigning", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In max10_staging_area_init(), variable \"size\" from fdt_get_reg() may\nbe invalid, it should be checked before assigning to member variable\n\"staging_area_size\" of structure \"intel_max10_device\".\n\nCoverity issue: 367480, 367482\nFixes: 96ebfcf8125c (\"raw/ifpga/base: add SPI and MAX10 device driver\")\n\nSigned-off-by: Wei Huang <wei.huang@intel.com>\n---\nv2: check size before assigning to staging_area_size\n---\n drivers/raw/ifpga/base/opae_intel_max10.c | 2 +-\n drivers/raw/ifpga/base/opae_intel_max10.h | 1 +\n 2 files changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/raw/ifpga/base/opae_intel_max10.c b/drivers/raw/ifpga/base/opae_intel_max10.c\nindex 443e248fb3..c223fafa03 100644\n--- a/drivers/raw/ifpga/base/opae_intel_max10.c\n+++ b/drivers/raw/ifpga/base/opae_intel_max10.c\n@@ -593,7 +593,7 @@ static int max10_staging_area_init(struct intel_max10_device *dev)\n \t\t\tcontinue;\n \n \t\tret = fdt_get_reg(fdt_root, offset, 0, &start, &size);\n-\t\tif (!ret) {\n+\t\tif (!ret && (size <= MAX_STAGING_AREA_SIZE)) {\n \t\t\tdev->staging_area_base = start;\n \t\t\tdev->staging_area_size = size;\n \t\t}\ndiff --git a/drivers/raw/ifpga/base/opae_intel_max10.h b/drivers/raw/ifpga/base/opae_intel_max10.h\nindex 670683f017..e7142d6f0d 100644\n--- a/drivers/raw/ifpga/base/opae_intel_max10.h\n+++ b/drivers/raw/ifpga/base/opae_intel_max10.h\n@@ -182,6 +182,7 @@ struct opae_retimer_status {\n #define SBUS_VERSION\t\t\tGENMASK(31, 16)\n \n #define DFT_MAX_SIZE\t\t0x7e0000\n+#define MAX_STAGING_AREA_SIZE\t0x3800000\n \n int max10_reg_read(struct intel_max10_device *dev,\n \tunsigned int reg, unsigned int *val);\n", "prefixes": [ "v2", "1/1" ] }