Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90468/?format=api
{ "id": 90468, "url": "http://patches.dpdk.org/api/patches/90468/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210402105252.1145821-3-conor.walsh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210402105252.1145821-3-conor.walsh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210402105252.1145821-3-conor.walsh@intel.com", "date": "2021-04-02T10:52:49", "name": "[v6,2/5] examples/l3fwd: move l3fwd routes to common header", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7f6218629cc70aa50d07b5dc1a3762f480e2854a", "submitter": { "id": 1935, "url": "http://patches.dpdk.org/api/people/1935/?format=api", "name": "Conor Walsh", "email": "conor.walsh@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210402105252.1145821-3-conor.walsh@intel.com/mbox/", "series": [ { "id": 16084, "url": "http://patches.dpdk.org/api/series/16084/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16084", "date": "2021-04-02T10:52:48", "name": "examples/l3fwd: add FIB lookup method to l3fwd", "version": 6, "mbox": "http://patches.dpdk.org/series/16084/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/90468/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/90468/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E422FA0548;\n\tFri, 2 Apr 2021 12:53:18 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0A95B140F6A;\n\tFri, 2 Apr 2021 12:53:11 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 5AD0540141\n for <dev@dpdk.org>; Fri, 2 Apr 2021 12:53:07 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Apr 2021 03:53:06 -0700", "from silpixa00400466.ir.intel.com ([10.237.213.210])\n by fmsmga001.fm.intel.com with ESMTP; 02 Apr 2021 03:53:04 -0700" ], "IronPort-SDR": [ "\n YoYkQVYY74GVeFRcRL3w23oNM2whUP4KBE+GzAFQc6s/XLm6BdDQ5yBKi39A4Go++qCGFYDaTs\n yMqPRllG3o/A==", "\n 9fJrkrsTrQysh//n322zeN4NcVxfYYDfGCiugvfCqwPOVlcoz/kl00yrvVjjXbL2xjSQPqsbFm\n QE3T0VYg6Wew==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9941\"; a=\"179581695\"", "E=Sophos;i=\"5.81,299,1610438400\"; d=\"scan'208\";a=\"179581695\"", "E=Sophos;i=\"5.81,299,1610438400\"; d=\"scan'208\";a=\"517739742\"" ], "X-ExtLoop1": "1", "From": "Conor Walsh <conor.walsh@intel.com>", "To": "jerinj@marvell.com, stephen@networkplumber.org,\n bernard.iremonger@intel.com, konstantin.ananyev@intel.com,\n vladimir.medvedkin@intel.com, anatoly.burakov@intel.com", "Cc": "dev@dpdk.org,\n\tConor Walsh <conor.walsh@intel.com>", "Date": "Fri, 2 Apr 2021 10:52:49 +0000", "Message-Id": "<20210402105252.1145821-3-conor.walsh@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210402105252.1145821-1-conor.walsh@intel.com>", "References": "<20210315113439.1045223-1-conor.walsh@intel.com>\n <20210402105252.1145821-1-conor.walsh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 2/5] examples/l3fwd: move l3fwd routes to\n common header", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To prevent code duplication from the addition of lookup methods\nthe routes specified in lpm should be moved to a common header.\n\nSigned-off-by: Conor Walsh <conor.walsh@intel.com>\nAcked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\nAcked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>\n---\n examples/l3fwd/l3fwd_common_route.h | 48 +++++++++++++++++++\n examples/l3fwd/l3fwd_lpm.c | 74 +++++++----------------------\n 2 files changed, 65 insertions(+), 57 deletions(-)\n create mode 100644 examples/l3fwd/l3fwd_common_route.h", "diff": "diff --git a/examples/l3fwd/l3fwd_common_route.h b/examples/l3fwd/l3fwd_common_route.h\nnew file mode 100644\nindex 0000000000..7f0125a8a5\n--- /dev/null\n+++ b/examples/l3fwd/l3fwd_common_route.h\n@@ -0,0 +1,48 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2021 Intel Corporation\n+ */\n+\n+#include <stdint.h>\n+#include <rte_ip.h>\n+\n+struct ipv4_l3fwd_common_route {\n+\tuint32_t ip;\n+\tuint8_t depth;\n+\tuint8_t if_out;\n+};\n+\n+struct ipv6_l3fwd_common_route {\n+\tuint8_t ip[16];\n+\tuint8_t depth;\n+\tuint8_t if_out;\n+};\n+\n+/*\n+ * 198.18.0.0/16 are set aside for RFC2544 benchmarking (RFC5735).\n+ * 198.18.{0-7}.0/24 = Port {0-7}\n+ */\n+static const struct ipv4_l3fwd_common_route ipv4_l3fwd_common_route_array[] = {\n+\t{RTE_IPV4(198, 18, 0, 0), 24, 0},\n+\t{RTE_IPV4(198, 18, 1, 0), 24, 1},\n+\t{RTE_IPV4(198, 18, 2, 0), 24, 2},\n+\t{RTE_IPV4(198, 18, 3, 0), 24, 3},\n+\t{RTE_IPV4(198, 18, 4, 0), 24, 4},\n+\t{RTE_IPV4(198, 18, 5, 0), 24, 5},\n+\t{RTE_IPV4(198, 18, 6, 0), 24, 6},\n+\t{RTE_IPV4(198, 18, 7, 0), 24, 7},\n+};\n+\n+/*\n+ * 2001:200::/48 is IANA reserved range for IPv6 benchmarking (RFC5180).\n+ * 2001:200:0:{0-7}::/64 = Port {0-7}\n+ */\n+static const struct ipv6_l3fwd_common_route ipv6_l3fwd_common_route_array[] = {\n+\t{{32, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 0},\n+\t{{32, 1, 2, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 1},\n+\t{{32, 1, 2, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 2},\n+\t{{32, 1, 2, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 3},\n+\t{{32, 1, 2, 0, 0, 0, 0, 4, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 4},\n+\t{{32, 1, 2, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 5},\n+\t{{32, 1, 2, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 6},\n+\t{{32, 1, 2, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 7},\n+};\ndiff --git a/examples/l3fwd/l3fwd_lpm.c b/examples/l3fwd/l3fwd_lpm.c\nindex 1cfaf36572..818cf717d1 100644\n--- a/examples/l3fwd/l3fwd_lpm.c\n+++ b/examples/l3fwd/l3fwd_lpm.c\n@@ -30,47 +30,7 @@\n #include \"l3fwd.h\"\n #include \"l3fwd_event.h\"\n \n-struct ipv4_l3fwd_lpm_route {\n-\tuint32_t ip;\n-\tuint8_t depth;\n-\tuint8_t if_out;\n-};\n-\n-struct ipv6_l3fwd_lpm_route {\n-\tuint8_t ip[16];\n-\tuint8_t depth;\n-\tuint8_t if_out;\n-};\n-\n-/*\n- * 198.18.0.0/16 are set aside for RFC2544 benchmarking (RFC5735).\n- * 198.18.{0-7}.0/24 = Port {0-7}\n- */\n-static const struct ipv4_l3fwd_lpm_route ipv4_l3fwd_lpm_route_array[] = {\n-\t{RTE_IPV4(198, 18, 0, 0), 24, 0},\n-\t{RTE_IPV4(198, 18, 1, 0), 24, 1},\n-\t{RTE_IPV4(198, 18, 2, 0), 24, 2},\n-\t{RTE_IPV4(198, 18, 3, 0), 24, 3},\n-\t{RTE_IPV4(198, 18, 4, 0), 24, 4},\n-\t{RTE_IPV4(198, 18, 5, 0), 24, 5},\n-\t{RTE_IPV4(198, 18, 6, 0), 24, 6},\n-\t{RTE_IPV4(198, 18, 7, 0), 24, 7},\n-};\n-\n-/*\n- * 2001:200::/48 is IANA reserved range for IPv6 benchmarking (RFC5180).\n- * 2001:200:0:{0-7}::/64 = Port {0-7}\n- */\n-static const struct ipv6_l3fwd_lpm_route ipv6_l3fwd_lpm_route_array[] = {\n-\t{{32, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 0},\n-\t{{32, 1, 2, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 1},\n-\t{{32, 1, 2, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 2},\n-\t{{32, 1, 2, 0, 0, 0, 0, 3, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 3},\n-\t{{32, 1, 2, 0, 0, 0, 0, 4, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 4},\n-\t{{32, 1, 2, 0, 0, 0, 0, 5, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 5},\n-\t{{32, 1, 2, 0, 0, 0, 0, 6, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 6},\n-\t{{32, 1, 2, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0}, 64, 7},\n-};\n+#include \"l3fwd_common_route.h\"\n \n #define IPV4_L3FWD_LPM_MAX_RULES 1024\n #define IPV4_L3FWD_LPM_NUMBER_TBL8S (1 << 8)\n@@ -485,18 +445,18 @@ setup_lpm(const int socketid)\n \t\t\tsocketid);\n \n \t/* populate the LPM table */\n-\tfor (i = 0; i < RTE_DIM(ipv4_l3fwd_lpm_route_array); i++) {\n+\tfor (i = 0; i < RTE_DIM(ipv4_l3fwd_common_route_array); i++) {\n \t\tstruct in_addr in;\n \n \t\t/* skip unused ports */\n-\t\tif ((1 << ipv4_l3fwd_lpm_route_array[i].if_out &\n+\t\tif ((1 << ipv4_l3fwd_common_route_array[i].if_out &\n \t\t\t\tenabled_port_mask) == 0)\n \t\t\tcontinue;\n \n \t\tret = rte_lpm_add(ipv4_l3fwd_lpm_lookup_struct[socketid],\n-\t\t\tipv4_l3fwd_lpm_route_array[i].ip,\n-\t\t\tipv4_l3fwd_lpm_route_array[i].depth,\n-\t\t\tipv4_l3fwd_lpm_route_array[i].if_out);\n+\t\t\tipv4_l3fwd_common_route_array[i].ip,\n+\t\t\tipv4_l3fwd_common_route_array[i].depth,\n+\t\t\tipv4_l3fwd_common_route_array[i].if_out);\n \n \t\tif (ret < 0) {\n \t\t\trte_exit(EXIT_FAILURE,\n@@ -504,11 +464,11 @@ setup_lpm(const int socketid)\n \t\t\t\ti, socketid);\n \t\t}\n \n-\t\tin.s_addr = htonl(ipv4_l3fwd_lpm_route_array[i].ip);\n+\t\tin.s_addr = htonl(ipv4_l3fwd_common_route_array[i].ip);\n \t\tprintf(\"LPM: Adding route %s / %d (%d)\\n\",\n \t\t inet_ntop(AF_INET, &in, abuf, sizeof(abuf)),\n-\t\t\tipv4_l3fwd_lpm_route_array[i].depth,\n-\t\t\tipv4_l3fwd_lpm_route_array[i].if_out);\n+\t\t\tipv4_l3fwd_common_route_array[i].depth,\n+\t\t\tipv4_l3fwd_common_route_array[i].if_out);\n \t}\n \n \t/* create the LPM6 table */\n@@ -525,17 +485,17 @@ setup_lpm(const int socketid)\n \t\t\tsocketid);\n \n \t/* populate the LPM table */\n-\tfor (i = 0; i < RTE_DIM(ipv6_l3fwd_lpm_route_array); i++) {\n+\tfor (i = 0; i < RTE_DIM(ipv6_l3fwd_common_route_array); i++) {\n \n \t\t/* skip unused ports */\n-\t\tif ((1 << ipv6_l3fwd_lpm_route_array[i].if_out &\n+\t\tif ((1 << ipv6_l3fwd_common_route_array[i].if_out &\n \t\t\t\tenabled_port_mask) == 0)\n \t\t\tcontinue;\n \n \t\tret = rte_lpm6_add(ipv6_l3fwd_lpm_lookup_struct[socketid],\n-\t\t\tipv6_l3fwd_lpm_route_array[i].ip,\n-\t\t\tipv6_l3fwd_lpm_route_array[i].depth,\n-\t\t\tipv6_l3fwd_lpm_route_array[i].if_out);\n+\t\t\tipv6_l3fwd_common_route_array[i].ip,\n+\t\t\tipv6_l3fwd_common_route_array[i].depth,\n+\t\t\tipv6_l3fwd_common_route_array[i].if_out);\n \n \t\tif (ret < 0) {\n \t\t\trte_exit(EXIT_FAILURE,\n@@ -544,10 +504,10 @@ setup_lpm(const int socketid)\n \t\t}\n \n \t\tprintf(\"LPM: Adding route %s / %d (%d)\\n\",\n-\t\t inet_ntop(AF_INET6, ipv6_l3fwd_lpm_route_array[i].ip,\n+\t\t inet_ntop(AF_INET6, ipv6_l3fwd_common_route_array[i].ip,\n \t\t\t\t abuf, sizeof(abuf)),\n-\t\t ipv6_l3fwd_lpm_route_array[i].depth,\n-\t\t ipv6_l3fwd_lpm_route_array[i].if_out);\n+\t\t ipv6_l3fwd_common_route_array[i].depth,\n+\t\t ipv6_l3fwd_common_route_array[i].if_out);\n \t}\n }\n \n", "prefixes": [ "v6", "2/5" ] }