Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90439/?format=api
{ "id": 90439, "url": "http://patches.dpdk.org/api/patches/90439/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210402012621.7944-2-pallavi.kadam@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210402012621.7944-2-pallavi.kadam@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210402012621.7944-2-pallavi.kadam@intel.com", "date": "2021-04-02T01:26:19", "name": "[v3,1/3] build: enable iavf base code to build on windows", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "50978cce02edec6668ff39c3e89ae2aacc4b9ab0", "submitter": { "id": 1177, "url": "http://patches.dpdk.org/api/people/1177/?format=api", "name": "Kadam, Pallavi", "email": "pallavi.kadam@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210402012621.7944-2-pallavi.kadam@intel.com/mbox/", "series": [ { "id": 16067, "url": "http://patches.dpdk.org/api/series/16067/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16067", "date": "2021-04-02T01:26:21", "name": "Support ice PMD on Windows", "version": 3, "mbox": "http://patches.dpdk.org/series/16067/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/90439/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/90439/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 77199A0548;\n\tFri, 2 Apr 2021 02:55:07 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7B18D141022;\n\tFri, 2 Apr 2021 02:54:53 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id D281114100E\n for <dev@dpdk.org>; Fri, 2 Apr 2021 02:54:50 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Apr 2021 17:54:43 -0700", "from win-dpdk-pallavi.jf.intel.com (HELO localhost.localdomain)\n ([10.166.188.111])\n by fmsmga008.fm.intel.com with ESMTP; 01 Apr 2021 17:54:40 -0700" ], "IronPort-SDR": [ "\n 0C4kYLdMDuUjlsyAKe6/BcvLOXOQCBikimiAjDJFSCJIZwZURidVqwZVp41J3ghrwNx5w8DUvA\n VcuPGV0PSFUA==", "\n IbhkYjEQJDIo3jHzKYa5DQ8LSUpqQ0K4MD7qbSDH10N0Xm3oSkBBEQk7ArkYBLRHTeHgfkqBIV\n 4PSzAfPNUXVw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9941\"; a=\"172394107\"", "E=Sophos;i=\"5.81,298,1610438400\"; d=\"scan'208\";a=\"172394107\"", "E=Sophos;i=\"5.81,298,1610438400\"; d=\"scan'208\";a=\"412947668\"" ], "X-ExtLoop1": "1", "From": "Pallavi Kadam <pallavi.kadam@intel.com>", "To": "dev@dpdk.org,\n\tthomas@monjalon.net", "Cc": "dmitry.kozliuk@gmail.com, ranjit.menon@intel.com, qiming.yang@intel.com,\n qi.z.zhang@intel.com, ferruh.yigit@intel.com, pallavi.kadam@intel.com", "Date": "Thu, 1 Apr 2021 18:26:19 -0700", "Message-Id": "<20210402012621.7944-2-pallavi.kadam@intel.com>", "X-Mailer": "git-send-email 2.18.0.windows.1", "In-Reply-To": "<20210402012621.7944-1-pallavi.kadam@intel.com>", "References": "<20210311015848.4976-1-pallavi.kadam@intel.com>\n <20210402012621.7944-1-pallavi.kadam@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 1/3] build: enable iavf base code to build on\n windows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Enable IAVF driver to build on Windows as it is required\nto build ice PMD.\nDisable all other drivers from common directory.\nThis patch also includes fix for a macro redefinition warning\nin the IAVF driver.\n\nSigned-off-by: Pallavi Kadam <pallavi.kadam@intel.com>\nReviewed-by: Ranjit Menon <ranjit.menon@intel.com>\nAcked-by: Jie Zhou <jizh@microsoft.com>\n---\n drivers/common/cpt/meson.build | 6 ++++++\n drivers/common/iavf/iavf_osdep.h | 9 +++++++++\n drivers/common/meson.build | 3 ---\n drivers/common/mvep/meson.build | 6 ++++++\n drivers/common/octeontx/meson.build | 6 ++++++\n drivers/common/octeontx2/meson.build | 6 ++++++\n drivers/common/qat/meson.build | 6 ++++++\n 7 files changed, 39 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/common/cpt/meson.build b/drivers/common/cpt/meson.build\nindex beecf0da3..1127267ba 100644\n--- a/drivers/common/cpt/meson.build\n+++ b/drivers/common/cpt/meson.build\n@@ -1,6 +1,12 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2018 Cavium, Inc\n \n+if is_windows\n+\tbuild = false\n+\treason = 'not supported on Windows'\n+\tsubdir_done()\n+endif\n+\n sources = files('cpt_fpm_tables.c',\n \t\t'cpt_pmd_ops_helper.c')\n \ndiff --git a/drivers/common/iavf/iavf_osdep.h b/drivers/common/iavf/iavf_osdep.h\nindex eaefde88e..76c186a5b 100644\n--- a/drivers/common/iavf/iavf_osdep.h\n+++ b/drivers/common/iavf/iavf_osdep.h\n@@ -55,6 +55,15 @@ typedef uint64_t s64;\n #define __be64 uint64_t\n #endif\n \n+/* Avoid macro redefinition warning on Windows */\n+#ifdef RTE_EXEC_ENV_WINDOWS\n+#ifdef min\n+#undef min\n+#endif\n+#ifdef max\n+#undef max\n+#endif\n+#endif\n #define min(a, b) RTE_MIN(a, b)\n #define max(a, b) RTE_MAX(a, b)\n \ndiff --git a/drivers/common/meson.build b/drivers/common/meson.build\nindex 66e12143b..438302e76 100644\n--- a/drivers/common/meson.build\n+++ b/drivers/common/meson.build\n@@ -1,9 +1,6 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2018 Cavium, Inc\n \n-if is_windows\n-\tsubdir_done()\n-endif\n \n std_deps = ['eal']\n drivers = ['cpt', 'dpaax', 'iavf', 'mvep', 'octeontx', 'octeontx2']\ndiff --git a/drivers/common/mvep/meson.build b/drivers/common/mvep/meson.build\nindex 7cd968b38..a929e2311 100644\n--- a/drivers/common/mvep/meson.build\n+++ b/drivers/common/mvep/meson.build\n@@ -4,6 +4,12 @@\n # All rights reserved.\n #\n \n+if is_windows\n+\tbuild = false\n+\treason = 'not supported on Windows'\n+\tsubdir_done()\n+endif\n+\n dep = dependency('libmusdk', required: false, method: 'pkg-config')\n if not dep.found()\n \tbuild = false\ndiff --git a/drivers/common/octeontx/meson.build b/drivers/common/octeontx/meson.build\nindex 203d1ef49..02b57b95c 100644\n--- a/drivers/common/octeontx/meson.build\n+++ b/drivers/common/octeontx/meson.build\n@@ -2,4 +2,10 @@\n # Copyright(c) 2018 Cavium, Inc\n #\n \n+if is_windows\n+\tbuild = false\n+\treason = 'not supported on Windows'\n+\tsubdir_done()\n+endif\n+\n sources = files('octeontx_mbox.c')\ndiff --git a/drivers/common/octeontx2/meson.build b/drivers/common/octeontx2/meson.build\nindex 84fb11524..97293d1a7 100644\n--- a/drivers/common/octeontx2/meson.build\n+++ b/drivers/common/octeontx2/meson.build\n@@ -2,6 +2,12 @@\n # Copyright(C) 2019 Marvell International Ltd.\n #\n \n+if is_windows\n+\tbuild = false\n+\treason = 'not supported on Windows'\n+\tsubdir_done()\n+endif\n+\n if not dpdk_conf.get('RTE_ARCH_64')\n \tbuild = false\n \treason = 'only supported on 64-bit'\ndiff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build\nindex 67f7aca97..3ad7dd501 100644\n--- a/drivers/common/qat/meson.build\n+++ b/drivers/common/qat/meson.build\n@@ -1,6 +1,12 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017-2018 Intel Corporation\n \n+if is_windows\n+\tbuild = false\n+\treason = 'not supported on Windows'\n+\tsubdir_done()\n+endif\n+\n qat_crypto = true\n qat_crypto_path = 'crypto/qat'\n qat_crypto_relpath = '../../' + qat_crypto_path\n", "prefixes": [ "v3", "1/3" ] }